find() returns empty list with nested EmbeddedJsonModel

[abrookins]

Problem

find() silently returns an empty list for models with EmbeddedJsonModel fields, even when matching records exist in Redis.

Example

class ExperimentMetadata(JsonModel):
    class Meta:
        embedded = True
    factors: Dict[str, Any] = Field(default_factory=dict)

class Experiment(JsonModel):
    exp_name: str = Field(index=True)
    experiment_metadata: ExperimentMetadata = Field(default_factory=ExperimentMetadata)

# This returns [] even when records exist
Experiment.find(Experiment.exp_name == "test1").all()

Impact

• Silent failures are confusing for users
• Users may think their data wasn't saved when it actually was
• No error message to help diagnose the problem

Related

• find() always returns empty list with Nested Model even though JSONModel is used (Silently) #675 (original user report)

Investigation Needed

• Determine why queries fail with nested models
• Check if the index is being created correctly
• Verify the RediSearch query syntax for nested model scenarios

[abrookins]

Cannot reproduce with current main branch.

Tested the exact scenario from issue #675:

class ExperimentMetadata(JsonModel):
    class Meta:
        embedded = True
    factors: Dict[str, Any] = Field(default_factory=dict)

class Experiment(JsonModel, index=True):
    exp_name: str = Field(index=True)
    experiment_metadata: ExperimentMetadata = Field(default_factory=ExperimentMetadata)

# This now works correctly
results = Experiment.find(Experiment.exp_name == "test1").all()
# Returns [Experiment(pk='...', exp_name='test1', ...)]

Key finding: The original issue was likely user error - missing index=True on the parent model class. Current code:

1. Properly rejects save() on non-indexed models with a clear error:

   RedisModelError: You cannot create a key on a model that is not indexed. Update your class with index=True

2. find() works correctly for models with nested EmbeddedJsonModel fields.

The current test suite (tests/test_json_model.py) has extensive coverage for EmbeddedJsonModel with find() queries - all passing.

Closing as the functionality works correctly.