From e2425c6667b961bb98644ae10cbe8a7851cef59f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nivaldo=20Bondan=C3=A7a?= Date: Fri, 23 Oct 2026 17:21:34 -0700 Subject: [PATCH] Migrate DeviceInfoModuleTest off JUnit3 TestCase base Summary: Drop the vestigial `: TestCase()` base (already on Robolectric runner with `Test`/`Before` annotations and Truth assertions); drop the `override` modifier on `setUp`. Differential Revision: D127203153 --- .../react/modules/deviceinfo/DeviceInfoModuleTest.kt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt index a609d5b5d368..2341e17b738f 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt @@ -33,7 +33,6 @@ import com.facebook.testutils.shadows.ShadowNativeMap import com.facebook.testutils.shadows.ShadowReadableNativeMap import com.facebook.testutils.shadows.ShadowSoLoader import com.facebook.testutils.shadows.ShadowWritableNativeMap -import junit.framework.TestCase import org.assertj.core.api.Assertions.assertThat import org.junit.After import org.junit.Before @@ -64,7 +63,7 @@ import org.robolectric.annotation.Config ShadowReadableNativeMap::class, ], ) -class DeviceInfoModuleTest : TestCase() { +class DeviceInfoModuleTest { private lateinit var deviceInfoModule: DeviceInfoModule private lateinit var fakePortraitDisplayMetrics: WritableMap @@ -73,7 +72,7 @@ class DeviceInfoModuleTest : TestCase() { private lateinit var displayMetricsHolder: MockedStatic @Before - public override fun setUp() { + fun setUp() { ReactNativeFeatureFlagsForTests.setUp() fakePortraitDisplayMetrics = JavaOnlyMap() fakePortraitDisplayMetrics.putInt("width", 100)