Delete orphan RCTBridgeProxy shims

Summary:
Remove proxy shims whose declarations were deleted from private headers (`parentBridge`, `bridgeDescription`, `moduleProvider`, `batchedBridge`, profiling, `callNativeModule`, `logMessage`, `_immediatelyCallTimer`, `moduleSetupComplete`, `updateModuleWithInstance:`) and never-declared ones (`runtime`, `object`, write-only `jsCallInvoker`). Shims backing deleted public API stay as runtime nets.

Changelog: [Internal]

Differential Revision: D127294703

Author: christophpurrer

packages/react-native/React/Base/RCTBridge+Private.h

@@ -26,13 +26,6 @@ RCT_EXTERN void RCTRegisterModule(Class);
  */
 - (void)enqueueCallback:(NSNumber *)cbID args:(NSArray *)args;
 
-/**
- * This property is mostly used on the main thread, but may be touched from
- * a background thread if the RCTBridge happens to deallocate on a background
- * thread. Therefore, we want all writes to it to be seen atomically.
- */
-@property (atomic, strong) RCTBridge *batchedBridge;
-
 /**
  * An object that allows one to require NativeModules/TurboModules.
  * RCTModuleRegistry is implemented in bridgeless mode and bridge mode.

packages/react-native/React/Base/RCTBridge.h

@@ -29,7 +29,6 @@
  * For this reason, the block should always return new module instances, and
  * module instances should not be shared between bridges.
  */
-typedef NSArray<id<RCTBridgeModule>> * (^RCTBridgeModuleListProvider)(void);
 
 RCT_EXTERN_C_BEGIN
 

packages/react-native/React/Base/RCTBridgeProxy+Cxx.h

@@ -6,13 +6,11 @@
  */
 
 #import "RCTBridgeProxy.h"
-#import "RCTBridgeProxy+Cxx.h"
 
 #import <React/RCTBridge+Private.h>
 #import <React/RCTBridge.h>
 #import <React/RCTLog.h>
 #import <React/RCTUIManager.h>
-#import <ReactCommon/CallInvoker.h>
 #import <jsi/jsi.h>
 
 using namespace facebook;
@@ -24,12 +22,6 @@ - (NSMethodSignature *)methodSignatureForSelector:(SEL)sel;
 - (void)forwardInvocation:(NSInvocation *)invocation;
 @end
 
-@interface RCTBridgeProxy ()
-
-@property (nonatomic, readwrite) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-
-@end
-
 @implementation RCTBridgeProxy {
   RCTUIManagerProxy *_uiManagerProxy;
   RCTModuleRegistry *_moduleRegistry;
@@ -38,7 +30,6 @@ @implementation RCTBridgeProxy {
   NSDictionary *_launchOptions;
   void (^_dispatchToJSThread)(dispatch_block_t);
   void (^_registerSegmentWithId)(NSNumber *, NSString *);
-  void *_runtime;
 }
 
 @synthesize performanceLogger = _performanceLogger;
@@ -62,7 +53,6 @@ - (instancetype)initWithViewRegistry:(RCTViewRegistry *)viewRegistry
     _callableJSModules = callableJSModules;
     _dispatchToJSThread = dispatchToJSThread;
     _registerSegmentWithId = registerSegmentWithId;
-    _runtime = runtime;
     _launchOptions = [launchOptions copy];
   }
 
@@ -92,22 +82,6 @@ - (Class)executorClass
   return nil;
 }
 
-/**
- * Used By:
- *  - RCTBlobCollector
- */
-- (void *)runtime
-{
-  [self logWarning:@"Please migrate to C++ TurboModule or RuntimeExecutor." cmd:_cmd];
-  return _runtime;
-}
-
-- (std::shared_ptr<facebook::react::CallInvoker>)jsCallInvoker
-{
-  [self logWarning:@"Please migrate to RuntimeExecutor" cmd:_cmd];
-  return _jsCallInvoker;
-}
-
 /**
  * RCTModuleRegistry
  */
@@ -241,61 +215,16 @@ - (BOOL)isBatchActive
   return NO;
 }
 
-/**
- * RCTBridge ()
- */
-
-- (NSString *)bridgeDescription
-{
-  [self logWarning:@"This method is not supported. Returning \"BridgeProxy\"." cmd:_cmd];
-  return @"BridgeProxy";
-}
-
 - (void)enqueueCallback:(NSNumber *)cbID args:(NSArray *)args
 {
   [self logError:@"This method is not supported. No-oping." cmd:_cmd];
 }
 
-- (RCTBridge *)batchedBridge
-{
-  [self logWarning:@"This method is not supported. Returning bridge proxy." cmd:_cmd];
-  return (RCTBridge *)self;
-}
-
-- (void)setBatchedBridge
-{
-  [self logError:@"This method is not supported. No-oping." cmd:_cmd];
-}
-
-- (RCTBridgeModuleListProvider)moduleProvider
-{
-  [self logWarning:@"This method is not supported. Returning empty block" cmd:_cmd];
-  return ^{
-    return @[];
-  };
-}
-
 - (RCTModuleRegistry *)moduleRegistry
 {
   return _moduleRegistry;
 }
 
-/**
- * RCTBridge (RCTCxxBridge)
- */
-
-- (RCTBridge *)parentBridge
-{
-  [self logWarning:@"This method is not supported. Returning bridge proxy." cmd:_cmd];
-  return (RCTBridge *)self;
-}
-
-- (BOOL)moduleSetupComplete
-{
-  [self logWarning:@"This method is not supported. Returning YES." cmd:_cmd];
-  return YES;
-}
-
 - (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
 {
   [self
@@ -304,37 +233,6 @@ - (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules
            cmd:_cmd];
 }
 
-- (void)updateModuleWithInstance:(id<RCTBridgeModule>)instance
-{
-  [self logError:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (void)startProfiling
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (void)stopProfiling:(void (^)(NSData *))callback
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (id)callNativeModule:(NSUInteger)moduleID method:(NSUInteger)methodID params:(NSArray *)params
-{
-  [self logError:@"This method is not supported. Nooping and returning nil." cmd:_cmd];
-  return nil;
-}
-
-- (void)logMessage:(NSString *)message level:(NSString *)level
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
-- (void)_immediatelyCallTimer:(NSNumber *)timer
-{
-  [self logWarning:@"This method is not supported. Nooping." cmd:_cmd];
-}
-
 /**
  * RCTBridge (RCTUIManager)
  */
@@ -343,11 +241,6 @@ - (RCTUIManager *)uiManager
   return (RCTUIManager *)_uiManagerProxy;
 }
 
-- (RCTBridgeProxy *)object
-{
-  return self;
-}
-
 /**
  * NSProxy setup
  */

packages/react-native/React/Base/RCTBridgeProxy.mm

@@ -15,7 +15,6 @@
 #import <React/RCTBridge.h>
 #import <React/RCTBridgeModule.h>
 #import <React/RCTBridgeModuleDecorator.h>
-#import <React/RCTBridgeProxy+Cxx.h>
 #import <React/RCTBridgeProxy.h>
 #import <React/RCTComponentViewFactory.h>
 #import <React/RCTConstants.h>
@@ -323,7 +322,6 @@ - (void)_start
           }
           runtime:_reactInstance->getJavaScriptContext()
           launchOptions:_launchOptions];
-  bridgeProxy.jsCallInvoker = jsCallInvoker;
   bridgeProxy.performanceLogger = _performanceLogger;
   _bridgeProxy = bridgeProxy;
 

packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm

@@ -21,10 +21,6 @@ category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -21,10 +21,6 @@ category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -21,10 +21,6 @@ category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -21,10 +21,6 @@ category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }
 
-category RCTBridgeProxy(Cxx) {
-  public @property (assign) std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker;
-}
-
 category RCTBridgeProxy(RCTAccessibilityManager) {
   public @property (assign, readonly) RCTAccessibilityManager* accessibilityManager;
 }