Skip to content

Commit 5778d64

Browse files
Bridgeless-context SimpleViewPropertyTest (#59255)
Summary: Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext` and add the `ShadowSoLoader` Robolectric shadow the bridgeless helper needs. Changelog: [Internal] Differential Revision: D126543381
1 parent 114e449 commit 5778d64

1 file changed

Lines changed: 7 additions & 12 deletions

File tree

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/SimpleViewPropertyTest.kt‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,30 +5,28 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
// TODO T207169925: Migrate CatalystInstance to Reacthost and remove the Suppress("DEPRECATION")
9-
// annotation
10-
@file:Suppress("DEPRECATION")
11-
128
package com.facebook.react.uimanager
139

1410
import android.view.View
15-
import com.facebook.react.bridge.BridgeReactContext
16-
import com.facebook.react.bridge.CatalystInstance
1711
import com.facebook.react.bridge.JavaOnlyMap
18-
import com.facebook.react.bridge.ReactTestHelper.createMockCatalystInstance
12+
import com.facebook.react.bridge.ReactApplicationContext
13+
import com.facebook.react.bridge.ReactTestHelper.createTestReactApplicationContext
1914
import com.facebook.react.bridge.ReadableMap
2015
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests
2116
import com.facebook.react.touch.JSResponderHandler
2217
import com.facebook.react.uimanager.annotations.ReactProp
18+
import com.facebook.testutils.shadows.ShadowSoLoader
2319
import org.assertj.core.api.Assertions
2420
import org.junit.Before
2521
import org.junit.Test
2622
import org.junit.runner.RunWith
2723
import org.robolectric.RobolectricTestRunner
2824
import org.robolectric.RuntimeEnvironment
25+
import org.robolectric.annotation.Config
2926

3027
/** Verify [View] view property being applied properly by [SimpleViewManager] */
3128
@RunWith(RobolectricTestRunner::class)
29+
@Config(shadows = [ShadowSoLoader::class])
3230
class SimpleViewPropertyTest {
3331

3432
private class ConcreteViewManager : SimpleViewManager<View>() {
@@ -49,17 +47,14 @@ class SimpleViewPropertyTest {
4947
}
5048
}
5149

52-
private lateinit var context: BridgeReactContext
53-
private lateinit var catalystInstanceMock: CatalystInstance
50+
private lateinit var context: ReactApplicationContext
5451
private lateinit var themedContext: ThemedReactContext
5552
private lateinit var manager: ConcreteViewManager
5653

5754
@Before
5855
fun setup() {
5956
ReactNativeFeatureFlagsForTests.setUp()
60-
context = BridgeReactContext(RuntimeEnvironment.getApplication())
61-
catalystInstanceMock = createMockCatalystInstance()
62-
context.initializeWithInstance(catalystInstanceMock)
57+
context = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
6358
themedContext = ThemedReactContext(context, context, null, surfaceId)
6459
manager = ConcreteViewManager()
6560
}

0 commit comments

Comments
 (0)