Prune dead RCTBridge private declarations (#59319)

Summary:
Pull Request resolved: #59319

Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.

Changelog:
[Internal]

Reviewed By: shwanton

Differential Revision: D126592134

fbshipit-source-id: 08d97f2da54fb1e70ff3782514a20c2da962e171

Author: christophpurrer

packages/react-native/React/Base/RCTBridge+Private.h

@@ -8,7 +8,6 @@
 #import <React/RCTBridge.h>
 
 @class RCTModuleRegistry;
-@class RCTModuleData;
 @protocol RCTJavaScriptExecutor;
 
 #if !defined(RCT_REMOVE_LEGACY_MODULE_INTEROP) || !defined(RCT_REMOVE_LEGACY_COMPONENT_INTEROP)
@@ -18,23 +17,9 @@ RCT_EXTERN void RCTRegisterModule(Class);
 
 @interface RCTBridge ()
 
-// Used for the profiler flow events between JS and native
-@property (nonatomic, assign) int64_t flowID;
-@property (nonatomic, assign) CFMutableDictionaryRef flowIDMap;
-@property (nonatomic, strong) NSLock *flowIDMapLock;
-
-// Used by RCTDevMenu
-@property (nonatomic, copy) NSString *bridgeDescription;
-
 + (instancetype)currentBridge;
 + (void)setCurrentBridge:(RCTBridge *)bridge;
 
-/**
- * Bridge setup code - creates an instance of RCTBachedBridge. Exposed for
- * test only
- */
-- (void)setUp;
-
 /**
  * This method is used to invoke a callback that was registered in the
  * JavaScript application context. Safe to call from any thread.
@@ -48,17 +33,6 @@ RCT_EXTERN void RCTRegisterModule(Class);
  */
 @property (atomic, strong) RCTBridge *batchedBridge;
 
-/**
- * The block that creates the modules' instances to be added to the bridge.
- * Exposed for RCTCxxBridge
- */
-@property (nonatomic, copy, readonly) RCTBridgeModuleListProvider moduleProvider;
-
-/**
- * Used by RCTDevMenu to override the `hot` param of the current bundleURL.
- */
-@property (nonatomic, strong, readwrite) NSURL *bundleURL;
-
 /**
  * An object that allows one to require NativeModules/TurboModules.
  * RCTModuleRegistry is implemented in bridgeless mode and bridge mode.
@@ -70,17 +44,6 @@ RCT_EXTERN void RCTRegisterModule(Class);
 
 @interface RCTBridge (RCTCxxBridge)
 
-/**
- * Used by RCTModuleData
- */
-
-@property (nonatomic, weak, readonly) RCTBridge *parentBridge;
-
-/**
- * Used by RCTModuleData
- */
-@property (nonatomic, assign, readonly) BOOL moduleSetupComplete;
-
 /**
  * Called on the child bridge to run the executor and start loading.
  */
@@ -92,41 +55,9 @@ RCT_EXTERN void RCTRegisterModule(Class);
  */
 - (void)dispatchBlock:(dispatch_block_t)block queue:(dispatch_queue_t)queue;
 
-/**
- * Get the module data for a given module name. Used by UIManager to implement
- * the `dispatchViewManagerCommand` method.
- */
-- (RCTModuleData *)moduleDataForName:(NSString *)moduleName;
-
 /**
  * Registers additional classes with the ModuleRegistry.
  */
 - (void)registerAdditionalModuleClasses:(NSArray<Class> *)newModules;
 
-/**
- * Updates the ModuleRegistry with a pre-initialized instance.
- */
-- (void)updateModuleWithInstance:(id<RCTBridgeModule>)instance;
-
-/**
- * Systrace profiler toggling methods exposed for the RCTDevMenu
- */
-- (void)startProfiling;
-- (void)stopProfiling:(void (^)(NSData *))callback;
-
-/**
- * Synchronously call a specific native module's method and return the result
- */
-- (id)callNativeModule:(NSUInteger)moduleID method:(NSUInteger)methodID params:(NSArray *)params;
-
-/**
- * Hook exposed for RCTLog to send logs to JavaScript when not running in JSC
- */
-- (void)logMessage:(NSString *)message level:(NSString *)level;
-
-/**
- * Allow super fast, one time, timers to skip the queue and be directly executed
- */
-- (void)_immediatelyCallTimer:(NSNumber *)timer;
-
 @end

packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.h

@@ -200,16 +200,3 @@ class JSI_EXPORT ObjCTurboModule : public TurboModule {
 @optional
 - (void)setEventEmitterCallback:(EventEmitterCallbackWrapper *)eventEmitterCallbackWrapper;
 @end
-
-/**
- * These methods are all implemented by RCTCxxBridge, which subclasses RCTBridge. Hence, they must only be used in
- * contexts where the concrete class of an RCTBridge instance is RCTCxxBridge. This happens, for example, when
- * [RCTCxxBridgeDelegate jsExecutorFactoryForBridge:(RCTBridge *)] is invoked by RCTCxxBridge.
- *
- * TODO: Consolidate this extension with the one in RCTSurfacePresenter.
- */
-@interface RCTBridge (RCTTurboModule)
-- (std::shared_ptr<facebook::react::CallInvoker>)jsCallInvoker;
-- (std::shared_ptr<facebook::react::NativeMethodCallInvoker>)decorateNativeMethodCallInvoker:
-    (std::shared_ptr<facebook::react::NativeMethodCallInvoker>)nativeMethodCallInvoker;
-@end

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

@@ -43,11 +43,6 @@ category RCTBridge(RCTSurfacePresenterStub) {
   public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
 }
 
-category RCTBridge(RCTTurboModule) {
-  public virtual std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker();
-  public virtual std::shared_ptr<facebook::react::NativeMethodCallInvoker> decorateNativeMethodCallInvoker:(std::shared_ptr<facebook::react::NativeMethodCallInvoker> nativeMethodCallInvoker);
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api

@@ -43,11 +43,6 @@ category RCTBridge(RCTSurfacePresenterStub) {
   public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
 }
 
-category RCTBridge(RCTTurboModule) {
-  public virtual std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker();
-  public virtual std::shared_ptr<facebook::react::NativeMethodCallInvoker> decorateNativeMethodCallInvoker:(std::shared_ptr<facebook::react::NativeMethodCallInvoker> nativeMethodCallInvoker);
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api

@@ -43,11 +43,6 @@ category RCTBridge(RCTSurfacePresenterStub) {
   public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
 }
 
-category RCTBridge(RCTTurboModule) {
-  public virtual std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker();
-  public virtual std::shared_ptr<facebook::react::NativeMethodCallInvoker> decorateNativeMethodCallInvoker:(std::shared_ptr<facebook::react::NativeMethodCallInvoker> nativeMethodCallInvoker);
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

@@ -43,11 +43,6 @@ category RCTBridge(RCTSurfacePresenterStub) {
   public virtual void setSurfacePresenter:(id<RCTSurfacePresenterStub> presenter);
 }
 
-category RCTBridge(RCTTurboModule) {
-  public virtual std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker();
-  public virtual std::shared_ptr<facebook::react::NativeMethodCallInvoker> decorateNativeMethodCallInvoker:(std::shared_ptr<facebook::react::NativeMethodCallInvoker> nativeMethodCallInvoker);
-}
-
 category RCTBridge(RCTUIManager) {
   public @property (assign, readonly) RCTUIManager* uiManager;
 }