diff --git a/extension/pytree/aten_util/BUCK b/extension/pytree/aten_util/BUCK index 1e8cc179228..d28062b81f4 100644 --- a/extension/pytree/aten_util/BUCK +++ b/extension/pytree/aten_util/BUCK @@ -1,8 +1,18 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/pytree/aten_util/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/pytree/aten_util/TARGETS b/extension/pytree/aten_util/TARGETS deleted file mode 100644 index 77b38349334..00000000000 --- a/extension/pytree/aten_util/TARGETS +++ /dev/null @@ -1,7 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/pytree/aten_util/test/BUCK b/extension/pytree/aten_util/test/BUCK index 1e8cc179228..08f7bd2032c 100644 --- a/extension/pytree/aten_util/test/BUCK +++ b/extension/pytree/aten_util/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/pytree/aten_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/pytree/aten_util/test/TARGETS b/extension/pytree/aten_util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/pytree/aten_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/pytree/test/TARGETS b/extension/pytree/test/BUCK similarity index 74% rename from extension/pytree/test/TARGETS rename to extension/pytree/test/BUCK index e49e8cd2791..55ab7ed551c 100644 --- a/extension/pytree/test/TARGETS +++ b/extension/pytree/test/BUCK @@ -1,16 +1,17 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") # @noautodeps load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest") load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest") oncall("executorch") -cpp_unittest( +fbcode_target(_kind = cpp_unittest, name = "pytree_test", srcs = ["test_pytree.cpp"], deps = ["//executorch/extension/pytree:pytree"], ) -python_unittest( +fbcode_target(_kind = python_unittest, name = "pybindings_test", srcs = [ "test.py", diff --git a/extension/runner_util/BUCK b/extension/runner_util/BUCK index 1e8cc179228..58e9c2ef6f3 100644 --- a/extension/runner_util/BUCK +++ b/extension/runner_util/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain xplat-only targets. + +load(":targets.bzl", "define_common_targets") + + +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/runner_util/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +fbcode_target(_kind = define_common_targets,) diff --git a/extension/runner_util/TARGETS b/extension/runner_util/TARGETS deleted file mode 100644 index 1e8cc179228..00000000000 --- a/extension/runner_util/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/runner_util/test/BUCK b/extension/runner_util/test/BUCK index 1e8cc179228..219d6a502f3 100644 --- a/extension/runner_util/test/BUCK +++ b/extension/runner_util/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain xplat-only targets. + +load(":targets.bzl", "define_common_targets") + + +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/runner_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +fbcode_target(_kind = define_common_targets,is_fbcode = True) diff --git a/extension/runner_util/test/TARGETS b/extension/runner_util/test/TARGETS deleted file mode 100644 index 7ace4add7f9..00000000000 --- a/extension/runner_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain xplat-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/extension/tensor/BUCK b/extension/tensor/BUCK index 1e8cc179228..a0c91eefda8 100644 --- a/extension/tensor/BUCK +++ b/extension/tensor/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/tensor/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/tensor/TARGETS b/extension/tensor/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/tensor/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/tensor/test/BUCK b/extension/tensor/test/BUCK index 1e8cc179228..da1efcede85 100644 --- a/extension/tensor/test/BUCK +++ b/extension/tensor/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/tensor/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/tensor/test/TARGETS b/extension/tensor/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/tensor/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/testing_util/BUCK b/extension/testing_util/BUCK index 1e8cc179228..8b52d231912 100644 --- a/extension/testing_util/BUCK +++ b/extension/testing_util/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/testing_util/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/testing_util/test/BUCK b/extension/testing_util/test/BUCK index 1e8cc179228..291eab6ae0f 100644 --- a/extension/testing_util/test/BUCK +++ b/extension/testing_util/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/testing_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/testing_util/test/TARGETS b/extension/testing_util/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/testing_util/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/threadpool/BUCK b/extension/threadpool/BUCK index 1e8cc179228..bbbe8a7d8c4 100644 --- a/extension/threadpool/BUCK +++ b/extension/threadpool/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/threadpool/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/threadpool/TARGETS b/extension/threadpool/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/threadpool/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/threadpool/test/BUCK b/extension/threadpool/test/BUCK index 1e8cc179228..f80c5a3fa8e 100644 --- a/extension/threadpool/test/BUCK +++ b/extension/threadpool/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/threadpool/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/threadpool/test/TARGETS b/extension/threadpool/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/threadpool/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/training/BUCK b/extension/training/BUCK index 1e8cc179228..f343cd542b9 100644 --- a/extension/training/BUCK +++ b/extension/training/BUCK @@ -1,8 +1,31 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) + +fbcode_target(_kind = runtime.python_library, + name = "lib", + srcs = [ + "__init__.py", + ], + deps = [ + "//executorch/extension/training/pybindings:_training_lib", + "//executorch/extension/training/pybindings:_training_module", + ], +) diff --git a/extension/training/TARGETS b/extension/training/TARGETS deleted file mode 100644 index eeed302c339..00000000000 --- a/extension/training/TARGETS +++ /dev/null @@ -1,20 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() - -runtime.python_library( - name = "lib", - srcs = [ - "__init__.py", - ], - deps = [ - "//executorch/extension/training/pybindings:_training_lib", - "//executorch/extension/training/pybindings:_training_module", - ], -) diff --git a/extension/testing_util/TARGETS b/extension/training/examples/CIFAR/BUCK similarity index 59% rename from extension/testing_util/TARGETS rename to extension/training/examples/CIFAR/BUCK index 2341af9282f..f488cf7ec94 100644 --- a/extension/testing_util/TARGETS +++ b/extension/training/examples/CIFAR/BUCK @@ -1,3 +1,4 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain fbcode-only targets. @@ -5,4 +6,4 @@ load(":targets.bzl", "define_common_targets") oncall("executorch") -define_common_targets() +fbcode_target(_kind = define_common_targets,) diff --git a/extension/training/examples/CIFAR/TARGETS b/extension/training/examples/CIFAR/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/training/examples/CIFAR/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/training/examples/XOR/BUCK b/extension/training/examples/XOR/BUCK index 1e8cc179228..37a13bf4aff 100644 --- a/extension/training/examples/XOR/BUCK +++ b/extension/training/examples/XOR/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/examples/XOR/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/training/examples/XOR/TARGETS b/extension/training/examples/XOR/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/training/examples/XOR/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/training/examples/XOR/test/TARGETS b/extension/training/examples/XOR/test/BUCK similarity index 75% rename from extension/training/examples/XOR/test/TARGETS rename to extension/training/examples/XOR/test/BUCK index 5c74b50efd8..f8107f8a145 100644 --- a/extension/training/examples/XOR/test/TARGETS +++ b/extension/training/examples/XOR/test/BUCK @@ -1,8 +1,9 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") oncall("executorch") -runtime.python_test( +fbcode_target(_kind = runtime.python_test, name = "test", srcs = ["test_export.py"], visibility = ["//executorch/extension/training/examples/XOR/test/..."], diff --git a/extension/training/module/BUCK b/extension/training/module/BUCK index 1e8cc179228..f0a48ab2f2d 100644 --- a/extension/training/module/BUCK +++ b/extension/training/module/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/module/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/training/module/TARGETS b/extension/training/module/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/training/module/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/training/module/test/BUCK b/extension/training/module/test/BUCK index 1e8cc179228..494f86c619c 100644 --- a/extension/training/module/test/BUCK +++ b/extension/training/module/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/module/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,is_fbcode = True) diff --git a/extension/training/module/test/TARGETS b/extension/training/module/test/TARGETS deleted file mode 100644 index a6c52d105f6..00000000000 --- a/extension/training/module/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/extension/training/optimizer/BUCK b/extension/training/optimizer/BUCK index 1e8cc179228..21b4f993cb7 100644 --- a/extension/training/optimizer/BUCK +++ b/extension/training/optimizer/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/optimizer/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/training/optimizer/TARGETS b/extension/training/optimizer/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/training/optimizer/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/training/optimizer/test/BUCK b/extension/training/optimizer/test/BUCK index 1e8cc179228..b580fa41061 100644 --- a/extension/training/optimizer/test/BUCK +++ b/extension/training/optimizer/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/optimizer/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/extension/training/optimizer/test/TARGETS b/extension/training/optimizer/test/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/extension/training/optimizer/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() diff --git a/extension/training/pybindings/BUCK b/extension/training/pybindings/BUCK index 1e8cc179228..0c0b7a26202 100644 --- a/extension/training/pybindings/BUCK +++ b/extension/training/pybindings/BUCK @@ -1,8 +1,49 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/pybindings/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) + +fbcode_target(_kind = runtime.cxx_python_extension, + name = "_training_lib", + srcs = [ + "_training_lib.cpp", + ], + base_module = "executorch.extension.training.pybindings", + types = ["_training_lib.pyi"], + visibility = ["//executorch/extension/training/..."], + deps = [ + "fbsource//third-party/pybind11:pybind11", + "//executorch/extension/aten_util:aten_bridge", + "//executorch/extension/training/optimizer:sgd", + ], + external_deps = ["libtorch_python"], +) + +fbcode_target(_kind = runtime.python_library, + name = "_training_module", + srcs = [ + "_training_module.py", + ], + base_module = "executorch.extension.training.pybindings", + visibility = ["//executorch/extension/training/..."], + deps = [ + "//caffe2:torch", + "//executorch/extension/pybindings:portable_lib", + ], +) diff --git a/extension/training/pybindings/TARGETS b/extension/training/pybindings/TARGETS deleted file mode 100644 index 19b54961493..00000000000 --- a/extension/training/pybindings/TARGETS +++ /dev/null @@ -1,38 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets() - -runtime.cxx_python_extension( - name = "_training_lib", - srcs = [ - "_training_lib.cpp", - ], - base_module = "executorch.extension.training.pybindings", - types = ["_training_lib.pyi"], - visibility = ["//executorch/extension/training/..."], - deps = [ - "fbsource//third-party/pybind11:pybind11", - "//executorch/extension/aten_util:aten_bridge", - "//executorch/extension/training/optimizer:sgd", - ], - external_deps = ["libtorch_python"], -) - -runtime.python_library( - name = "_training_module", - srcs = [ - "_training_module.py", - ], - base_module = "executorch.extension.training.pybindings", - visibility = ["//executorch/extension/training/..."], - deps = [ - "//caffe2:torch", - "//executorch/extension/pybindings:portable_lib", - ], -) diff --git a/extension/training/pybindings/test/TARGETS b/extension/training/pybindings/test/BUCK similarity index 70% rename from extension/training/pybindings/test/TARGETS rename to extension/training/pybindings/test/BUCK index 34a324dc50e..746c222ce85 100644 --- a/extension/training/pybindings/test/TARGETS +++ b/extension/training/pybindings/test/BUCK @@ -1,8 +1,9 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") oncall("executorch") -runtime.python_test( +fbcode_target(_kind = runtime.python_test, name = "test", srcs = ["test.py"], visibility = ["//executorch/extension/training/pybindings/test/..."], diff --git a/extension/training/test/BUCK b/extension/training/test/BUCK index 1e8cc179228..ba8c6b08fa0 100644 --- a/extension/training/test/BUCK +++ b/extension/training/test/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/extension/training/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,is_fbcode = True) diff --git a/extension/training/test/TARGETS b/extension/training/test/TARGETS deleted file mode 100644 index a6c52d105f6..00000000000 --- a/extension/training/test/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets(is_fbcode = True) diff --git a/extension/wasm/test/BUCK b/extension/wasm/test/BUCK index d7a8959984b..d5c29e0e24a 100644 --- a/extension/wasm/test/BUCK +++ b/extension/wasm/test/BUCK @@ -1,9 +1,10 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") load("@fbsource//tools/build_defs:fb_xplat_cxx_binary.bzl", "fb_xplat_cxx_binary") oncall("executorch") -runtime.genrule( +non_fbcode_target(_kind = runtime.genrule, name = "unittests_full", srcs = [ "unittests.js", @@ -13,7 +14,7 @@ runtime.genrule( cmd = "cat $SRCS > $OUT", ) -runtime.genrule( +non_fbcode_target(_kind = runtime.genrule, name = "unittests_full_etdump", srcs = [ "unittests.js", @@ -23,7 +24,7 @@ runtime.genrule( cmd = "cat $SRCS > $OUT", ) -fb_xplat_cxx_binary( +non_fbcode_target(_kind = fb_xplat_cxx_binary, name = "wasm.test.js", linker_flags = [ "-lembind", @@ -45,7 +46,7 @@ fb_xplat_cxx_binary( ], ) -fb_xplat_cxx_binary( +non_fbcode_target(_kind = fb_xplat_cxx_binary, name = "wasm_etdump.test.js", linker_flags = [ "-lembind", @@ -66,3 +67,49 @@ fb_xplat_cxx_binary( ":unittests_full_etdump", ], ) + +# !!!! fbcode/executorch/extension/wasm/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") + + +export_genrule_cmd = [ + "$(exe //executorch/examples/portable/scripts:export)", + "--model_name={model_name}", + "--output_dir=$OUT", +] + +fbcode_target(_kind = runtime.python_binary, + name = "test_model", + srcs = [ + "test_model.py", + ], + main_module = "executorch.extension.wasm.test.test_model", + deps = [ + "//executorch/extension/export_util:export_util", + ], +) + +test_pte_genrule_cmd = [ + "$(exe :test_model)", + "$OUT/test.pte", +] + +models_genrule_cmd = [ + "mkdir -p $OUT &&", + " ".join(export_genrule_cmd).format(model_name="add_mul"), + "&&", + " ".join(export_genrule_cmd).format(model_name="add"), + "&&", + " ".join(test_pte_genrule_cmd), +] + +fbcode_target(_kind = runtime.genrule, + name = "models", + outs = { + "add.pte": ["add.pte"], + "add_mul.pte": ["add_mul.pte"], + "test.pte": ["test.pte"], + }, + cmd = " ".join(models_genrule_cmd), +) diff --git a/extension/wasm/test/TARGETS b/extension/wasm/test/TARGETS deleted file mode 100644 index b85312a4c87..00000000000 --- a/extension/wasm/test/TARGETS +++ /dev/null @@ -1,44 +0,0 @@ -load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") - -oncall("executorch") - -export_genrule_cmd = [ - "$(exe //executorch/examples/portable/scripts:export)", - "--model_name={model_name}", - "--output_dir=$OUT", -] - -runtime.python_binary( - name = "test_model", - srcs = [ - "test_model.py", - ], - main_module = "executorch.extension.wasm.test.test_model", - deps = [ - "//executorch/extension/export_util:export_util", - ], -) - -test_pte_genrule_cmd = [ - "$(exe :test_model)", - "$OUT/test.pte", -] - -models_genrule_cmd = [ - "mkdir -p $OUT &&", - " ".join(export_genrule_cmd).format(model_name="add_mul"), - "&&", - " ".join(export_genrule_cmd).format(model_name="add"), - "&&", - " ".join(test_pte_genrule_cmd), -] - -runtime.genrule( - name = "models", - outs = { - "add.pte": ["add.pte"], - "add_mul.pte": ["add_mul.pte"], - "test.pte": ["test.pte"], - }, - cmd = " ".join(models_genrule_cmd), -) diff --git a/kernels/aten/BUCK b/kernels/aten/BUCK index 1e8cc179228..c89edb78b18 100644 --- a/kernels/aten/BUCK +++ b/kernels/aten/BUCK @@ -1,8 +1,19 @@ +load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target") +oncall("executorch") # Any targets that should be shared between fbcode and xplat must be defined in # targets.bzl. This file can contain xplat-only targets. load(":targets.bzl", "define_common_targets") -oncall("executorch") -define_common_targets() +non_fbcode_target(_kind = define_common_targets,) + +# !!!! fbcode/executorch/kernels/aten/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! + +# Any targets that should be shared between fbcode and xplat must be defined in +# targets.bzl. This file can contain fbcode-only targets. + +load(":targets.bzl", "define_common_targets") + + +fbcode_target(_kind = define_common_targets,) diff --git a/kernels/aten/TARGETS b/kernels/aten/TARGETS deleted file mode 100644 index 2341af9282f..00000000000 --- a/kernels/aten/TARGETS +++ /dev/null @@ -1,8 +0,0 @@ -# Any targets that should be shared between fbcode and xplat must be defined in -# targets.bzl. This file can contain fbcode-only targets. - -load(":targets.bzl", "define_common_targets") - -oncall("executorch") - -define_common_targets()