You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR replaces the error page's looping background video with a static image and adds localized error messaging with a GitHub issue report link.
Minor issues:
statusCode prop unused: The statusCode prop is still declared on ErrorPage but no longer used in the JSX after removing the 'Ops {statusCode}' heading. It should either be removed from the component or displayed somewhere meaningful (e.g., shown to users for easier bug reporting).
Inline styles: The img element uses inline styles (maxWidth, marginTop) while the rest of the codebase uses Tailwind CSS. This is inconsistent with project conventions.
Hardcoded GitHub URL: The issues URL https://github.com/pythonitalia/pycon/issues is hardcoded in the component. If this URL ever changes, it needs to be updated in code rather than config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
update-error-page) <-- this PR