Skip to content

Comments

[reportlab] Add more annotations for pdfbase#15431

Merged
srittau merged 2 commits intopython:mainfrom
donbarbos:reportlab-pdfbase
Feb 20, 2026
Merged

[reportlab] Add more annotations for pdfbase#15431
srittau merged 2 commits intopython:mainfrom
donbarbos:reportlab-pdfbase

Conversation

@donbarbos
Copy link
Contributor

No description provided.

@github-actions

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Feb 20, 2026

You've used LiteralString as return type for various functions. I think we should be more conservative and just use str. While the strings are constructed according to specific rules, LiteralStrings should only be used for strings provided by the user or directly constructed from other LiteralStrings.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 789bc53 into python:main Feb 20, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants