From b3e8b3371d93451b0186cd28506e3c8b96186c37 Mon Sep 17 00:00:00 2001
From: Sergey B Kirpichev <skirpichev@gmail.com>
Date: Thu, 3 Sep 2026 04:32:16 +0300
Subject: [PATCH] gh-156867: struct.pack() check for overflows for Zf type

---
 Lib/test/test_struct.py                                | 10 ++++++++++
 .../2026-09-03-04-32-06.gh-issue-156867.hq3efC.rst     |  3 +++
 Modules/_struct.c                                      | 10 +++++++---
 3 files changed, 20 insertions(+), 3 deletions(-)
 create mode 100644 Misc/NEWS.d/next/Library/2026-09-03-04-32-06.gh-issue-156867.hq3efC.rst

diff --git a/Lib/test/test_struct.py b/Lib/test/test_struct.py
index 3809f2d26438955..530bd8f65d74613 100644
--- a/Lib/test/test_struct.py
+++ b/Lib/test/test_struct.py
@@ -424,6 +424,16 @@ def test_705836(self):
         self.assertRaises(OverflowError, struct.pack, "<e", big)
         self.assertRaises(OverflowError, struct.pack, "e", big)
 
+    def test_156867(self):
+        big_real = 1e300
+        self.assertRaises(OverflowError, struct.pack, ">Zf", big_real)
+        self.assertRaises(OverflowError, struct.pack, "<Zf", big_real)
+        self.assertRaises(OverflowError, struct.pack, "Zf", big_real)
+        big_imag = 1e300j
+        self.assertRaises(OverflowError, struct.pack, ">Zf", big_imag)
+        self.assertRaises(OverflowError, struct.pack, "<Zf", big_imag)
+        self.assertRaises(OverflowError, struct.pack, "Zf", big_imag)
+
     def test_1530559(self):
         for code, byteorder in iter_integer_formats():
             format = byteorder + code
diff --git a/Misc/NEWS.d/next/Library/2026-09-03-04-32-06.gh-issue-156867.hq3efC.rst b/Misc/NEWS.d/next/Library/2026-09-03-04-32-06.gh-issue-156867.hq3efC.rst
new file mode 100644
index 000000000000000..2e5ea55f86cc2f4
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2026-09-03-04-32-06.gh-issue-156867.hq3efC.rst
@@ -0,0 +1,3 @@
+Raise :exc:`OverflowError`'s for native ``'Zf'`` format in :func:`struct.pack`,
+like for ``'f'`` format.  Previously overflows in the :c:expr:`float complex`
+type were silent.  Patch by Sergey B Kirpichev.
diff --git a/Modules/_struct.c b/Modules/_struct.c
index 352312fb0b4c19b..c099a2ad314ed0e 100644
--- a/Modules/_struct.c
+++ b/Modules/_struct.c
@@ -790,15 +790,19 @@ np_float_complex(_structmodulestate *state, char *p, PyObject *v,
                  const formatdef *f)
 {
     Py_complex c = PyComplex_AsCComplex(v);
-    float x[2] = {(float)c.real, (float)c.imag};
 
     if (c.real == -1 && PyErr_Occurred()) {
         PyErr_SetString(state->StructError,
                         "required argument is not a complex");
         return -1;
     }
-    memcpy(p, &x, sizeof(x));
-    return 0;
+
+    int ret = PyFloat_Pack4(c.real, p, PY_LITTLE_ENDIAN);
+
+    if (ret) {
+        return ret;
+    }
+    return PyFloat_Pack4(c.imag, p + sizeof(float), PY_LITTLE_ENDIAN);
 }
 
 static int