Forward-port test_xpickle from 2.7 to 3.x

[zware]

BPO	31391
Nosy	@zware, @ammaraskar, @Fidget-Spinner
PRs	gh-75572: Forward-port test_xpickle from Python 2 to 3.  #22452

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-09-08.02:43:10.865>
labels = ['easy', 'type-feature', 'tests', '3.9']
title = 'Forward-port test_xpickle from 2.7 to 3.x'
updated_at = <Date 2020-09-29.15:47:15.792>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2020-09-29.15:47:15.792>
actor = 'kj'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2017-09-08.02:43:10.865>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 31391
keywords = ['patch', 'newcomer friendly']
message_count = 1.0
messages = ['301671']
nosy_count = 3.0
nosy_names = ['zach.ware', 'ammar2', 'kj']
pr_nums = ['22452']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31391'
versions = ['Python 3.9']

Linked PRs

• [3.14] gh-75572: Forward-port test_xpickle from Python 2 to 3 (GH-22452) #143485
• gh-75572: Fix test_xpickle and disable it by default #143503
• [3.14] gh-75572: Fix test_xpickle and disable it by default (GH-143503) #143505
• [3.13] gh-75572: Forward-port test_xpickle from Python 2 to 3 (GH-22452) #143509

[zware]

Python 2.x has a test called test_xpickle which confirms that pickles can be successfully passed back and forth between different versions of Python. This should be forward-ported to 3.x, and include tests between the python under test, 3.6, 3.5, 3.4, and 2.7, for each protocol available to each version. If feeling adventurous, you could even go as far back as 3.0 :)

Ideally, this should also run on Windows by making use of the py launcher, and possibly even include 32- and 64-bit versions of each Python on Windows.

[rtindru]

@zware I am a first-time contributor, and I am currently at Pycon US in the dev sprints looking to start with an easy task :)

Could I take a shot at fixing this issue? I found the test_xpickle.py file on the 2.7 tagged branch. I plan to copy the same test into 3.9, unless you think it might be more valuable to port it to 3.11?

[zware]

Hi @rtindru. This would definitely need to be done against the main (3.11) branch and probably not backported.

It does look like @Fidget-Spinner already has a PR in progress for this issue, so your best contribution here may be to review that PR (GH-22452) rather than creating a new one.

[rtindru]

Ah great, sorry I missed seeing the PR in progress. I will go ahead and review the PR to the extent that I can, since I am quite new!

[rtindru]

@zware Are you at Pycon, I would love to come say hi :)

I'd love to find another similar easy task that is primarily in python (not C) and possibly involves forwardporting or testing so I have some example code to go off. Let me know if you know any issues any top of mind!

[Fidget-Spinner]

@zware I removed the easy label from this issue because I now feel it's a trap. I started on this as my first ever contribution to CPython, and now one and a half years later, I'm a core dev but I still have no confidence to merge the PR 😆 . IMO this issue doesn't deserve the easy label. It was deceptively hard.