Skip to content

Commit fcc553a

Browse files
encukouda-woodsStanFromIreland
authored
Apply suggestions from code review
Co-authored-by: da-woods <dw-git@d-woods.co.uk> Co-authored-by: Stan Ulbrych <stan@python.org>
1 parent 1448abd commit fcc553a

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

Doc/howto/abi3t-migration.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ This should result in a different error than "``abt3t`` define is not set".
203203
resulting extension manually as well.
204204
This is covered in :ref:`abi3t-migration-tagging` below.
205205

206-
This guide will ask you to do a series of changes.
206+
This guide will ask you to make a series of changes.
207207
After each one, verify that your extension still builds in the original
208208
(non-``abi3t``) configuration, and ideally run tests on all Python
209209
versions you support.
@@ -216,7 +216,7 @@ Module export hook
216216
Unless you've done this step already, your extension module defines a
217217
:ref:`module initialization function <extension-pyinit>`
218218
named :samp:`PyInit_{<module_name>}`.
219-
You will need to port it to :ref:`module export hook <extension-export-hook>`,
219+
You will need to port it to a :ref:`module export hook <extension-export-hook>`,
220220
:samp:`PyModExport_{<module name>}`, a feature added in CPython 3.15 in
221221
:pep:`793`.
222222

@@ -234,7 +234,7 @@ for ``<modname>`` and ``<moddef>``):
234234
235235
If there is some code before the ``return``, move it to
236236
a :c:macro:`Py_mod_create` or :c:macro:`Py_mod_exec` slot function.
237-
See :ref:`PyInit documentation <extension-pyinit>` for related information.
237+
See the :ref:`PyInit documentation <extension-pyinit>` for related information.
238238

239239
The function references a ``PyModuleDef`` object (``<moddef>`` in the code
240240
above).
@@ -287,7 +287,7 @@ and replace them with the following:
287287
Leave out any fields that were missing (excexpt the new :c:macro:`Py_mod_abi`),
288288
and substitute your own values.
289289

290-
See :c:type:`PySlot` and :c:ref:`export hook <extension-export-hook>`
290+
See the :c:type:`PySlot` and :c:ref:`export hook <extension-export-hook>`
291291
documentation for details on this API.
292292

293293
Associated ``PyModuleDef``
@@ -301,7 +301,7 @@ This changes the behavior of the following functions:
301301
- :c:func:`PyType_GetModuleByDef`
302302

303303
Check your code for these.
304-
If you do not use them, you skip the rest of this section.
304+
If you do not use them, you can skip this section.
305305

306306
These functions are typically used for two purposes:
307307

@@ -349,7 +349,7 @@ These functions are typically used for two purposes:
349349
350350
void *token;
351351
if (PyModule_GetToken(module, &token) < 0) {
352-
/* handle error */
352+
/* handle error */
353353
}
354354
355355
and from :c:func:`PyType_GetModuleByDef` calls such as:
@@ -603,7 +603,7 @@ Testing
603603
=======
604604

605605
Note that when you build an extension compatible with multiple versions of
606-
CPython, you should always *test* it witch each version it supports (for
606+
CPython, you should always *test* it with each version it supports (for
607607
example, 3.15, 3.16, and so on).
608608
Stable ABI only guarantees *ABI* compatibility; there may also be behavior
609609
changes -- both intentional ones (covered by :pep:`387`) and bugs.

0 commit comments

Comments
 (0)