Skip to content

Commit d04b81a

Browse files
committed
Drive the python3 DLL entry point from EnableASAN only
1 parent 0fd9307 commit d04b81a

3 files changed

Lines changed: 2 additions & 10 deletions

File tree

‎PCbuild/pyproject.props‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,6 @@
2525
<SupportSigning Condition="'$(Configuration)' == 'Debug'">false</SupportSigning>
2626
<SupportSigning Condition="'$(ConfigurationType)' == 'StaticLibrary'">false</SupportSigning>
2727
<LinkIncremental Condition="$(Configuration) != 'Debug'">false</LinkIncremental>
28-
29-
<!--
30-
AddressSanitizer may be enabled with the EnableASAN property or through the
31-
_CL_ and _LINK_ environment variables, so check all of them.
32-
-->
33-
<PyUsingAsan Condition="'$(PyUsingAsan)' == '' and '$(EnableASAN)' == 'true'">true</PyUsingAsan>
34-
<PyUsingAsan Condition="'$(PyUsingAsan)' == '' and $(_CL_.ToLowerInvariant().Contains('fsanitize=address'))">true</PyUsingAsan>
35-
<PyUsingAsan Condition="'$(PyUsingAsan)' == '' and $(_LINK_.ToLowerInvariant().Contains('inferasanlibs'))">true</PyUsingAsan>
3628
</PropertyGroup>
3729

3830
<PropertyGroup Condition="$(TargetExt) != ''">

‎PCbuild/python3dll.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
The ASan runtime thunks need the CRT to be initialized, so keep the
100100
default entry point when building with AddressSanitizer.
101101
-->
102-
<NoEntryPoint Condition="$(PyUsingAsan) != 'true'">true</NoEntryPoint>
102+
<NoEntryPoint Condition="$(EnableASAN) != 'true'">true</NoEntryPoint>
103103
</Link>
104104
</ItemDefinitionGroup>
105105
<ItemGroup>

‎PCbuild/python3tdll.vcxproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
The ASan runtime thunks need the CRT to be initialized, so keep the
100100
default entry point when building with AddressSanitizer.
101101
-->
102-
<NoEntryPoint Condition="$(PyUsingAsan) != 'true'">true</NoEntryPoint>
102+
<NoEntryPoint Condition="$(EnableASAN) != 'true'">true</NoEntryPoint>
103103
</Link>
104104
</ItemDefinitionGroup>
105105
<ItemGroup>

0 commit comments

Comments
 (0)