Commit 86edfef
committed
gh-153795: Stop urllib.robotparser.can_fetch crashing on a malformed URL
RobotFileParser.can_fetch() is documented to return a bool, but it passed the
url straight to urllib.parse._urlsplit(), so a malformed url such as an
unterminated IPv6 authority raised a bare ValueError out of can_fetch(). Treat
a url that cannot be parsed as matching no rule and return True, matching RFC
9309's default that access is not restricted when no rule applies.1 parent e51b616 commit 86edfef
3 files changed
Lines changed: 20 additions & 1 deletion
File tree
- Lib
- test
- urllib
- Misc/NEWS.d/next/Library
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
486 | 499 | | |
487 | 500 | | |
488 | 501 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
182 | 186 | | |
183 | 187 | | |
184 | 188 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
0 commit comments