Display the resource topic when using the `!resources` command

[n0Oo0Oo0b]

The !resources command accepts an optional argument to specify the resource topic in the URL. For example, !resources data science will result in the following link: https://www.pythondiscord.com/resources/?topics=data-science

However, there is no difference in the embed (other than the hyperlink itself) to indicate that a topic has been specified. I propose that when a topic is specified, it will be added to the title of the embed, like "Resources for: Data science".

(I would like to implement this myself)

[hedyhli]

Ideally, we would want to check for the command arguments against the list of valid filters (see the above linked issue - or python-discord/site#710). So once we have that endpoint on the site, we can then add in the "Resources for: " if the argument is a valid topic, and just the current normal "Resources" title otherwise.

[jchristgit]

The issue on site is fixed now, we have an endpoint for valid filters now.

[jb3]

Re-opening as #3552 was not a solution we could use in the end.

Users have started using the !resources command with free text afterwards (which does still generate a URL with a query parameter, but site just shows all resources for unknown topics).

If we want to do this we need to add validation somehow of the topics and only put them in the title if it's a known topic. This may require changes to site as well to make those topics available to the bot easily.

[Kaztral-ar]

Would it be okay if I update the PR to validate the topic against the available resource topics before adding it to the embed title?

[n0Oo0Oo0b]

If we want to do this we need to add validation somehow of the topics and only put them in the title if it's a known topic. This may require changes to site as well to make those topics available to the bot easily.

I believe the required changes have already been completed (see python-discord/site#1166), so it should be good to continue.

Would it be okay if I update the PR to validate the topic against the available resource topics before adding it to the embed title?

Yes, and it's probably better to return an error if the topic doesn't match.

[jb3]

I believe the required changes have already been completed (see python-discord/site#1166), so it should be good to continue.

Nice! Yes, seems so.

Would it be okay if I update the PR to validate the topic against the available resource topics before adding it to the embed title?

@janine9vn what are your thoughts here, as you say, people have been using this like a tag where you can do !tag some other message here, go look at this @user. If they are then maybe we should silently drop incorrect uses rather than erroring.

[Kaztral-ar]

I said that because when multiple messages come in at the same time, it can be hard to tell who the message is from. For example, if 10 or 11 members do it at once, it helps make it clear who the reply is for.

[n0Oo0Oo0b]

@janine9vn what are your thoughts here, as you say, people have been using this like a tag where you can do !tag some other message here, go look at this @user. If they are then maybe we should silently drop incorrect uses rather than erroring.

Ah, good point. I forgot it can be used like that as well. I personally don't really like that usecase but if that's how people use it then we could leave that behavior as-is.