Remove unused async_refresh_prompt and need_prompt_refresh methods

Author: tleonhardt

CHANGELOG.md

@@ -23,8 +23,10 @@ shell, and the option for a persistent bottom bar that can display realtime stat
       utilities
     - Async specific: `prompt-toolkit` starts its own `asyncio` event loop in every `cmd2`
       application
-    - Removed `cmd2.Cmd.terminal_lock` as it is no longer required to support things like
-      `cmd2.Cmd.async_alert`
+        - Removed `cmd2.Cmd.terminal_lock` as it is no longer required to support things like
+          `cmd2.Cmd.async_alert`
+        - Removed `cmd2.Cmd.async_refresh_prompt` and `cmd2.Cmd.need_prompt_refresh` as they are no
+          longer needed
 - Enhancements
     - New optional persistent **bottom toolbar** capable of displaying realtime status information,
       see the `bottom_toolbar` optional argument to the initializer for `cmd2.Cmd` and the

cmd2/cmd2.py

@@ -5523,29 +5523,6 @@ def async_update_prompt(self, new_prompt: str) -> None:  # pragma: no cover
         """
         self.async_alert('', new_prompt)
 
-    def async_refresh_prompt(self) -> None:  # pragma: no cover
-        """Refresh the oncreen prompt to match self.prompt.
-
-        One case where the onscreen prompt and self.prompt can get out of sync is
-        when async_alert() is called while a user is in search mode (e.g. Ctrl-r).
-        To prevent overwriting prompt-toolkit's onscreen search prompt, self.prompt is updated
-        but prompt-toolkit's saved prompt isn't.
-
-        Therefore when a user aborts a search, the old prompt is still on screen until they
-        press Enter or this method is called. Call need_prompt_refresh() in an async print
-        thread to know when a refresh is needed.
-
-        :raises RuntimeError: if called from the main thread.
-        :raises RuntimeError: if main thread is not currently at the prompt.
-        """
-        self.async_alert('')
-
-    def need_prompt_refresh(self) -> bool:  # pragma: no cover
-        """Check whether the onscreen prompt needs to be asynchronously refreshed to match self.prompt."""
-        # With prompt_toolkit, refresh is handled via invalidation.
-        # This method is kept for API compatibility.
-        return False
-
     @staticmethod
     def set_window_title(title: str) -> None:  # pragma: no cover
         """Set the terminal window title.

docs/features/prompt.md

@@ -36,8 +36,6 @@ and greater all support these.
 
 - [cmd2.Cmd.async_alert][]
 - [cmd2.Cmd.async_update_prompt][]
-- [cmd2.Cmd.async_refresh_prompt][]
-- [cmd2.Cmd.need_prompt_refresh][]
 
 `cmd2` also provides a function to change the title of the terminal window. This feature requires
 the application be running in a terminal that supports VT100 control characters. Linux, Mac, and

examples/async_printing.py

@@ -189,9 +189,6 @@ async def _alerter(self) -> None:
                     self.prompt = new_prompt
                     self.session.app.invalidate()
 
-                elif self.need_prompt_refresh():
-                    self.session.app.invalidate()
-
                 await asyncio.sleep(0.5)
         except asyncio.CancelledError:
             pass