From 2f3218fe1dea79762e24df2c0c3451d25a61bb34 Mon Sep 17 00:00:00 2001 From: Claire Peng Date: Sat, 18 Jul 2026 18:11:10 +0100 Subject: [PATCH 1/2] add environment: e2e-tests, gate e2e test runs on required_reviewer approval. remove temporary comment trigger --- .github/workflows/e2e.yml | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index d3603cbbf9..bc44129617 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -3,44 +3,22 @@ on: workflow_dispatch: pull_request: branches: [develop] - issue_comment: - types: [created] jobs: test-e2e: - # temporary while new e2e environment is not yet created: - # only trigger on workflow_dispatch, maintainer comment, or if PR is from GSOC project mentor or mentee + environment: e2e-tests + # only trigger on workflow_dispatch, or if PR is from GSOC project mentor or mentee if: > github.event_name == 'workflow_dispatch' || ( github.event_name == 'pull_request' && contains(fromJSON('["Geethegreat", "clairep94"]'), github.event.pull_request.user.login) - ) || - ( - github.event.issue.pull_request && - github.event.comment.body == '/e2e' && - contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association) ) timeout-minutes: 60 runs-on: ubuntu-latest steps: - - name: Resolve PR head ref - if: github.event_name == 'issue_comment' - id: pr - uses: actions/github-script@v7 - with: - script: | - const { data: pr } = await github.rest.pulls.get({ - owner: context.repo.owner, - repo: context.repo.repo, - pull_number: context.issue.number - }); - core.setOutput('sha', pr.head.sha); - - name: Checkout code uses: actions/checkout@v4 - with: - ref: ${{ github.event_name == 'issue_comment' && steps.pr.outputs.sha || github.ref }} - name: Set up node uses: actions/setup-node@v4 From c82385bf40cd01d8426059d09ef478575acd8efc Mon Sep 17 00:00:00 2001 From: Claire Peng <128436909+clairep94@users.noreply.github.com> Date: Sat, 18 Jul 2026 20:19:23 +0100 Subject: [PATCH 2/2] Enable e2e test to be approvable from any PR --- .github/workflows/e2e.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index bc44129617..5bfb3e67e1 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -6,13 +6,6 @@ on: jobs: test-e2e: environment: e2e-tests - # only trigger on workflow_dispatch, or if PR is from GSOC project mentor or mentee - if: > - github.event_name == 'workflow_dispatch' || - ( - github.event_name == 'pull_request' && - contains(fromJSON('["Geethegreat", "clairep94"]'), github.event.pull_request.user.login) - ) timeout-minutes: 60 runs-on: ubuntu-latest