From fb82b19b46979728d93445ceadc111c829a89b2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Bernard?= Date: Tue, 3 Nov 2026 15:59:40 +0100 Subject: [PATCH 1/3] SmileWanted: Use bid.mtype to set the bid media type - Read bid.mtype (1 banner, 2 video) when it is set. - Fall back to the impression when mtype is absent. - Add tests for a banner + video impression with mtype 1, mtype 2 and without mtype. --- .../bidder/smilewanted/SmileWantedBidder.java | 13 +++- .../smilewanted/SmileWantedBidderTest.java | 63 +++++++++++++++++++ 2 files changed, 74 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java b/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java index e75601bf389..2946dbd50d4 100644 --- a/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java +++ b/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java @@ -3,6 +3,7 @@ import com.fasterxml.jackson.core.type.TypeReference; import com.iab.openrtb.request.BidRequest; import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; import com.iab.openrtb.response.BidResponse; import com.iab.openrtb.response.SeatBid; import io.vertx.core.MultiMap; @@ -101,11 +102,19 @@ private static List bidsFromResponse(BidRequest bidRequest, BidRespon final SeatBid firstSeatBid = bidResponse.getSeatbid().getFirst(); return CollectionUtils.emptyIfNull(firstSeatBid.getBid()).stream() .filter(Objects::nonNull) - .map(bid -> BidderBid.of(bid, getBidType(bid.getImpid(), bidRequest.getImp()), bidResponse.getCur())) + .map(bid -> BidderBid.of(bid, getBidType(bid, bidRequest.getImp()), bidResponse.getCur())) .toList(); } - private static BidType getBidType(String impid, List imps) { + private static BidType getBidType(Bid bid, List imps) { + return switch (bid.getMtype()) { + case 1 -> BidType.banner; + case 2 -> BidType.video; + case null, default -> getBidTypeFromImp(bid.getImpid(), imps); + }; + } + + private static BidType getBidTypeFromImp(String impid, List imps) { for (Imp imp : imps) { if (imp.getId().equals(impid) && imp.getVideo() != null) { return BidType.video; diff --git a/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java b/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java index c2212c698b8..7247103265b 100644 --- a/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java @@ -1,6 +1,7 @@ package org.prebid.server.bidder.smilewanted; import com.fasterxml.jackson.core.JsonProcessingException; +import com.iab.openrtb.request.Banner; import com.iab.openrtb.request.BidRequest; import com.iab.openrtb.request.Imp; import com.iab.openrtb.request.Video; @@ -229,6 +230,60 @@ public void makeBidsShouldReturnBannerBidIfVideoIsAbsentInRequestImp() throws Js .containsOnly(BidderBid.of(Bid.builder().impid("123").build(), banner, null)); } + @Test + public void makeBidsShouldReturnBannerBidIfMtypeIsBannerOnMultiFormatImp() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenMultiFormatImp())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(1))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(1).build(), banner, null)); + } + + @Test + public void makeBidsShouldReturnVideoBidIfMtypeIsVideoOnMultiFormatImp() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenMultiFormatImp())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(2))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(2).build(), video, null)); + } + + @Test + public void makeBidsShouldReturnVideoBidIfMtypeIsAbsentOnMultiFormatImp() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenMultiFormatImp())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123"))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").build(), video, null)); + } + @Test public void makeBidsShouldReturnMultipleBidsFromSingleSeatBid() throws JsonProcessingException { // given @@ -350,4 +405,12 @@ private static Imp givenImp(String zoneId) { .ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpSmilewanted.of(zoneId)))) .build(); } + + private static Imp givenMultiFormatImp() { + return Imp.builder() + .id("123") + .banner(Banner.builder().build()) + .video(Video.builder().build()) + .build(); + } } From 63067f557a5a6dd4751b03d1e1478ec128a4e9d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Bernard?= Date: Wed, 4 Nov 2026 15:20:23 +0100 Subject: [PATCH 2/3] SmileWanted: Add audio and native support - Declare audio and native media types for app and site. - Map bid.mtype 3 to audio and 4 to native. - Without mtype, fall back to the impression: video, then audio, then native, otherwise banner. - Add tests for audio and native bids, with and without mtype. --- .../bidder/smilewanted/SmileWantedBidder.java | 14 +++- .../resources/bidder-config/smilewanted.yaml | 4 + .../smilewanted/SmileWantedBidderTest.java | 78 +++++++++++++++++++ 3 files changed, 95 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java b/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java index 2946dbd50d4..36422b9a37b 100644 --- a/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java +++ b/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java @@ -110,15 +110,27 @@ private static BidType getBidType(Bid bid, List imps) { return switch (bid.getMtype()) { case 1 -> BidType.banner; case 2 -> BidType.video; + case 3 -> BidType.audio; + case 4 -> BidType.xNative; case null, default -> getBidTypeFromImp(bid.getImpid(), imps); }; } private static BidType getBidTypeFromImp(String impid, List imps) { for (Imp imp : imps) { - if (imp.getId().equals(impid) && imp.getVideo() != null) { + if (!imp.getId().equals(impid)) { + continue; + } + if (imp.getVideo() != null) { return BidType.video; } + if (imp.getAudio() != null) { + return BidType.audio; + } + if (imp.getXNative() != null) { + return BidType.xNative; + } + return BidType.banner; } return BidType.banner; } diff --git a/src/main/resources/bidder-config/smilewanted.yaml b/src/main/resources/bidder-config/smilewanted.yaml index 659d74f9b0c..6af3170503a 100644 --- a/src/main/resources/bidder-config/smilewanted.yaml +++ b/src/main/resources/bidder-config/smilewanted.yaml @@ -6,9 +6,13 @@ adapters: app-media-types: - banner - video + - audio + - native site-media-types: - banner - video + - audio + - native supported-vendors: vendor-id: 639 usersync: diff --git a/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java b/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java index 7247103265b..fb7da3f9ce5 100644 --- a/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/smilewanted/SmileWantedBidderTest.java @@ -1,9 +1,11 @@ package org.prebid.server.bidder.smilewanted; import com.fasterxml.jackson.core.JsonProcessingException; +import com.iab.openrtb.request.Audio; import com.iab.openrtb.request.Banner; import com.iab.openrtb.request.BidRequest; import com.iab.openrtb.request.Imp; +import com.iab.openrtb.request.Native; import com.iab.openrtb.request.Video; import com.iab.openrtb.response.Bid; import com.iab.openrtb.response.BidResponse; @@ -32,8 +34,10 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; import static org.assertj.core.api.Assertions.tuple; +import static org.prebid.server.proto.openrtb.ext.response.BidType.audio; import static org.prebid.server.proto.openrtb.ext.response.BidType.banner; import static org.prebid.server.proto.openrtb.ext.response.BidType.video; +import static org.prebid.server.proto.openrtb.ext.response.BidType.xNative; public class SmileWantedBidderTest extends VertxTest { @@ -284,6 +288,80 @@ public void makeBidsShouldReturnVideoBidIfMtypeIsAbsentOnMultiFormatImp() throws .containsOnly(BidderBid.of(Bid.builder().impid("123").build(), video, null)); } + @Test + public void makeBidsShouldReturnAudioBidIfMtypeIsAudio() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(Imp.builder().id("123").audio(Audio.builder().build()).build())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(3))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(3).build(), audio, null)); + } + + @Test + public void makeBidsShouldReturnNativeBidIfMtypeIsNative() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(Imp.builder().id("123").xNative(Native.builder().build()).build())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").mtype(4))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").mtype(4).build(), xNative, null)); + } + + @Test + public void makeBidsShouldReturnAudioBidIfMtypeIsAbsentAndAudioIsPresentInRequestImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(Imp.builder().id("123").audio(Audio.builder().build()).build())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123"))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").build(), audio, null)); + } + + @Test + public void makeBidsShouldReturnNativeBidIfMtypeIsAbsentAndNativeIsPresentInRequestImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(Imp.builder().id("123").xNative(Native.builder().build()).build())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123"))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").build(), xNative, null)); + } + @Test public void makeBidsShouldReturnMultipleBidsFromSingleSeatBid() throws JsonProcessingException { // given From 9435ae626ba894537ae54caa155fed5de92f66d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Bernard?= Date: Thu, 19 Nov 2026 10:46:59 +0100 Subject: [PATCH 3/3] SmileWanted: Deduce the bid type from the markup when mtype is absent - Without mtype, on an impression that offers banner and another media type, read the markup: VAST is video or audio, a JSON object is native, anything else is banner. - An impression without banner keeps its own media type. - Add tests without mtype for banner + video, audio and native impressions, with each kind of markup. --- .../bidder/smilewanted/SmileWantedBidder.java | 38 +++--- .../smilewanted/SmileWantedBidderTest.java | 115 ++++++++++++++++-- 2 files changed, 131 insertions(+), 22 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java b/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java index 36422b9a37b..9f99df66564 100644 --- a/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java +++ b/src/main/java/org/prebid/server/bidder/smilewanted/SmileWantedBidder.java @@ -8,6 +8,7 @@ import com.iab.openrtb.response.SeatBid; import io.vertx.core.MultiMap; import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; import org.prebid.server.bidder.Bidder; import org.prebid.server.bidder.model.BidderBid; import org.prebid.server.bidder.model.BidderCall; @@ -112,25 +113,34 @@ private static BidType getBidType(Bid bid, List imps) { case 2 -> BidType.video; case 3 -> BidType.audio; case 4 -> BidType.xNative; - case null, default -> getBidTypeFromImp(bid.getImpid(), imps); + case null, default -> getBidTypeFromImp(bid, imps); }; } - private static BidType getBidTypeFromImp(String impid, List imps) { + private static BidType getBidTypeFromImp(Bid bid, List imps) { for (Imp imp : imps) { - if (!imp.getId().equals(impid)) { - continue; + if (imp.getId().equals(bid.getImpid())) { + return getBidTypeFromMarkup(bid.getAdm(), imp); } - if (imp.getVideo() != null) { - return BidType.video; - } - if (imp.getAudio() != null) { - return BidType.audio; - } - if (imp.getXNative() != null) { - return BidType.xNative; - } - return BidType.banner; + } + return BidType.banner; + } + + // Among the media types the imp offers, the markup decides: VAST is video or audio, + // a JSON object is native, anything else is banner. An imp without banner keeps its own media type. + private static BidType getBidTypeFromMarkup(String adm, Imp imp) { + final boolean isVast = StringUtils.contains(adm, ""; + private static final String NATIVE_ADM = "{\"ver\":\"1.2\",\"assets\":[{\"id\":1,\"title\":{\"text\":\"Title\"}}]}"; private final SmileWantedBidder target = new SmileWantedBidder(ENDPOINT_URL, jacksonMapper); @@ -271,13 +274,14 @@ public void makeBidsShouldReturnVideoBidIfMtypeIsVideoOnMultiFormatImp() throws } @Test - public void makeBidsShouldReturnVideoBidIfMtypeIsAbsentOnMultiFormatImp() throws JsonProcessingException { + public void makeBidsShouldReturnBannerBidIfMtypeIsAbsentAndAdmIsHtmlOnBannerVideoImp() + throws JsonProcessingException { // given final BidderCall httpCall = givenHttpCall( BidRequest.builder() .imp(singletonList(givenMultiFormatImp())) .build(), - givenBidResponse(bidBuilder -> bidBuilder.impid("123"))); + givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(HTML_ADM))); // when final Result> result = target.makeBids(httpCall, null); @@ -285,7 +289,102 @@ public void makeBidsShouldReturnVideoBidIfMtypeIsAbsentOnMultiFormatImp() throws // then assertThat(result.getErrors()).isEmpty(); assertThat(result.getValue()) - .containsOnly(BidderBid.of(Bid.builder().impid("123").build(), video, null)); + .containsOnly(BidderBid.of(Bid.builder().impid("123").adm(HTML_ADM).build(), banner, null)); + } + + @Test + public void makeBidsShouldReturnVideoBidIfMtypeIsAbsentAndAdmIsVastOnBannerVideoImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenMultiFormatImp())) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(VAST_ADM))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").adm(VAST_ADM).build(), video, null)); + } + + @Test + public void makeBidsShouldReturnBannerBidIfMtypeIsAbsentAndAdmIsHtmlOnBannerAudioImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenBannerImp(impBuilder -> impBuilder.audio(Audio.builder().build())))) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(HTML_ADM))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").adm(HTML_ADM).build(), banner, null)); + } + + @Test + public void makeBidsShouldReturnAudioBidIfMtypeIsAbsentAndAdmIsVastOnBannerAudioImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenBannerImp(impBuilder -> impBuilder.audio(Audio.builder().build())))) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(VAST_ADM))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").adm(VAST_ADM).build(), audio, null)); + } + + @Test + public void makeBidsShouldReturnBannerBidIfMtypeIsAbsentAndAdmIsHtmlOnBannerNativeImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenBannerImp(impBuilder -> impBuilder.xNative(Native.builder().build())))) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(HTML_ADM))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").adm(HTML_ADM).build(), banner, null)); + } + + @Test + public void makeBidsShouldReturnNativeBidIfMtypeIsAbsentAndAdmIsJsonOnBannerNativeImp() + throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + BidRequest.builder() + .imp(singletonList(givenBannerImp(impBuilder -> impBuilder.xNative(Native.builder().build())))) + .build(), + givenBidResponse(bidBuilder -> bidBuilder.impid("123").adm(NATIVE_ADM))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()) + .containsOnly(BidderBid.of(Bid.builder().impid("123").adm(NATIVE_ADM).build(), xNative, null)); } @Test @@ -485,10 +584,10 @@ private static Imp givenImp(String zoneId) { } private static Imp givenMultiFormatImp() { - return Imp.builder() - .id("123") - .banner(Banner.builder().build()) - .video(Video.builder().build()) - .build(); + return givenBannerImp(impBuilder -> impBuilder.video(Video.builder().build())); + } + + private static Imp givenBannerImp(Function impCustomizer) { + return impCustomizer.apply(Imp.builder().id("123").banner(Banner.builder().build())).build(); } }