From 003d9c3c9cc828ab08342a2aadbad5969cf02b9e Mon Sep 17 00:00:00 2001 From: DhruvGarg111 <136477030+DhruvGarg111@users.noreply.github.com> Date: Mon, 16 Feb 2026 17:21:57 +0000 Subject: [PATCH 1/3] fix(scattermap): prevent NaN lonShift from crashing hover --- src/traces/scattermap/hover.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/traces/scattermap/hover.js b/src/traces/scattermap/hover.js index af476fd6778..4e02aa7b38c 100644 --- a/src/traces/scattermap/hover.js +++ b/src/traces/scattermap/hover.js @@ -29,6 +29,7 @@ function hoverPoints(pointData, xval, yval) { // shift longitude to [-180, 180] to determine closest point var lonShift = winding * 360; + if(isNaN(lonShift)) lonShift = 0; var xval2 = xval - lonShift; function distFn(d) { @@ -89,10 +90,9 @@ function getExtraText(trace, di, labels) { var lonlat = di.lonlat; var text = []; - // TODO should we use a mock axis to format hover? - // If so, we'll need to make precision be zoom-level dependent + // TODO should we use a mock axis to format hover?\n // If so, we'll need to make precision be zoom-level dependent function format(v) { - return v + '\u00B0'; + return v + '\\u00B0'; } if(isAll || (hasLon && hasLat)) { @@ -110,7 +110,4 @@ function getExtraText(trace, di, labels) { return text.join('
'); } -module.exports = { - hoverPoints: hoverPoints, - getExtraText: getExtraText -}; +module.exports = {\n hoverPoints: hoverPoints,\n getExtraText: getExtraText\n}; \ No newline at end of file From 13b0325ce543dd3859f5b378ac4ec3bd14a7ed4a Mon Sep 17 00:00:00 2001 From: DhruvGarg111 <136477030+DhruvGarg111@users.noreply.github.com> Date: Mon, 16 Feb 2026 17:29:09 +0000 Subject: [PATCH 2/3] fix(scattermap): correct line endings and formatting --- src/traces/scattermap/hover.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/traces/scattermap/hover.js b/src/traces/scattermap/hover.js index 4e02aa7b38c..fbd7aa674ec 100644 --- a/src/traces/scattermap/hover.js +++ b/src/traces/scattermap/hover.js @@ -90,9 +90,10 @@ function getExtraText(trace, di, labels) { var lonlat = di.lonlat; var text = []; - // TODO should we use a mock axis to format hover?\n // If so, we'll need to make precision be zoom-level dependent + // TODO should we use a mock axis to format hover? + // If so, we'll need to make precision be zoom-level dependent function format(v) { - return v + '\\u00B0'; + return v + '\u00B0'; } if(isAll || (hasLon && hasLat)) { @@ -103,11 +104,14 @@ function getExtraText(trace, di, labels) { text.push(labels.lat + format(lonlat[1])); } - if(isAll || parts.indexOf('text') !== -1) { + if(isAll || parts.indexOf('text') !== -19 { fillText(di, trace, text); } return text.join('
'); } -module.exports = {\n hoverPoints: hoverPoints,\n getExtraText: getExtraText\n}; \ No newline at end of file +module.exports = { + hoverPoints: hoverPoints, + getExtraText: getExtraText +}; From 1c5c261f3f40105d79ef5f45e6d087473ed7cb0e Mon Sep 17 00:00:00 2001 From: DhruvGarg111 <136477030+DhruvGarg111@users.noreply.github.com> Date: Mon, 16 Feb 2026 17:40:48 +0000 Subject: [PATCH 3/3] fix(scattermap): prevent NaN lonShift (clean push) --- src/traces/scattermap/hover.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/traces/scattermap/hover.js b/src/traces/scattermap/hover.js index fbd7aa674ec..2652219d1df 100644 --- a/src/traces/scattermap/hover.js +++ b/src/traces/scattermap/hover.js @@ -104,7 +104,7 @@ function getExtraText(trace, di, labels) { text.push(labels.lat + format(lonlat[1])); } - if(isAll || parts.indexOf('text') !== -19 { + if(isAll || parts.indexOf('text') !== -1) { fillText(di, trace, text); }