Detailed Description
Currently, only positive lags are supported in RV calculation:
|
delays = [abs(int(lag * samplerate)) for lag in lags] |
However, apply_lags() supports negative lags just fine.
Context / Motivation
I require this for an analysis, and there is no real cost. In fact, as it is implemented, it could be confusing for users.
Possible Implementation
I think it's pretty straightforward to fix:
delays = [int(lag * samplerate) for lag in lags]
Detailed Description
Currently, only positive lags are supported in RV calculation:
phys2denoise/phys2denoise/metrics/chest_belt.py
Line 155 in cfced3b
However,
apply_lags()supports negative lags just fine.Context / Motivation
I require this for an analysis, and there is no real cost. In fact, as it is implemented, it could be confusing for users.
Possible Implementation
I think it's pretty straightforward to fix: