`FormBuilderInterface::getForm()` should not return `FormInterface<TData|null>`, but `FormInterface<TData>`?

[devnix]

I think https://github.com/phpstan/phpstan-symfony/blob/2.0.x/stubs/Symfony/Component/Form/FormBuilderInterface.stub#L14-L17 is wrong: when I'm carrying around a FormBuilderInterface<SomeModel>, I would expect to build a form for a function that receives FormInterface<SomeModel>.

Indeed, then FormInterface::getData() would return SomeModel|null, but that would not be a requirement for FormBuilderInterface::getForm() to return FormInterface<SomeModel|null>. But maybe I'm missing something obvious here!

[devnix]

Indeed, it's the return of FormConfigInterface::getData() which should return TData|null instead of TData

[devnix]

I've just discovered this "recent" pull request, maybe will get some time to copy the correct types to the stubs so older Symfony versions can benefit of them: https://github.com/symfony/symfony/pull/61697/changes#diff-aee0a32ba4c0269e555b4889c904b60a08bedb775516d8ab785a9ed81435ade7

[zmitic]

@devnix

Indeed, it's the return of FormConfigInterface::getData() which should return TData|null instead of TData

Correct, this one is wrong and should return TData|null. Form can be valid and yet, still return null. For example: empty_data returns null and let individual constraints to handle the validation. Or having a transformer that will either return correct Money object, or null if it is optional.

[stof]

I've just discovered this "recent" pull request, maybe will get some time to copy the correct types to the stubs so older Symfony versions can benefit of them: https://github.com/symfony/symfony/pull/61697/changes#diff-aee0a32ba4c0269e555b4889c904b60a08bedb775516d8ab785a9ed81435ade7

note that this PR has been reverted because the generic types added in it don't reflect the reality of the behavior of the code.