Wrong type inference for QueryBuilder::update and QueryBuilder::delete.

[VincentLanglet]

The following code

$result = $this->getEntityManager()
            ->getRepository(ProductCrossSell::class)
            ->createQueryBuilder('pcs')
            ->where('pcs.id IN (:ids)')
            ->setParameter('ids', $ids)
            ->delete()
            ->getQuery()
            ->getResult();

\PHPStan\dumpType($result);

Is considering $result as an array. But it's an int: the number of deleted elements. Same with update()

It was introduce by #232 cc @arnaud-lb

[arnaud-lb]

Hi @VincentLanglet

I believe that there are two distinct issues here. The first one is that

$result = $this->getEntityManager()
            ->getRepository(ProductCrossSell::class)
            ->createQueryBuilder('pcs')
            ->where('pcs.id IN (:ids)')
            ->setParameter('ids', $ids)
            ->delete()
            ->getQuery()

may be Query<mixed>. Could you confirm ?

If that's the case, the second issue is that the type of Query<mixed>::getResult() should not be array because the query may be an INSERT or DELETE query.

[VincentLanglet]

may be Query<mixed>. Could you confirm ?

Indeed Dumped type: Doctrine\ORM\Query<mixed>

[arnaud-lb]

Thank you.

I'm fixing the second issue in #260.

I'm not sure about the cause of the first issue. What is the type of ->getRepository(ProductCrossSell::class) ? Could you confirm that the query is valid ?

[VincentLanglet]

I'm not sure about the cause of the first issue. What is the type of ->getRepository(ProductCrossSell::class) ?

Dumped type: App\Repository\ProductCrossSellRepository<App\Entity\ProductCrossSell>  

Could you confirm that the query is valid ?

Yes, it's just a DELETE with a WHERE condition on ids.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.