Skip to content

Commit e429641

Browse files
committed
remove unmeasured "warmups"
1 parent 0f1dccc commit e429641

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

benchmark/benchmark.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function runSymfonyDemo(bool $jit): array {
7979
cloneRepo($dir, 'https://github.com/php/benchmarking-symfony-demo-2.2.3.git');
8080
runPhpCommand([$dir . '/bin/console', 'cache:clear']);
8181
runPhpCommand([$dir . '/bin/console', 'cache:warmup']);
82-
return runValgrindPhpCgiCommand('symfony-demo', [$dir . '/public/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
82+
return runValgrindPhpCgiCommand('symfony-demo', [$dir . '/public/index.php'], cwd: $dir, jit: $jit, repeat: 100);
8383
}
8484

8585
function runWordpress(bool $jit): array {
@@ -102,7 +102,7 @@ function runWordpress(bool $jit): array {
102102

103103
// Warmup
104104
runPhpCommand([$dir . '/index.php'], $dir);
105-
return runValgrindPhpCgiCommand('wordpress', [$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
105+
return runValgrindPhpCgiCommand('wordpress', [$dir . '/index.php'], cwd: $dir, jit: $jit, repeat: 100);
106106
}
107107

108108
function runPhpCommand(array $args, ?string $cwd = null): ProcessResult {
@@ -114,7 +114,6 @@ function runValgrindPhpCgiCommand(
114114
array $args,
115115
?string $cwd = null,
116116
bool $jit = false,
117-
int $warmup = 0,
118117
int $repeat = 1,
119118
): array {
120119
global $phpCgi;
@@ -131,7 +130,7 @@ function runValgrindPhpCgiCommand(
131130
"--callgrind-out-file=$profileOut",
132131
'--',
133132
$phpCgi,
134-
'-T' . ($warmup ? $warmup . ',' : '') . $repeat,
133+
'-T' . $repeat,
135134
'-d max_execution_time=0',
136135
'-d opcache.enable=1',
137136
'-d opcache.jit=' . ($jit ? 'tracing' : 'disable'),

0 commit comments

Comments
 (0)