Skip to content

Commit 663eff8

Browse files
committed
Updated comments [skip ci]
1 parent 3cb5fee commit 663eff8

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

tests/test_asyncpg.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ async def test_bit(self) -> None:
6565
await conn.execute('DROP TABLE IF EXISTS asyncpg_items')
6666
await conn.execute('CREATE TABLE asyncpg_items (id bigserial PRIMARY KEY, embedding bit(3))')
6767

68+
# typing issue
6869
# https://github.com/MagicStack/py-pgproto/pull/32
6970
embedding = asyncpg.BitString('101') # type: ignore
7071
embedding2 = None

tests/test_sqlalchemy.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,6 +638,7 @@ async def test_bit(self, engine: AsyncEngine) -> None:
638638

639639
async with async_session() as session:
640640
async with session.begin():
641+
# typing issue
641642
# https://github.com/MagicStack/py-pgproto/pull/32
642643
embedding = asyncpg.BitString('101') if engine == asyncpg_engine else '101' # type: ignore
643644
session.add(Item(id=1, binary_embedding=embedding))

tests/test_sqlmodel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Item(SQLModel, table=True):
1818
model_config = ConfigDict(arbitrary_types_allowed=True) # type: ignore
1919

2020
id: int | None = Field(default=None, primary_key=True)
21-
# typing issues
21+
# typing issue
2222
# https://github.com/fastapi/sqlmodel/discussions/1228
2323
# https://github.com/fastapi/sqlmodel/pull/1345
2424
embedding: list[float] | None = Field(default=None, sa_type=VECTOR(3)) # type: ignore

0 commit comments

Comments
 (0)