chore(scaffold): post-merge cleanup backlog

[cursor]

Follow-up items from PR #124 code review. None are blocking.

High

• Weak assertion in error-path e2e tests (bin/create-e2e.test.js) — actual: err?.code !== 0 passes even when no error is thrown because undefined !== 0 is true. Fix: actual: err !== undefined && err.code !== 0

Medium

• Replace bare @ts-expect-error with JSDoc @param types — lib/scaffold-resolver.js has 10 suppressions, lib/scaffold-commands.js has 11. The four URL helpers (isHttpUrl, isInsecureHttpUrl, isFileUrl, isGitHubRepoUrl) and several others could be fixed with a simple /** @param {string} url */ annotation, making suppressions unnecessary.

Low

• ALL_CAPS constants violate naming guide — KNOWN_STEP_KEYS, DEFAULT_SCAFFOLD_TYPE, GITHUB_DOWNLOAD_HOSTNAMES, SCAFFOLD_DOWNLOAD_DIR, AIDD_HOME, CONFIG_FILE across five files. Rename to camelCase per the JS style guide.

• next-shadcn default scaffold is a stub — delivers a single prompt step telling users to run create-next-app manually. Needs a real implementation.

References

• PR feat(scaffold): add create, verify-scaffold, scaffold-cleanup, and set commands #124
• tasks/npx-aidd-create-epic.md