From 6cf19d87c4ebd1871257340a28b249adc1aad985 Mon Sep 17 00:00:00 2001
From: Robert Luby <rluby@redhat.com>
Date: Wed, 2 Sep 2026 11:05:13 +0200
Subject: [PATCH 1/2] fix: align setup guide list numbers with text in Firefox

The setup guide modal rendered each step with PatternFly List/ListItem,
which wraps item content in an inline span around block paragraphs. Inside
the flex-based .pf-v6-c-list, Firefox positioned the ordered-list number
above the step title instead of beside it (Chrome was unaffected).

Render the steps with Content ol/li instead, which places the paragraphs
directly in the li and aligns the number with the title in both Firefox
and Chrome. Verified by rendering the real PatternFly markup in both.

Also bold the step title via pf-v6-u-font-weight-bold instead of strong,
drop the unused data-test attributes, and give SetupGuide a className prop
so the empty state passes spacing to the component instead of wrapping it
in a div.

Issue SRVOCF-1074

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .../function-list/components/EmptyState.tsx   |  4 +--
 .../function-list/components/SetupGuide.tsx   | 31 +++++++++----------
 2 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/src/pages/function-list/components/EmptyState.tsx b/src/pages/function-list/components/EmptyState.tsx
index 1ba8b8cf..ffa87c43 100644
--- a/src/pages/function-list/components/EmptyState.tsx
+++ b/src/pages/function-list/components/EmptyState.tsx
@@ -25,9 +25,7 @@ export function FunctionsEmptyState({ isCreateDisabled }: FunctionsEmptyStatePro
               "A GitHub Personal Access Token is required to create functions. Click 'Connect to GitHub' in the top-right corner to connect. Once connected, the create button will be enabled.",
             )
           : t('Create a serverless function to get started.')}
-        <div className="pf-v6-u-mt-sm">
-          <SetupGuide />
-        </div>
+        <SetupGuide className="pf-v6-u-display-block pf-v6-u-mx-auto pf-v6-u-mt-sm" />
       </EmptyStateBody>
       <EmptyStateFooter>
         <EmptyStateActions>
diff --git a/src/pages/function-list/components/SetupGuide.tsx b/src/pages/function-list/components/SetupGuide.tsx
index 50ca363d..c8c1f47a 100644
--- a/src/pages/function-list/components/SetupGuide.tsx
+++ b/src/pages/function-list/components/SetupGuide.tsx
@@ -1,8 +1,6 @@
 import {
   Button,
   Content,
-  List,
-  ListItem,
   Modal,
   ModalBody,
   ModalFooter,
@@ -11,18 +9,17 @@ import {
 import { ReactNode, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 
-export function SetupGuide() {
+interface SetupGuideProps {
+  className?: string;
+}
+
+export function SetupGuide({ className }: SetupGuideProps) {
   const { t } = useTranslation('plugin__console-functions-plugin');
   const [isOpen, setIsOpen] = useState(false);
 
   return (
     <>
-      <Button
-        variant="link"
-        isInline
-        onClick={() => setIsOpen(true)}
-        data-test="setup-guide-button"
-      >
+      <Button variant="link" isInline onClick={() => setIsOpen(true)} className={className}>
         {t('View setup guide.')}
       </Button>
       <SetupGuideModal isOpen={isOpen} onClose={() => setIsOpen(false)} />
@@ -39,25 +36,25 @@ function SetupGuideModal({ isOpen, onClose }: SetupGuideModalProps) {
   const { t } = useTranslation('plugin__console-functions-plugin');
 
   return (
-    <Modal isOpen={isOpen} onClose={onClose} variant="medium" data-test="setup-guide-modal">
+    <Modal isOpen={isOpen} onClose={onClose} variant="medium">
       <ModalHeader title={t('Set up guide')} />
       <ModalBody>
         <Content component="p">
           {t('Follow these steps to create and deploy your serverless function.')}
         </Content>
-        <List component="ol" className="pf-v6-u-mt-md">
+        <Content component="ol" className="pf-v6-u-mt-md">
           {steps(t).map((step) => (
-            <ListItem key={step.title}>
-              <Content component="p">
-                <strong>{step.title}</strong>
+            <Content component="li" key={step.title}>
+              <Content component="p" className="pf-v6-u-font-weight-bold">
+                {step.title}
               </Content>
               <Content component="p">{step.body}</Content>
-            </ListItem>
+            </Content>
           ))}
-        </List>
+        </Content>
       </ModalBody>
       <ModalFooter>
-        <Button variant="primary" onClick={onClose} data-test="setup-guide-close-button">
+        <Button variant="primary" onClick={onClose}>
           {t('Close')}
         </Button>
       </ModalFooter>

From 35fca471fd1f47a06151b52f7cbbaa9abb74d8a9 Mon Sep 17 00:00:00 2001
From: Robert Luby <rluby@redhat.com>
Date: Wed, 2 Sep 2026 11:12:38 +0200
Subject: [PATCH 2/2] chore: ignore .claude/worktrees local scratch dir

Claude Code creates ephemeral, locked git worktrees under .claude/worktrees
for parallel tasks. They are local-only and were showing up as untracked
changes, blocking the pre-PR check. Ignore them alongside the other local
.claude entries.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 9fd8f3f3..862ddd1e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -23,6 +23,7 @@ AGENTS.override.md
 .claude/*.local.*
 .claude/settings*.json
 .claude/pr/*
+.claude/worktrees/
 .mcp*
 .tmp
 .pi-subagents