Skip to content

Commit 5fb7d75

Browse files
rhamiltoclaude
andcommitted
CONSOLE-4447: Remove orphaned CSS classes from _modals.scss
Removes unused CSS classes that were only used by the deprecated modal components: - .co-overlay (used by old ModalWrapper component) - .modal-footer (replaced by PatternFly ModalFooter) - .modal-paragraph (no longer needed with PatternFly modals) All remaining classes in _modals.scss are still in use by existing modals or integration tests. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 818c240 commit 5fb7d75

11 files changed

Lines changed: 7 additions & 117 deletions

File tree

frontend/packages/console-app/src/actions/hooks/useCommonActions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ export const useCommonActions = <T extends readonly CommonActionCreator[]>(
135135
launchModal(LazyTolerationsModalOverlay, {
136136
resourceKind: kind,
137137
resource,
138-
modalClassName: 'modal-lg',
139138
}),
140139
accessReview: asAccessReview(kind as K8sModel, resource as K8sResourceKind, 'patch'),
141140
}),

frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ table in [Console dynamic plugins README](./README.md).
1515
- **Breaking**: Changed `AlertAction` extension to use `LaunchOverlay` instead of `LaunchModal`. The `action` callback parameter is now typed as `LaunchOverlay`, which does not support the optional `id` parameter that `LaunchModal` had. Plugins implementing `console.alert-action` extensions must update their action callbacks accordingly. ([CONSOLE-4447])
1616
- **Breaking**: Removed `pluginID` from the result in `useResolvedExtensions` hook ([CONSOLE-3769], [#15904])
1717
- **Breaking**: Removed `AppInitSDK` and `useReduxStore` in `app` directory ([CONSOLE-5063], [#16019])
18+
- **Breaking**: Removed CSS classes from Console core that were used for deprecated modal components. Plugins that reference these classes in their custom CSS should migrate to PatternFly v6 modal classes (e.g., `.pf-v6-c-modal-box__body`) or use data-test attributes. Removed classes: `.co-overlay`, `.modal-footer`, `.modal-paragraph`, `.modal-header`, `.modal-body`, `.modal-body-border`, `.modal-body-content`, `.modal-content`, `.modal-dialog`, `.co-modal-table`, `.modal__inline-resource-link` ([CONSOLE-4447])
1819
- **Deprecated**: `useUserSettings` hook has been renamed to `useUserPreference` for consistency ([OCPBUGS-44612], [#16057])
1920
- **Type breaking**: Changed `useDeleteModal` hook's `redirectTo` parameter type from `LocationDescriptor` (from `history`) to `To` (from `react-router-dom-v5-compat`) ([CONSOLE-4990], [#15959])
2021
- **Type breaking**: Changed `FileUploadHandler` return type from `void` to `To | void`. Handlers can now return a path (from `react-router-dom-v5-compat`) for programmatic navigation instead of calling history methods directly ([CONSOLE-4990], [#15959])
@@ -180,6 +181,7 @@ table in [Console dynamic plugins README](./README.md).
180181
[CONSOLE-4400]: https://issues.redhat.com/browse/CONSOLE-4400
181182
[CONSOLE-4402]: https://issues.redhat.com/browse/CONSOLE-4402
182183
[CONSOLE-4407]: https://issues.redhat.com/browse/CONSOLE-4407
184+
[CONSOLE-4447]: https://issues.redhat.com/browse/CONSOLE-4447
183185
[CONSOLE-4499]: https://issues.redhat.com/browse/CONSOLE-4499
184186
[CONSOLE-4576]: https://issues.redhat.com/browse/CONSOLE-4576
185187
[CONSOLE-4630]: https://issues.redhat.com/browse/CONSOLE-4630

frontend/packages/operator-lifecycle-manager/src/components/modals/uninstall-operator-modal.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,3 @@
1616
.co-operator-uninstall__operands-section loading-skeleton--table::after {
1717
min-height: 160px;
1818
}
19-
20-
.co-catalog-install-modal .modal-header .co-clusterserviceversion-logo__icon {
21-
border: var(--pf-t--global--border--width--regular) solid
22-
var(--pf-t--global--border--color--default);
23-
}

frontend/public/components/factory/_modal-wrapper.scss

Whitespace-only changes.

frontend/public/components/modals/_modals.scss

Lines changed: 0 additions & 94 deletions
This file was deleted.

frontend/public/components/modals/delete-modal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ export const DeleteModal = (props: DeleteModalProps) => {
152152
<Trans t={t} ns="public">
153153
This resource is managed by{' '}
154154
<ResourceLink
155-
className="modal__inline-resource-link"
155+
className="pf-v6-u-mr-0"
156156
inline
157157
kind={referenceForOwnerRef(owner)}
158158
name={owner.name}

frontend/public/components/modals/managed-resource-save-modal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const ManagedResourceSaveModal: FC<ManagedResourceSaveModalProps> = (props) => {
3939
<Trans t={t} ns="public">
4040
This resource is managed by{' '}
4141
<ResourceLink
42-
className="modal__inline-resource-link"
42+
className="pf-v6-u-mr-0"
4343
inline
4444
kind={referenceForOwnerRef(owner)}
4545
name={owner.name}

frontend/public/components/modals/taints-modal.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,7 @@ const TaintsModal = (props: TaintsModalProps) => {
8888
{_.isEmpty(taints) ? (
8989
<EmptyBox label={t('Taints')} />
9090
) : (
91-
<Table
92-
aria-label={t('Taints')}
93-
variant="compact"
94-
borders={false}
95-
className="co-modal-table"
96-
>
91+
<Table aria-label={t('Taints')} variant="compact" borders={false}>
9792
<Thead>
9893
<Tr>
9994
<Th>{t('Key')}</Th>

frontend/public/components/modals/tolerations-modal.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,7 @@ const TolerationsModal = (props: TolerationsModalProps) => {
118118
{_.isEmpty(tolerations) ? (
119119
<EmptyBox label={t('public~Tolerations')} />
120120
) : (
121-
<Table
122-
aria-label={t('public~Tolerations')}
123-
variant="compact"
124-
borders={false}
125-
className="co-modal-table"
126-
>
121+
<Table aria-label={t('public~Tolerations')} variant="compact" borders={false}>
127122
<Thead>
128123
<Tr>
129124
<Th>{t('public~Key')}</Th>

frontend/public/style.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@
6767
@import 'components/edit-yaml';
6868
@import 'components/graphs/graphs';
6969
@import 'components/masthead';
70-
@import 'components/modals/modals';
7170
@import 'components/environment';
7271
@import 'components/utils/name-value-editor';
7372
@import 'components/utils/value-from-pair';

0 commit comments

Comments
 (0)