From 9d7a5822aa3b31a8b8f09d1019ad71a7bb0cb3cd Mon Sep 17 00:00:00 2001 From: Zane Bitter Date: Sat, 30 May 2026 00:01:46 +1200 Subject: [PATCH] Don't include agent GUI log bundle in screenshot archive If we get past a certain point in installation (presumably the start of bootstrapping), the log bundle downloaded from assisted-service contains secrets that set off the secret detector in CI. (In practice all of these secrets seem to relate to the cluster under test, which has been deleted by the time the CI artifacts are published.) Including this in the screenshots archive (which is the artifact collected by the CI step) means that the entire screenshot archive is redacted. Continue to download the log bundle for local debugging, but don't include it in the screenshot archive. --- agent/gather.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/agent/gather.sh b/agent/gather.sh index 7d37f1b8e..7d2507de0 100755 --- a/agent/gather.sh +++ b/agent/gather.sh @@ -51,11 +51,6 @@ if [[ "$num_screenshots" -gt 0 ]]; then files_to_archive+=("${OCP_DIR}"/*.png) fi - # Include installation logs if available - if [[ -f "${OCP_DIR}/installation-logs.tar" ]]; then - files_to_archive+=("${OCP_DIR}/installation-logs.tar") - fi - # Create archive with all collected files tar -cJf $archive_name "${files_to_archive[@]}" else