Listing favorites fails

[kulmann]

Describe the bug

Webdav REPORT with favorite filter rule fails with http 400.

Steps to reproduce

1. Enable favorites by setting FRONTEND_ENABLE_FAVORITES to true
2. Restart opencloud
3. Visit the web ui
4. Click on the Favorites link in the left sidebar

Expected behavior

Favorites are listed.

Actual behavior

No favorites get listed. The underlying webdav REPORT request fails with http 400.

Additional context

• Logged in as admin the url is https://host.docker.internal:9200/remote.php/dav/files/admin
• method: REPORT
• payload:

<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:prop>
    <oc:permissions/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:file-parent/>
    <oc:name/>
    <d:lockdiscovery/>
    <d:activelock/>
    <oc:owner-id/>
    <oc:owner-display-name/>
    <oc:remote-item-id/>
    <oc:shareroot/>
    <oc:share-types/>
    <oc:privatelink/>
    <d:getcontentlength/>
    <oc:size/>
    <d:getlastmodified/>
    <d:getetag/>
    <d:getcontenttype/>
    <d:resourcetype/>
    <oc:downloadURL/>
    <oc:tags/>
    <oc:audio/>
    <oc:location/>
    <oc:image/>
    <oc:photo/>
    <oc:has-preview/>
  </d:prop>
  <oc:filter-rules>
    <oc:favorite>1</oc:favorite>
  </oc:filter-rules>
</oc:filter-files>

[pascalwengerter]

I suppose #2454 and #2510 fixed this one? 😼

[pascalwengerter]

CC @AlexAndBear