diff --git a/README.md b/README.md index 66e268e..34c655f 100644 --- a/README.md +++ b/README.md @@ -104,6 +104,7 @@ For local development, you'll need to use `smee-client` to forward webhooks from WEBHOOK_SECRET= NODE_ENV=development ``` + - **`PRIVATE_KEY`**: If your private key is long, you can put the actual multiline content within double quotes, or point to the file: `PRIVATE_KEY_PATH=/path/to/your/private-key.pem`. - **Important**: For local development, make sure your GitHub App's webhook URL is set to your Smee.io URL. diff --git a/src/events/pull_request.opened/conventional-commits.ts b/src/events/pull_request.opened/conventional-commits.ts index ab576db..308caeb 100644 --- a/src/events/pull_request.opened/conventional-commits.ts +++ b/src/events/pull_request.opened/conventional-commits.ts @@ -23,7 +23,7 @@ export default async (context: Context<"pull_request.opened">) => { const message = commit.commit.message.split("\n")[0]; if (!parseConventionalCommit(message)) { problems.push( - `Commit [\`${commit.sha.slice(0, 7)}\`](https://github.com/${owner}/${repo}/commit/${commit.sha}) does not follow Conventional Commits: \`${message}\``, + `Commit https://github.com/${owner}/${repo}/commit/${commit.sha} does not follow Conventional Commits: \`${message}\``, ); } } diff --git a/src/events/workflow_run.completed/checklint.ts b/src/events/workflow_run.completed/checklint.ts index e2bb6a7..f7ed318 100644 --- a/src/events/workflow_run.completed/checklint.ts +++ b/src/events/workflow_run.completed/checklint.ts @@ -53,15 +53,20 @@ export default async (context: Context<"workflow_run.completed">) => { `> Run: [View logs](${logsUrl})`, "", "> [!TIP]", - "> Make sure to run the following before pushing:", + "> Make sure to check the following before pushing:", ">", - "> - eslint (code quality checks)", - "> - prettier (code formatting)", + "> - code formatting issues", + "> - code quality / linting errors", + "> - unused or broken imports", + "> - syntax or type issues (if applicable)", + "> - secret leaks or exposed credentials", + "> - security / dependency vulnerabilities", + "> - invalid YAML / JSON / config files", ">", - "> Then commit and push your fixes.", + "> Then fix the issues, commit, and push again.", "", "> [!NOTE]", - "> This is an automated reminder and will not block merging.", + "> This is just a friendly reminder and will **not block** the PR from being merged.", "", ].join("\n");