From cac407f5907505479b850a5b17a4745f6dcf6254 Mon Sep 17 00:00:00 2001 From: Davide Vacca Date: Wed, 21 Oct 2026 10:43:39 +0200 Subject: [PATCH] Raise last error when http code retry helper exhausts retries The helper previously returned an unset/null value after all retries failed, hiding the real API error. It now surfaces the last exception. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- tests/conftest.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index fe90ae5..e34eaf5 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -197,12 +197,11 @@ def repeat_request_until(function, params, predicate, error_message, max_retries def repeat_request_until_http_code_changes( function, params, max_retries=15, sleep_time=1 ): - iteration = 0 - while iteration <= max_retries: + last_exception = None + for _ in range(max_retries + 1): try: - instance = function(*params) - break - except onfido.ApiException: + return function(*params) + except onfido.ApiException as e: + last_exception = e sleep(sleep_time) - iteration += 1 - return instance + raise last_exception