Skip to content
This repository was archived by the owner on Apr 21, 2022. It is now read-only.
This repository was archived by the owner on Apr 21, 2022. It is now read-only.

'See code' links to GitHub won't work in Typescript monorepo #470

Description

@JaimeObregon

This way of checking for a TypeScript repository in the readme command is fragile:

    if (plugin.pjson.devDependencies && plugin.pjson.devDependencies.typescript) {

In a TypeScript monorepo using workspaces, typescript can be defined at the root package's devDependencies, where plugin.pjson.devDependencies.typescript wont reach.

In my setup this is causing to silently miss all the links to see the source in GitHub, but this seems to be provoking #126 and #143 too.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions