[plugin-report][app-shell] Dataset measures still render in the MACHINE locale — the consumers #4566 could not reach

[yinlianghui]

Found while implementing objectui#4566 (PR pending). Filed rather than fixed: both surfaces sit outside that card's ruled surface (app-shell is explicitly excluded there, with #4305 / #4549 in flight).

The gap

objectui#4566 gave formatMeasure / formatDimensionValue in @object-ui/core an optional trailing locale parameter and threaded useDisplayLocale() from DatasetWidget. The parameter is OPTIONAL and omitting it reproduces the old machine-locale behaviour byte for byte — deliberately, so the producer could land without dragging every consumer with it.

The consequence is that the consumers which were not threaded still render in the machine's locale. A census of every call site outside plugin-dashboard:

packages/plugin-report/src/DatasetReportRenderer.tsx — 10 sites:

• formatMeasure at lines 487, 502, 737, 994, 1005, 1019, 1029
• formatDimensionValue at lines 488, 792, 980

packages/app-shell/src/views/metadata-admin/ — 3 sites:

• previews/DatasetPreview.tsx:228 (formatMeasure) and :229 (formatDimensionValue)
• inspectors/DatasetDefaultInspector.tsx:181 (formatMeasure, the format-hint sample preview)

Why it can be observed

Exactly the symptom objectui#4566 describes, on the surfaces that card did not cover: a German session reads a report measure as 1,234.5 where the convention is 1.234,5, now sitting next to a DASHBOARD measure that (after #4566) renders 1.234,5. The two dataset-bound surfaces are fed by the same function and disagree — which is a sharper inconsistency than the one that existed before #4566, when both were uniformly wrong.

Shape of the fix

Mechanical, and already proven on the dashboard side: read useDisplayLocale() at component level and pass it as the last argument. DatasetReportRenderer and DatasetPreview are both components, so no further plumbing is needed. DatasetDefaultInspector's sample is a preview of authored formatting and should follow the same channel.

Worth checking per site whether any of them format inside a useMemo — the dashboard consumer did not, but objectui#4542 / #4554 / #4565 all did, and the locale has to enter the dependency array where they do.

Relations

• Consumer-side remainder of objectui#4566; same family as Console: number cell/display renderers hardcode a grouping Intl.NumberFormat('en-US') — an ordinal Field.number (a year) always renders 2,026, and no field property can turn it off #4033, Date formatter is half-localized: future relative forms and absolute timestamps stay en-US on a non-English locale #4272, plugin-timeline hardcodes 'en-US' at four date sites, so timeline headers stay English on every non-English session #4513, [plugin-grid] ObjectGrid's record-detail date fallback renders the MACHINE locale #4541, [plugin-gantt] tooltip number / currency / percent rows render in the MACHINE locale, next to date rows that follow the display locale #4553.
• Not a duplicate of [core] formatMeasure renders every dashboard measure in the MACHINE locale — the last parallel implementation outside the display-locale channel #4566: that card's ruled surface was dataset-format.ts plus the dashboard call sites, and it landed with those consumers complete.

---

Generated by Claude Code

[yinlianghui]

CLAIM — session_017Qqyix2QcnpUC9XeYVDzx3, branch claude/issue-4575-report-preview-measure-locale. Dispatching a dev agent now.

PM ruling (delegated decision authority; maintainer veto window open — record objections here): the mechanical completion of #4566's channel at the 13 sites its surface could not reach:

1. Thread useDisplayLocale() at the censused call sites — plugin-report DatasetReportRenderer.tsx (×10) and app-shell metadata-admin DatasetPreview.tsx (×2) + DatasetDefaultInspector.tsx (×1) — passing the locale to formatMeasure/formatDimensionValue per the parameter fix(core): dashboard measures follow the display locale (#4566) #4577 landed. Hooks at component level; if any site formats inside a memo, the locale joins that dep array (and if a dep case measurably cannot isolate, label it reasoning-guarded per the fix(fields): formatPercent groups and follows the display locale — the last tooltip channel (#4553) #4565 precedent, never as a false pin).
2. Red-first per surface with the fix(core): dashboard measures follow the display locale (#4566) #4577 falsifiability standard: every case pins TWO locales (de + en) so at least one fails on any runner; en byte-identical is the must-not-change; malformed-tag safety is already the producer's job (fix(core): dashboard measures follow the display locale (#4566) #4577's retry) — do not re-implement it, but one pin per package that a bad tag does not crash the surface is welcome.
3. Pins: existing report/preview suites green untouched; the fix(core): dashboard measures follow the display locale (#4566) #4577 producer pins untouched.
4. Changesets: '@object-ui/plugin-report' patch, '@object-ui/app-shell' patch (consumer threading, module-local — verify via .d.ts both ways). Never major.

Sequencing: gate worktree creation on PR #4577 reaching origin/main (armed on green CI — the parameter you thread lands there). Mutual exclusion: ⛔ #4548 in flight owns plugin-report ReportViewer.tsx (a DIFFERENT file — do not touch it) and packages/react; #4570 in flight owns SettingsView; #4563 owns apps/console entry; #4535 owns types + ObjectGrid exportOptions. Your three files are claimed by nobody — verify with a fresh fetch before editing, and if one moved on main mid-run, re-fetch and recreate rather than race.

---

Generated by Claude Code

---

Generated by Claude Code