You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sweep promotion from the findings-triage round (triage seat Routine, #5474 pilot — objectstack#5474). Same criterion as batch 2 (#3931): a declared/present surface with zero production consumers, measured by grep at a named ref — delete it. One claim, one PR, one Fixes line per member, per-item checklist review.
All premises verified on origin/main @ b16be40 (this round; per-member evidence on each member card):
packages/data-objectstack/src/index.ts — the five metadataCache.invalidate?.(views:${objectName}) sites (:3022, :3183, :3243, :3274, :3291)
invalidations of a cache key no read path ever populates (listViews never routes through metadataCache.get with a views: key — verified this round; note the card says 4 sites, main now has 5)
the five dead invalidate lines removed; listViews behavior unchanged (it is genuinely uncached — if caching is ever wanted, that is a new card, not this sweep)
required and read by nothing in production; resolveRoles and every other consumer read only name/inherits (sole non-test hit is a test-comment documenting the state)
field removed (or demoted per the member card's discussion if remoteness of the type surface demands it — the PR states which and why); typing consumers compile clean
Sweep discipline (binding, per the pm-dispatch sweep rules):
All members hit the same criterion — zero-consumer dead surface, delete.
This table is the review checklist — reviewed per row, not per diff order.
Zero changes outside the N items; git diff --stat must map 1:1 to the rows (plus changeset).
This card is the claim/dispatch object; members keep their queue state but are not individually dispatchable while this sweep is open (selection excludes them by this member list). PR carries Fixes #3775, Fixes #3778, Fixes #4288, and Fixes this card.
Member #3773 (RecordContextValue.loading/error) was considered and excluded: the premise has drifted — the context's memo now dep-lists both fields and the provider signature spreads all values, so zero-producer/zero-consumer needs re-measurement against current hosts before deletion is safe.
Sweep promotion from the findings-triage round (triage seat Routine, #5474 pilot — objectstack#5474). Same criterion as batch 2 (#3931): a declared/present surface with zero production consumers, measured by grep at a named ref — delete it. One claim, one PR, one
Fixesline per member, per-item checklist review.All premises verified on
origin/main@b16be40(this round; per-member evidence on each member card):packages/core/src/utils/merge-views-into-objects.ts(+ itsexport *line inpackages/core/src/index.ts:34)mergeViewsIntoObjectscopy, zero in-repo consumers; drops the container defaultlist, keys by bare name instead of composer identityapp-shell'sMetadataProvider.mergeViewsIntoObjects(the live copy, used atMetadataProvider.tsx:697) is untouchedpackages/data-objectstack/src/index.ts— the fivemetadataCache.invalidate?.(views:${objectName})sites (:3022,:3183,:3243,:3274,:3291)listViewsnever routes throughmetadataCache.getwith aviews:key — verified this round; note the card says 4 sites, main now has 5)listViewsbehavior unchanged (it is genuinely uncached — if caching is ever wanted, that is a new card, not this sweep)packages/permissions/src—RoleDefinition.permissions(required field)resolveRolesand every other consumer read onlyname/inherits(sole non-test hit is a test-comment documenting the state)Sweep discipline (binding, per the pm-dispatch sweep rules):
git diff --statmust map 1:1 to the rows (plus changeset).Fixes #3775,Fixes #3778,Fixes #4288, andFixesthis card.Member #3773 (
RecordContextValue.loading/error) was considered and excluded: the premise has drifted — the context's memo now dep-lists both fields and the provider signature spreads all values, so zero-producer/zero-consumer needs re-measurement against current hosts before deletion is safe.