From 3bfcecd2728ef208d3cf851a2cd81250bd9f320f Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 6 Aug 2026 07:30:35 +0000 Subject: [PATCH] chore(qa,objectql): drop dogfood's unconsumed driver-memory devDep + de-reference driver-memory in one stub comment (#5829) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #5704 收口尾单(批次 2/3 已合入 PR #5797/#5806),两件留档尾项: 1. `packages/qa/dogfood` 的 `@objectstack/driver-memory` devDep：#5715(批次 0) 把 read-coercion 一致性测试的 memory 臂移除后，全包已零真实 import (`git grep -in memory -- packages/qa/dogfood` 只剩 README 的 "in-memory SQLite" 散文与 read-coercion-conformance.test.ts:9 记录移除原因的 注释)。摘除声明 + lockfile 随动(仅该一条 importer 链接)。 2. `protocol-batch-atomic.test.ts` 的 `makeSnapshotDriver()` 头注释把这个本地 手写 stub 说成「the same shape driver-memory uses」——packages/objectql 根本 不依赖 driver-memory，这类措辞正是 #5704 Phase 1 survey 里让 `grep -i memory` 虚高的来源。按 #5797 同款原则改写为指涉 stub 自身。 `protocol-data.test.ts:759` 经复核**原样保留**：那一句 「Mirror of #3948's rule for driver-memory: an unapplied filter must not look like a satisfied one」指的是真实 driver-memory 包里真实存在的不变量 (`filter-refusal.ts`、`memory-driver.ts:753/792/817`、 `memory-filter-ast-vocabulary.test.ts`)，属于 #5797 已开的例外类 (描述真实驱动族行为的散文一律保留)，不是把 stub 说成 driver-memory。 零行为变更。 Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01WyvqvKMG6asi9aXjKE6xtx --- packages/objectql/src/protocol-batch-atomic.test.ts | 6 +++--- packages/qa/dogfood/package.json | 1 - pnpm-lock.yaml | 3 --- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/objectql/src/protocol-batch-atomic.test.ts b/packages/objectql/src/protocol-batch-atomic.test.ts index 065a7b544d..a1d1cc83a3 100644 --- a/packages/objectql/src/protocol-batch-atomic.test.ts +++ b/packages/objectql/src/protocol-batch-atomic.test.ts @@ -18,9 +18,9 @@ import { ObjectStackProtocolImplementation } from '@objectstack/metadata-protoco import type { IObjectQLEngine } from '@objectstack/spec/contracts'; /** - * A driver with real transaction semantics: `beginTransaction` snapshots every - * table, `rollback` restores the snapshot wholesale, `commit` drops it — the - * same shape `driver-memory` uses, small enough to assert against. + * A stub driver with real transaction semantics: `beginTransaction` snapshots + * every table, `rollback` restores the snapshot wholesale, `commit` drops it — + * a genuine rollback, small enough to assert against. */ function makeSnapshotDriver() { const stores = new Map>(); diff --git a/packages/qa/dogfood/package.json b/packages/qa/dogfood/package.json index 8cc14fe640..46b4abf781 100644 --- a/packages/qa/dogfood/package.json +++ b/packages/qa/dogfood/package.json @@ -34,7 +34,6 @@ }, "devDependencies": { "@objectstack/core": "workspace:*", - "@objectstack/driver-memory": "workspace:*", "@objectstack/driver-sql": "workspace:*", "@objectstack/driver-sqlite-wasm": "workspace:*", "@types/node": "^26.1.2", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 59e27c176d..704817cf83 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1786,9 +1786,6 @@ importers: '@objectstack/core': specifier: workspace:* version: link:../../core - '@objectstack/driver-memory': - specifier: workspace:* - version: link:../../drivers/driver-memory '@objectstack/driver-sql': specifier: workspace:* version: link:../../drivers/driver-sql