Skip to content

Commit fb09f70

Browse files
committed
refactor(metadata-protocol): carry the import-attached comments and doc-link imports the preamble move dropped
The move kept protocol.ts's imports by the identifiers its code uses, so three comments attached to imports it dropped or moved went nowhere, and seven import names that only the class's {@link} doc references use were removed. Restored, each at its base place: - the [#19295] block above `markErasedAuthoringInput`'s import, now in protocol-meta-type-schema.ts; - the [#21207] inline note with `ephemeralStoredHashDigest` in the metadata-redaction import; - the [#5488] note after the reference-sites import, where it stood; - SDUI_MANIFEST_SERVICE, backfillOverlayBundleMembers, unboundItemDraftAddress, resolveItemLockLazily, REFERENCE_VALUE_TYPES, externalBindingDatasourceRefusal and ephemeralStoredHashDigest back in protocol.ts's import lists. Comments and import lists only. The published index.d.ts is byte-identical to the previous head's. Claude-Session: https://claude.ai/code/session_01ADHkmR4MjTzeUv5x6tNkbk Co-authored-by: Claude <noreply@anthropic.com>
1 parent 20d8c2c commit fb09f70

2 files changed

Lines changed: 23 additions & 0 deletions

File tree

‎packages/metadata-protocol/src/protocol-meta-type-schema.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@
1212
// `{ not: {} }` — is dropped from it. See the module header for the channels
1313
// that keep carrying the retirement's prescription.
1414
import { stripUnauthorableProperties } from './unauthorable-nodes.js';
15+
// [#19295] The output derivation of a `ZodPipe` erases the arm's own input
16+
// type, so an authoring arm that accepts a bare string is served as the
17+
// anonymous `{}`. This annotates that husk — and only that husk — so a
18+
// consumer can tell an ERASED authoring type from a member that genuinely
19+
// admits anything. See the module header for the predicate and its controls.
1520
import { markErasedAuthoringInput } from './erased-authoring-mark.js';
1621
import {
1722
applyAuditFieldGovernance,

‎packages/metadata-protocol/src/protocol.ts‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@ import type { MetadataHostEngine } from './host-engine.js';
1616
import { omitInternalFieldsFromWriteResponse } from './write-response-internal-fields.js';
1717
import { staleSummaryRefusalOrThrow, withEarnedAnswer, type SummaryRecomputeRefusal } from '@objectstack/types';
1818
import {
19+
SDUI_MANIFEST_SERVICE,
1920
stampHtmlPageRequires,
2021
type RuntimePendingDeclarations,
2122
} from './runtime-authoring-gate.js';
2223
import type { RuntimeAuthoringIssue } from './runtime-authoring-gate.js';
2324
// [#6418] `sys_metadata`'s overlay-uniqueness indexes: probe-first DDL plus the
2425
// ADR-0120 D4 reporting that replaced this file's empty `catch` blocks.
2526
import {
27+
backfillOverlayBundleMembers,
2628
overlayMemberWhere,
2729
} from './migrations/overlay-index.js';
2830
import {
@@ -33,12 +35,14 @@ import {
3335
packageScopedRowWhere,
3436
packagelessAddressAmbiguityRefusal,
3537
resetEnvWritableMetadataTypes,
38+
unboundItemDraftAddress,
3639
versionNotFoundError,
3740
type SysMetadataEngine,
3841
} from './sys-metadata-repository.js';
3942
import { managedItemSealedSentence, packagedBaseRegimeRow, packagedBaseRegimeSentence } from './packaged-base-regime.js';
4043
import {
4144
resolveItemLock,
45+
resolveItemLockLazily,
4246
resolveOverlayLockLayer,
4347
storedRowDocument,
4448
withItemLockFamily,
@@ -115,13 +119,15 @@ import { authoringClientOf, storedDraftChanges } from './draft-changes.js';
115119
import {
116120
parseFilterAST,
117121
isFilterAST,
122+
REFERENCE_VALUE_TYPES,
118123
foldQueryAliasSlots,
119124
QUERY_TRANSPORT_ALIAS_SLOTS,
120125
QUERY_TRANSPORT_DOLLAR_ALIASES,
121126
QUERY_TRANSPORT_DOLLAR_PARAMS,
122127
type DroppedFieldsEvent,
123128
type EngineQueryOptionsParsed,
124129
type ValidationAdvisoryEvent,
130+
externalBindingDatasourceRefusal,
125131
} from '@objectstack/spec/data';
126132
import { PLURAL_TO_SINGULAR, SINGULAR_TO_PLURAL, unrecognisedMetaTypeRefusal } from '@objectstack/spec/shared';
127133
// [#13331] The cluster fan-out transport type only — the protocol never
@@ -180,6 +186,15 @@ import {
180186
import { ManifestSchema, manifestIdRefusal } from '@objectstack/spec/kernel';
181187
import { stripReadDecorations } from '@objectstack/spec/kernel';
182188
import { REFERENCE_SITES } from './reference-sites.js';
189+
// [#5488] The `@objectstack/spec/api` import that stood here — `ApiEndpointSchema`,
190+
// `validateApiEndpointDeclarations`, `type ApiEndpoint` — went with
191+
// `gateApiDraftsForPublish` (see its retirement note in `publishPackageDrafts`).
192+
// This module no longer judges endpoints at all: `api` is code-only since #5488,
193+
// so no `api` draft can be authored here, and the ONE judge of what is servable
194+
// stays `validateApiEndpointDeclarations` on the artifact route (stack schema,
195+
// `publishPackage` #5189, and `buildEndpointIndex` at load, PR #5203). An
196+
// endpoint-shaped import left behind with no caller reads as a capability this
197+
// module still has (#3950), so it is removed rather than parked.
183198
import {
184199
computeMetadataDiagnostics,
185200
computeViewReferenceDiagnostics,
@@ -204,6 +219,9 @@ import {
204219
storedMetadataBodyGroupingRefusal,
205220
storedMetadataBodyPredicateRefusal,
206221
storedMetadataBodyProjection,
222+
// [#21207] The stored content hash of the same rows: served keyed, never
223+
// evaluated — see `STORED_METADATA_HASH_COLUMNS`.
224+
ephemeralStoredHashDigest,
207225
servedContentHash,
208226
serveStoredHashTokens,
209227
serveStoredMetadataHashColumnRows,

0 commit comments

Comments
 (0)