Skip to content

Commit ce15dc3

Browse files
os-helpclaude
andauthored
fix(service-automation): align notify node form-descriptor strings with #7085 vocabulary (#7202)
The notify node's hand-written configSchema (Studio form descriptor) still said "Requires sourceId." / "Requires sourceObject." — the same phantom requirement PR #7111 removed from NotifyConfigSchema's .describe() strings. The schema deliberately accepts a half-specified pair; the executor drops it at execute time so the inbox never renders a dead link. Mirror the settled wording onto the form-descriptor face, string-only (no key/type/required change). Fixes #7112 Claude-Session: https://claude.ai/code/session_015fkdTyGmMD5s8ZtEifvuGy Co-authored-by: Claude <noreply@anthropic.com>
1 parent 3566e55 commit ce15dc3

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@objectstack/service-automation': patch
3+
---
4+
5+
Align the `notify` node's Studio form-descriptor strings with the schema's actual acceptance behaviour (docs-only; no acceptance or `configSchema` key/type/required change):
6+
7+
- `sourceObject` / `sourceId` no longer say "Requires sourceId." / "Requires sourceObject.". Both are optional and the executor drops a half-specified click-through target at execute time (so the inbox never renders a dead link) — the descriptions now state that tolerance instead of a phantom requirement, mirroring the `NotifyConfigSchema.sourceObject`/`sourceId` `.describe()` wording fixed in #7085 (PR #7111). (#7112)

packages/services/service-automation/src/builtin/notify-node.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,11 @@ export function registerNotifyNode(engine: AutomationEngine, ctx: PluginContext)
163163
// ── Click-through target (#2675) ─────────────────────────
164164
sourceObject: {
165165
type: 'string',
166-
description: 'Object name of the record the notification links to (writes sys_notification.source_object). Requires sourceId.',
166+
description: 'Object name of the record the notification links to (writes sys_notification.source_object). Only takes effect together with sourceId — a half-specified click-through target is dropped at execute time, so the inbox never renders a dead link.',
167167
},
168168
sourceId: {
169169
type: 'string',
170-
description: 'Record id the notification links to (writes sys_notification.source_id). Requires sourceObject. The inbox synthesizes a `/{object}/{id}` deep-link from these.',
170+
description: 'Record id the notification links to (writes sys_notification.source_id). Only takes effect together with sourceObject — a half-specified click-through target is dropped at execute time, so the inbox never renders a dead link. The inbox synthesizes a `/{object}/{id}` deep-link from these.',
171171
},
172172
actorId: {
173173
type: 'string',

0 commit comments

Comments
 (0)