Skip to content

Commit bfca84c

Browse files
claudeclaude
committed
fix(studio): name the customization marks' base placeholder baseName, outside the zh base-term census
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QsR2jSKpVAotd33JtFuXkP
1 parent f42f397 commit bfca84c

5 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎ui/packages/app-shell/src/views/metadata-admin/DirectoryPage.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ export function MetadataDirectoryPage() {
263263
<p className="text-sm text-muted-foreground mt-1" data-testid="directory-customizations-total">
264264
{tFormat('engine.directory.customizations.total', locale, {
265265
customized: customizationTotal(customizations.read),
266-
base: customizations.baseName,
266+
baseName: customizations.baseName,
267267
})}
268268
</p>
269269
)}

‎ui/packages/app-shell/src/views/metadata-admin/metadataAreaHost.customizations-28568.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ describe('the All metadata lists mark a base\'s customizations (objectstack#2856
185185
it('the translation list marks the served override "Customized (HotCRM)", and the filter shows it alone', async () => {
186186
mountList(area(BASE), 'translation', `?package=${BASE}`);
187187
const only = await screen.findByTestId('metadata-only-customizations');
188-
expect(marksOf('crm_en')).toEqual([`customized:${tFormat('engine.customizationMark.customized', 'en-US', { base: 'HotCRM' })}`]);
188+
expect(marksOf('crm_en')).toEqual([`customized:${tFormat('engine.customizationMark.customized', 'en-US', { baseName: 'HotCRM' })}`]);
189189
expect(marksOf('crm_en')).toEqual(['customized:Customized (HotCRM)']);
190190
// CONTROL: the base's item the read does not list carries no mark.
191191
expect(marksOf('crm_de')).toEqual([]);
@@ -240,7 +240,7 @@ describe('the All metadata lists mark a base\'s customizations (objectstack#2856
240240
mountList(area(null), 'permission', '?scope=environment');
241241
await screen.findByTestId('metadata-row-crm_rep_plus');
242242
expect(marksOf('crm_rep_plus')).toEqual([
243-
`customizationOf:${tFormat('engine.customizationMark.customizationOf', 'en-US', { base: BASE })}`,
243+
`customizationOf:${tFormat('engine.customizationMark.customizationOf', 'en-US', { baseName: BASE })}`,
244244
]);
245245
// CONTROL: the base's own item names no base.
246246
expect(marksOf('crm_rep')).toEqual([]);
@@ -253,7 +253,7 @@ describe('the All metadata directory counts a base\'s customizations (objectstac
253253
mountDirectory(area(BASE));
254254
const total = await screen.findByTestId('directory-customizations-total');
255255
expect(total).toHaveTextContent(
256-
tFormat('engine.directory.customizations.total', 'en-US', { customized: 3, base: 'HotCRM' }),
256+
tFormat('engine.directory.customizations.total', 'en-US', { customized: 3, baseName: 'HotCRM' }),
257257
);
258258
expect(screen.getByTestId('directory-tile-customized-object')).toHaveTextContent(
259259
tFormat('engine.directory.customizations.tile', 'en-US', { customized: 1 }),

‎ui/packages/app-shell/src/views/studio-design/CustomizationMark.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ export function CustomizationMark({
5454
const label =
5555
kind === 'added'
5656
? t('engine.customizationMark.added', locale)
57-
: tFormat(`engine.customizationMark.${kind}`, locale, { base });
57+
: tFormat(`engine.customizationMark.${kind}`, locale, { baseName: base });
5858
const title = pairId
59-
? tFormat(`engine.customizationMark.${kind}Title`, locale, { base, pair: pairId })
59+
? tFormat(`engine.customizationMark.${kind}Title`, locale, { baseName: base, pair: pairId })
6060
: undefined;
6161
return (
6262
<span

‎ui/packages/i18n/src/namespaces/studio/en.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3499,14 +3499,14 @@ const STUDIO_EN: Record<string, string> = {
34993499
'engine.directory.itemCountTooltip': '{count} item(s) of this type',
35003500
// objectstack ADR-0146 D3 (#28568) — the customization marks, counts and
35013501
// filter of the All metadata area, from a base's customization read.
3502-
'engine.customizationMark.customized': 'Customized ({base})',
3503-
'engine.customizationMark.customizedTitle': 'The customization package {pair} overrides this item of {base}',
3502+
'engine.customizationMark.customized': 'Customized ({baseName})',
3503+
'engine.customizationMark.customizedTitle': 'The customization package {pair} overrides this item of {baseName}',
35043504
'engine.customizationMark.added': 'Added',
3505-
'engine.customizationMark.addedTitle': 'Added to {base} by its customization package {pair}',
3506-
'engine.customizationMark.customizationOf': 'Customization of {base}',
3507-
'engine.customizationMark.customizationOfTitle': 'An item of {pair}, the customization package of {base}',
3505+
'engine.customizationMark.addedTitle': 'Added to {baseName} by its customization package {pair}',
3506+
'engine.customizationMark.customizationOf': 'Customization of {baseName}',
3507+
'engine.customizationMark.customizationOfTitle': 'An item of {pair}, the customization package of {baseName}',
35083508
'engine.customizationMark.readFailed': 'Couldn’t read customizations: {message}',
3509-
'engine.directory.customizations.total': '{customized} customized on {base}',
3509+
'engine.directory.customizations.total': '{customized} customized on {baseName}',
35103510
'engine.directory.customizations.tile': '{customized} customized',
35113511
'engine.directory.customizations.tileTitle': 'Customized items of this type: {customized}',
35123512
'engine.list.customizations.only': 'Only customizations ({marked})',

‎ui/packages/i18n/src/namespaces/studio/zh.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3114,14 +3114,14 @@ const STUDIO_ZH: Record<string, string> = {
31143114
'engine.directory.itemCountTooltip': '此类型共 {count} 项',
31153115
// objectstack ADR-0146 D3 (#28568) — the customization marks, counts and
31163116
// filter of the All metadata area, from a base's customization read.
3117-
'engine.customizationMark.customized': '已定制（{base}）',
3118-
'engine.customizationMark.customizedTitle': '定制包 {pair} 覆盖了 {base} 的此项',
3117+
'engine.customizationMark.customized': '已定制（{baseName}）',
3118+
'engine.customizationMark.customizedTitle': '定制包 {pair} 覆盖了 {baseName} 的此项',
31193119
'engine.customizationMark.added': '新增',
3120-
'engine.customizationMark.addedTitle': '由 {base} 的定制包 {pair} 新增',
3121-
'engine.customizationMark.customizationOf': '{base} 的定制',
3122-
'engine.customizationMark.customizationOfTitle': '{pair} 中的项，即 {base} 的定制包',
3120+
'engine.customizationMark.addedTitle': '由 {baseName} 的定制包 {pair} 新增',
3121+
'engine.customizationMark.customizationOf': '{baseName} 的定制',
3122+
'engine.customizationMark.customizationOfTitle': '{pair} 中的项，即 {baseName} 的定制包',
31233123
'engine.customizationMark.readFailed': '无法读取定制：{message}',
3124-
'engine.directory.customizations.total': '{base} 已定制 {customized} 项',
3124+
'engine.directory.customizations.total': '{baseName} 已定制 {customized} 项',
31253125
'engine.directory.customizations.tile': '已定制 {customized}',
31263126
'engine.directory.customizations.tileTitle': '此类型已定制的项：{customized}',
31273127
'engine.list.customizations.only': '仅看定制（{marked}）',

0 commit comments

Comments
 (0)