Commit b78016f
The TSDoc above RecalcSelectionAction narrated the pre-objectui#3142 rule as
current fact: that a missing/empty `locations` is treated as "every location"
by the action:bar renderer, so declaring `record_more` was an opt-out that kept
the action off the list toolbar.
objectui#3142 inverted that. It collapsed four disagreeing renderers onto one
membership predicate (`actionRendersAt`), so an undeclared or empty `locations`
now matches NO location. `packages/lint/src/validate-action-locations.ts`'s
docblock states the current rule, and the whole `action-no-placement` warning
exists because of it -- the lint package and this comment said opposite things
about the same behavior.
The declaration itself is correct either way and is unchanged: `record_more` is
an explicit single-record placement (the endpoint's per-record branch, via
`recordIdParam`), which incidentally also keeps the action off the toolbar --
not an opt-out of an everywhere-default. Comment lines only; the code is
byte-identical after stripping comments.
Claude-Session: https://claude.ai/code/session_01GZKbx4xyF7U5WXj6ch49BM
Co-authored-by: Claude <noreply@anthropic.com>
1 parent b03b0e1 commit b78016f
1 file changed
Lines changed: 19 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
149 | 160 | | |
150 | 161 | | |
151 | 162 | | |
| |||
0 commit comments