Commit 48ca87a
committed
fix(service-automation): stop splicing uncontrolled thrown text into engine.ts log messages (13 residual seams + 1 self-authored), re-grade run-history persist to error (#6499)
The 13 seams #6499 lists — datasource (persistSuspendedRun, listRuns, getRun,
recordLog), plugin-supplied (releaseSuspension, unregisterTrigger,
activateFlowTrigger, deactivateFlowTrigger), and engine-internal
(resolveRunContext, expandDeclaredLookups, refuseInvalidScreenInput,
bubbleToParent x2) — now log a single-line consequence-stating message and
hand the cause to the logger's structured slot (describeThrownForLog), the
#6299 / PR #6498 pattern. The 14th site (validateFlowExpressions' advisory
pass) had the opposite cause — a self-authored newline — and gets the same
shape: message one line, the author's expression source in the meta slot.
Per-site #4632 verdicts (each pinned by test, since check:durability-log-level
grades none of these): recordTerminal's fire-and-forget catch is RAISED
warn -> error (terminal history row failed to land while the run reads healthy;
the approvals sweeps then misread the hole); persistSuspendedRun stays error
(#4460); all other sites stay warn (functional degradations that claim no
persistence).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01USNUyHEr7uaU6MoEWXitei1 parent 4afdd3e commit 48ca87a
5 files changed
Lines changed: 900 additions & 30 deletions
File tree
- .changeset
- packages/services/service-automation/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
0 commit comments