Skip to content

Commit 1007379

Browse files
os-zhuangclaude
andauthored
docs(spec): close stale $contains fold pointers for driver-memory (#7854) (#7890)
#7723 took the `i` flag off driver-memory's filterSubstringPattern, closing #6682. Two packages/spec docblocks still pointed forward at that landing as a future event: - filter.zod.ts's per-backend history table (kept as history per #7625) had a driver-memory cell reading "the last one standing, until #6682" -- accurate as history, but the "until #6682" tail described a future that has since landed. Closed in past tense without flattening the historical framing; the table's other rows (including driver-mongodb's pre-#7625 mechanism) are untouched. - filter-text-conformance.ts's @see #6682 line read "mongodb landed, memory open", contradicting the file's own header 37 lines earlier (already correct since #7723). Now reads "mongodb and memory both landed". Fixes #7854 Claude-Session: https://claude.ai/code/session_016YBUGvukaeVu9DjKdsHJa9 Co-authored-by: Claude <noreply@anthropic.com>
1 parent f690747 commit 1007379

3 files changed

Lines changed: 31 additions & 2 deletions

File tree

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
---
2+
"@objectstack/spec": patch
3+
---
4+
5+
docs(spec): close the stale `$contains` fold pointers in the `filter.zod.ts` per-backend history table and the `filter-text-conformance.ts` `@see` line
6+
7+
#7723 took the `i` flag off `driver-memory`'s `filterSubstringPattern`, closing
8+
the #6682 tracking issue. Two docblock spots in `packages/spec` still pointed
9+
forward at that landing as if it hadn't happened yet:
10+
11+
- `filter.zod.ts`'s per-backend history table (explicitly headed "measured …
12+
BEFORE the ruling" — kept as history per #7625) had a `driver-memory` cell
13+
reading "the last one standing, until #6682". The cell is historically
14+
accurate (it WAS the last case-folding face when written) but the "until
15+
#6682" tail described a future event that has since landed; it now reads
16+
"the last one standing; #6682 closed it (see 'Implementation status'
17+
below)". The table's other rows, including `driver-mongodb`'s, are left
18+
untouched — they are correct as pre-ruling history and #7625 already judged
19+
them that way.
20+
- `filter-text-conformance.ts`'s `@see #6682` line read "mongodb landed,
21+
memory open", contradicting the same file's own header 37 lines earlier
22+
(updated correctly by #7723), which already says the memory half landed
23+
too. It now reads "mongodb and memory both landed".
24+
25+
No behavior, schema, or generated baseline changes — these are TSDoc comments
26+
attached to exported schemas, which do reach `@objectstack/spec`'s published
27+
`dist/*.d.ts` (verified: `grep` on the rebuilt dist shows the edited sentence
28+
in `dist/filter.zod-*.d.ts`), so this ships as a patch changeset rather than
29+
`skip-changeset`.

packages/spec/src/data/filter-text-conformance.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
* @see https://github.com/objectstack-ai/objectstack/issues/5701 (this table)
9393
* @see https://github.com/objectstack-ai/objectstack/issues/5702 (the SQL family — landed)
9494
* @see https://github.com/objectstack-ai/objectstack/issues/6520 ($icontains on the JS faces — landed)
95-
* @see https://github.com/objectstack-ai/objectstack/issues/6682 (the $contains family — mongodb landed, memory open)
95+
* @see https://github.com/objectstack-ai/objectstack/issues/6682 (the $contains family — mongodb and memory both landed)
9696
*/
9797

9898
import type { FilterCondition } from './filter.zod';

packages/spec/src/data/filter.zod.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ export const RangeOperatorSchema = lazySchema(() => z.object({
518518
* | surface | `$contains` case behaviour | mechanism |
519519
* |---|---|---|
520520
* | `formula` `matchesFilterCondition` | SENSITIVE | `actual.includes(v)` |
521-
* | `driver-memory` — query path and analytics face | INSENSITIVE, full Unicode | `new RegExp(escapeRegex(v), 'i')` — the last one standing, until #6682 |
521+
* | `driver-memory` — query path and analytics face | INSENSITIVE, full Unicode | `new RegExp(escapeRegex(v), 'i')` — the last one standing; #6682 closed it (see "Implementation status" below) |
522522
* | `driver-memory` — reference matcher (`memory-matcher`) | SENSITIVE | `value.includes(target)` |
523523
* | `driver-mongodb` | INSENSITIVE, full Unicode | hardcoded `$options: 'i'` |
524524
* | `driver-sql` family | the DIALECT's | `LIKE '%v%'` — ASCII-insensitive on SQLite (so also turso and sqlite-wasm), sensitive on Postgres, collation-dependent on MySQL |

0 commit comments

Comments
 (0)