fix(release): stop fixed-group major cascade from internal peerDependencies#1524
Merged
Merged
Conversation
…encies Internal @objectstack/* peerDependencies on packages in the changesets `fixed` group caused every minor changeset to escalate the whole 69-package group to a major (8.0.0): in a fixed group changesets rewrites peer ranges each release and treats a peer-range change as breaking. Required internal peers → dependencies; optional internal peers → devDependencies (still available for workspace tests, no longer a published peer edge). Verified: `changeset status` drops from 69 major (8.0.0) to 0 major (next release is correctly 7.6.0). Affected: cli, express, sveltekit, hono, nuxt, nextjs, nestjs, fastify, plugin-msw (peer→dep); plugin-dev, service-datasource, service-ai (optional peer→devDep). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
xuyushun441-sys
added a commit
that referenced
this pull request
Jun 2, 2026
…n from #1524) (#1525) #1524 moved optional internal @objectstack peerDependencies off `peer`; tsup then bundled the lazily await-import()'d driver packages and hit their optional native deps (mysql/oracledb via knex) → build failure for service-datasource & plugin-dev. - service-datasource: tsup `external: [/^@objectstack\/driver-/]` (drivers stay devDeps for tests, never bundled). - plugin-dev: framework packages devDeps → dependencies (tsup auto-externalizes deps; dev-only plugin, force-install is fine). Verified: full `pnpm build` 71/71 green; `changeset status` still 0 major (7.6.0). Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the fixed-group major cascade: every minor changeset was escalating the whole 69-package suite to 8.0.0 instead of 7.6.0.
Root cause (verified)
Several packages in the changesets
fixedgroup declared internal@objectstack/*peerDependencies (adapters→runtime,cli→core,plugin-msw→runtime; optional:plugin-dev,service-datasource,service-ai). Inside afixedgroup, changesets rewrites those peer ranges on every release and treats a peer-range change as breaking → major, which cascades to all 69 packages.onlyUpdatePeerDependentsWhenOutOfRangedoes not prevent this within a fixed group.Proven by bisection: removing any one changeset still left 69-major; a lone minor on a peer-free package (
observability) still produced 8.0.0; and converting the internal peers dropped it to 0 major.Fix
dependencies(they're lockstep-versioned anyway).devDependencies(still available for in-workspace tests; no longer a published peer edge that cascades).Verification
changeset statusbefore: 69 packages → major (8.0.0). After: 0 major, next release bumps correctly (patch/minor → 7.6.0).pnpm installclean (no cycles).Unrelated to ADR-0032 — pre-existing release-config debt that any minor changeset triggered.
🤖 Generated with Claude Code