fix: consistency audit — feature_name convention, git:dev references, stale exits, agent ownership#167
Merged
Merged
Conversation
nullhack
force-pushed
the
fix/consistency-audit-may19
branch
from
027ee94 to
c8a0b66
Compare
…, stale exits, agent ownership, beehave status gates, 7-principle review - Rename feature_id → feature_title everywhere: flow YAMLs, skills, knowledge, AGENTS.md, CHANGELOG.md, templates - Bump flowr 1.0.0 → 1.1.0 (pyproject.toml, uv.lock) - review-gate: split step 5 into 7 sub-steps (YAGNI, KISS, DRY, ObjCal, Smells, SOLID, Patterns) matching tdd-cycle exit conditions - verify-traceability: make beehave status --json mandatory gate (stage ok → skip beehave check) - review-gate tier 2: add beehave status --json as pre-check before beehave check - refactor: add explicit knowledge references for all 7 design principles - SE agent: ownership/noqa/pyproject identity statement - implement-minimum: fix existing test/beehave failures in touched files - polish-code: fix all violations codebase-wide - write-test: anti-noise rules for Spec Value Fidelity - Flow YAML: remove unreachable exits (cancelled, needs-reinterview), add params to define-flow - Templates: new test stub template, rename feature_name → feature_title - Remove stale @id references from AGENTS.md, README.md, docs/audit/
nullhack
force-pushed
the
fix/consistency-audit-may19
branch
from
c8a0b66 to
b462686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full consistency audit fixes across AGENTS.md, flow definitions, skills, knowledge, and templates.
Changes
Convention fixes
feature_id→feature_name: Unified across 5 flow files, 3 skill files, 2 knowledge files. Matches the template filename convention.main→dev: Fixed stale branch references in AGENTS.md (lines 89, 147, 205) — all flows use onlygit: devandgit: feature.planning-flow→define-flow: Fixed stale example in AGENTS.md (line 99).Flow YAML fixes
params: [feature_name]todefine-flow.yamlcancelledexit fromdevelop-flow.yamlneeds-reinterviewexit fromdefine-flow.yaml(handled internally via subflow routing)Agent/Knowledge ownership
noqa, neverpyproject.tomlimplement-minimumskill: fix existing test/beehave failures in touched filespolish-codeskill: fix all violations codebase-widewrite-testskill: explicit anti-noise rules (no assertions/setup/teardown unrelated to Example intent)setup-applyskill: added missingAvailable knowledgelineTemplates
.templates/tests/features/<rule_slug>_test.py.template.templates/.cache/interview-notes/,sim/,acceptance/) — on disk only (gitignore excludes.cache/)<feature_id>variant from acceptance template directoryStale @id cleanup