From 6491f807a4db8b4ec4ea16abe3dadd1e9789e49b Mon Sep 17 00:00:00 2001 From: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> Date: Mon, 9 Feb 2026 19:08:24 +0100 Subject: [PATCH 1/2] doc(minutes): add 09 Feb 2026 --- .../2026-02-09 test-runner meeting minutes.md | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 minutes/2026-02-09 test-runner meeting minutes.md diff --git a/minutes/2026-02-09 test-runner meeting minutes.md b/minutes/2026-02-09 test-runner meeting minutes.md new file mode 100644 index 0000000..bb390a1 --- /dev/null +++ b/minutes/2026-02-09 test-runner meeting minutes.md @@ -0,0 +1,36 @@ +# 09 February 2026 + +## Attendees + +* Alex Vespa [@vespa7](https://github.com/vespa7) +* Ethan Arrowood [@Ethan-Arrowood](https://github.com/Ethan-Arrowood) +* Jacob Smith [@JakobJingleheimer](https://github.com/JakobJingleheimer) (chair) +* Jordan Harband [@ljharb](https://github.com/ljharb) +* Pietro Marchini [@pmarchini](https://github.com/pmarchini) + +## Topics + +* `t.skip()` Others (tape, etc) to not behave like this. +* standardising test runner design + * https://github.com/WinterTC55/proposal-minimum-common-api/issues/32 + * https://github.com/WinterTC55/proposal-minimum-common-api/issues/68 +* [doc(proposal): `expectFailure` label and/or matcher](https://github.com/nodejs/test-runner/pull/10) +* [doc(proposal): un/break `--test`](https://github.com/nodejs/test-runner/pull/13) + +## Outcomes + +* General agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support). +* General agreement that it would be good to standardise node's test-runner at the WinterTC55 level, if we can, but might be a very uphill battle. Perhaps better to audit our and others' design and adjust (and then take that to WinterTC). +* https://github.com/nodejs/test-runner/pull/10 ready to approve +* Un/break `--test` + * option 3 + * leave `--watch` as-is + * in `test` mode, its value (`--watch` only enables watch mode) + * support `--watch-path` in test mode + * only `--test` N-times 1-to-1 with arg list, making it position-independent + +## Todos + +* Decide if fixing `t.skip()` is a breaking change. +* Jordan to find & share his audit of test runner features to use as base-point. +* Jacob to incorporate "option 3" to https://github.com/nodejs/test-runner/pull/13 and tag team for review. From c4143fcc7717223230020b3fb3fa36233468ac8d Mon Sep 17 00:00:00 2001 From: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com> Date: Mon, 23 Feb 2026 22:50:18 +0100 Subject: [PATCH 2/2] fixup!: clarify topic and correct/update discussion summary --- minutes/2026-02-09 test-runner meeting minutes.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/minutes/2026-02-09 test-runner meeting minutes.md b/minutes/2026-02-09 test-runner meeting minutes.md index bb390a1..2941e9b 100644 --- a/minutes/2026-02-09 test-runner meeting minutes.md +++ b/minutes/2026-02-09 test-runner meeting minutes.md @@ -10,7 +10,9 @@ ## Topics -* `t.skip()` Others (tape, etc) to not behave like this. +* test_runner: run afterEach for runtime t.skip() [nodejs/node#61525](https://github.com/nodejs/node/pull/61525) + * concern: `testCtx.skip` skips the test from which it is invoked dynamically, while `test.skip` creates a skipped test (test with option skip: true) + * concern that this is uncommon (tape etc to not behave like this). * standardising test runner design * https://github.com/WinterTC55/proposal-minimum-common-api/issues/32 * https://github.com/WinterTC55/proposal-minimum-common-api/issues/68 @@ -19,7 +21,10 @@ ## Outcomes -* General agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support). +* ~Initially general agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support).~ + * Further investigation found this behaviour + * exists in others (including [mocha](https://mochajs.org/declaring/inclusive-tests/#_top)) + * was intended: https://nodejs.org/docs/v24.13.0/api/test.html#contextskipmessage * General agreement that it would be good to standardise node's test-runner at the WinterTC55 level, if we can, but might be a very uphill battle. Perhaps better to audit our and others' design and adjust (and then take that to WinterTC). * https://github.com/nodejs/test-runner/pull/10 ready to approve * Un/break `--test` @@ -31,6 +36,6 @@ ## Todos -* Decide if fixing `t.skip()` is a breaking change. +* Finish discussion of `t.skip()`. * Jordan to find & share his audit of test runner features to use as base-point. * Jacob to incorporate "option 3" to https://github.com/nodejs/test-runner/pull/13 and tag team for review.