From 2fe4eb2534e7598a43a9b3621308f0238803565f Mon Sep 17 00:00:00 2001
From: Filip Skokan <panva.ip@gmail.com>
Date: Sun, 13 Sep 2026 20:51:05 +0200
Subject: [PATCH] test: prevent parser reuse across close scenarios

Both cases replace parser cleanup methods. Faster socket cleanup can
return a modified parser to the shared pool and close it before the
other request uses it.

Run the immediate and deferred close cases in separate test files so
each gets its own process and parser pool. Preserve both cleanup paths
and all call-count assertions.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
---
 ...ver-connection-list-when-close-deferred.js | 35 ++++++++++++++++
 ...-http-server-connection-list-when-close.js | 42 +++++--------------
 2 files changed, 45 insertions(+), 32 deletions(-)
 create mode 100644 test/parallel/test-http-server-connection-list-when-close-deferred.js

diff --git a/test/parallel/test-http-server-connection-list-when-close-deferred.js b/test/parallel/test-http-server-connection-list-when-close-deferred.js
new file mode 100644
index 00000000000..af87e356161
--- /dev/null
+++ b/test/parallel/test-http-server-connection-list-when-close-deferred.js
@@ -0,0 +1,35 @@
+'use strict';
+
+const common = require('../common');
+const http = require('http');
+
+// Keep this case in a separate process from the immediate-close case so
+// their modified parsers cannot be reused across cases.
+
+function request(server) {
+  http.get({
+    agent: false,
+    port: server.address().port,
+    path: '/',
+  }, (res) => {
+    res.resume();
+  });
+}
+
+const server = http.createServer(common.mustCallAtLeast((req, res) => {
+  // See `freeParser` in _http_common.js
+  const { parser } = req.socket;
+  parser.free = common.mustCall(() => {
+    setImmediate(common.mustCall(() => {
+      parser.close();
+    }));
+  });
+  req.socket.on('close', common.mustCall(() => {
+    setImmediate(common.mustCall(() => {
+      server.close();
+    }));
+  }));
+  res.end('ok');
+})).listen(0, common.mustCall(() => {
+  request(server);
+}));
diff --git a/test/parallel/test-http-server-connection-list-when-close.js b/test/parallel/test-http-server-connection-list-when-close.js
index 0c8308b63c5..305755b14eb 100644
--- a/test/parallel/test-http-server-connection-list-when-close.js
+++ b/test/parallel/test-http-server-connection-list-when-close.js
@@ -13,36 +13,14 @@ function request(server) {
   });
 }
 
-{
-  const server = http.createServer(common.mustCallAtLeast((req, res) => {
-    //  Hack to not remove parser out of server.connectionList
-    //  See `freeParser` in _http_common.js
-    req.socket.parser.free = common.mustCall();
-    req.socket.on('close', common.mustCall(() => {
-      server.close();
-    }));
-    res.end('ok');
-  })).listen(0, common.mustCall(() => {
-    request(server);
+const server = http.createServer(common.mustCallAtLeast((req, res) => {
+  //  Hack to not remove parser out of server.connectionList
+  //  See `freeParser` in _http_common.js
+  req.socket.parser.free = common.mustCall();
+  req.socket.on('close', common.mustCall(() => {
+    server.close();
   }));
-}
-
-{
-  const server = http.createServer(common.mustCallAtLeast((req, res) => {
-    // See `freeParser` in _http_common.js
-    const { parser } = req.socket;
-    parser.free = common.mustCall(() => {
-      setImmediate(common.mustCall(() => {
-        parser.close();
-      }));
-    });
-    req.socket.on('close', common.mustCall(() => {
-      setImmediate(common.mustCall(() => {
-        server.close();
-      }));
-    }));
-    res.end('ok');
-  })).listen(0, common.mustCall(() => {
-    request(server);
-  }));
-}
+  res.end('ok');
+})).listen(0, common.mustCall(() => {
+  request(server);
+}));