Debug build fails on Windows: Assertion failed: vector iterators incompatible

[billti]

I made a fix for this, then realized it's already been fixed upstream in V8. See https://chromium.googlesource.com/v8/v8.git/+/385aa80aff32210d098498d1cd44d42bc70ee1d4 . Logging here for tracking and awareness.

Building on Windows via: ".\vcbuild debug x86" fails with:

 generating: "Debug\obj\v8_snapshot\/embedded.S" "Debug\obj\v8_snapshot\/snapshot.cc"
  c:\program files (x86)\microsoft visual studio\2017\enterprise\vc\tools\msvc\14.16.27023\include\vector(199) : Assertion failed: vector iterators incompatible

This issue is in the V8 currently in Node.js master, and is fixed in the upstream commit listed above.

[addaleax]

Are you talking about a released version of Node.js or the master branch? The fix should be included in #26685.

[billti]

I just did a sync/build of master this morning and hit this issue, so a new drop should fix in master. (A git tag --contains 385aa80aff32210 shows that fix is in the V8 7.4.288.8 being targeted.

Thanks!

[refack]

It's still there in 269103a

DEV D:\code\node>git rev-parse HEAD
269103a0e5e30cc217bde1660087e87dfc722b8a

DEV D:\code\node>msbuild /p:Configuration=Debug ...
...
CustomBuild:
  generating: "Debug\obj\v8_snapshot\/embedded.S" "Debug\obj\v8_snapshot\/snapshot.cc"
  D:\bin\dev\vs\2019\CommunityPreview\VC\Tools\MSVC\14.20.27404\include\vector(170) : Assertion failed: vector iterators incompatible
D:\bin\dev\vs\2019\CommunityPreview\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code -1073740791. [D:\code\node\deps\v8\gypfiles\v8_snapshot.vcxproj]
Done Building Project "D:\code\node\deps\v8\gypfiles\v8_snapshot.vcxproj" (Build target(s)) -- FAILED.

Reopening as #26685 is planned to land after V8 7.4 goes stable at 4/23.