sea: reject malformed --node-options values

Propagate tokenization errors from ParseNodeOptionsEnvVar through
FixupArgsForSEA and abort startup with an invalid command-line status
instead of applying partially parsed options.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>

Author: Archkon

src/node.cc

@@ -1633,7 +1633,14 @@ static ExitCode StartInternal(int argc, char** argv) {
 
 int Start(int argc, char** argv) {
 #ifndef DISABLE_SINGLE_EXECUTABLE_APPLICATION
-  std::tie(argc, argv) = sea::FixupArgsForSEA(argc, argv);
+  std::vector<std::string> errors;
+  std::tie(argc, argv) = sea::FixupArgsForSEA(argc, argv, &errors);
+  if (!errors.empty()) {
+    for (const std::string& error : errors) {
+      FPrintF(stderr, "%s: %s\n", argv[0], error);
+    }
+    return static_cast<int>(ExitCode::kInvalidCommandLineArgument);
+  }
 #endif
   return static_cast<int>(StartInternal(argc, argv));
 }

src/node_sea.cc

@@ -283,7 +283,8 @@ void IsExperimentalSeaWarningNeeded(const FunctionCallbackInfo<Value>& args) {
       sea_resource.flags & SeaFlags::kDisableExperimentalSeaWarning));
 }
 
-std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv) {
+std::tuple<int, char**> FixupArgsForSEA(
+    int argc, char** argv, std::vector<std::string>* errors) {
   // Repeats argv[0] at position 1 on argv as a replacement for the missing
   // entry point file path.
   if (IsSingleExecutable()) {
@@ -303,8 +304,10 @@ std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv) {
       for (int i = 1; i < argc; ++i) {
         if (strncmp(argv[i], "--node-options=", 15) == 0) {
           std::string node_options = argv[i] + 15;
-          std::vector<std::string> errors;
-          cli_extension_args = ParseNodeOptionsEnvVar(node_options, &errors);
+          cli_extension_args = ParseNodeOptionsEnvVar(node_options, errors);
+          if (!errors->empty()) {
+            return {argc, argv};
+          }
           // Remove this argument by shifting the rest
           for (int j = i; j < argc - 1; ++j) {
             argv[j] = argv[j + 1];

src/node_sea.h

@@ -70,7 +70,8 @@ struct SeaResource {
 bool IsSingleExecutable();
 std::string_view FindSingleExecutableBlob();
 SeaResource FindSingleExecutableResource();
-std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv);
+std::tuple<int, char**> FixupArgsForSEA(
+    int argc, char** argv, std::vector<std::string>* errors);
 node::ExitCode WriteSingleExecutableBlob(
     const std::string& config_path,
     const std::vector<std::string>& args,

test/sea/test-single-executable-application-exec-argv-extension-cli.js

@@ -20,18 +20,36 @@ tmpdir.refresh();
 
 const outputFile = buildSEA(fixtures.path('sea', 'exec-argv-extension-cli'));
 
+const env = {
+  ...process.env,
+  NODE_OPTIONS: '--max-old-space-size=2048', // Should be ignored
+  COMMON_DIRECTORY: join(__dirname, '..', 'common'),
+  NODE_DEBUG_NATIVE: 'SEA',
+};
+
 // Test that --node-options works with execArgvExtension: "cli"
 spawnSyncAndAssert(
   outputFile,
   ['--node-options=--max-old-space-size=1024', 'user-arg1', 'user-arg2'],
   {
-    env: {
-      ...process.env,
-      NODE_OPTIONS: '--max-old-space-size=2048', // Should be ignored
-      COMMON_DIRECTORY: join(__dirname, '..', 'common'),
-      NODE_DEBUG_NATIVE: 'SEA',
-    },
+    env,
   },
   {
     stdout: /execArgvExtension cli test passed/,
   });
+
+// Test that malformed --node-options values are rejected.
+[
+  ['--no-warnings "', /unterminated string/],
+  ['"--no-warnings\\', /invalid escape/],
+].forEach(([nodeOptions, stderr]) => {
+  spawnSyncAndAssert(
+    outputFile,
+    [`--node-options=${nodeOptions}`],
+    { env },
+    {
+      status: 9,
+      stdout: '',
+      stderr,
+    });
+});