Interception of inherited methods (e.g. GetHashCode)

[orient-man]

I use master on production because of #26 (thanks again) and I encountered another problem with method interceptors applied manually e.g.:

kernel.Bind<IBar>().To<Bar>().Intercept().With<MethodInterceptor>();

They intercept not only public methods of Bar, but also inherited (Equals/GetHashCode). It's not the case when interception is applied via InterceptAttribute. And it's also differs from "official" 3.0.0.8 NuGet package.

See full example here:

https://gist.github.com/orient-man/9625459

In my use case this leads to large performance penalty. I'm not sure if this change is intentional.

[remogloor]

Yes it is intentional. See 535917e

IIRC: Before GetHashCode etc. used the default implementations of System.Object and didn't forward it to the object. Which I consider the correct behavior.

What makes it slower in your case? Do you have an interceptor that takes a long time or is it also a large penalty if you intercept using an interceptor that does nothing at all?

[remogloor]

Just verified: If intercepting with an interface proxy the following class

class Foo : IFoo
{
     public override int GetHashCode() { return 42; }
}

the proxy will return anything but 42 as HashCode without that change.

[orient-man]

Yep, I have slow interceptor. I found that GetHashCode is being called many times inside NInject's cache. I put workaround inside my interceptor: I check what method is being called. I copied ShouldIntercept(methodInfo) from:

https://github.com/ninject/ninject.extensions.interception/blob/master/src/Ninject.Extensions.Interception/Planning/Strategies/InterceptorRegistrationStrategy.cs

This lead to other question: why it differs in behavior from the case with InterceptAttribute placed on the class? Before I could use both methods interchangeably, now I need special Interceptor.

[orient-man]

Ok, I understand: attribute is on the class, and my interceptor is on the interface. I can live with that but... what was rationale behind that decision? Maybe it should be optional i.e.

kernel.Bind<IBar>().To<Bar>().InterceptAllMethods().With<MethodInterceptor>();