From c678f26a24085e0b04bc87d1d9106391e6001386 Mon Sep 17 00:00:00 2001 From: Jonas Date: Tue, 3 Nov 2026 20:54:43 +0100 Subject: [PATCH 1/2] fix(editor): do not force save when clicking the save indicator The save indicator button called forceSave(), which skips the server-side checks for outside changes and outdated versions. A click could then silently overwrite changes made to the file outside the editor, while Ctrl+S in the same situation shows the collision dialog. Use a regular manual save for the button as well. Forcing a save stays reserved for the collision dialog. Signed-off-by: Jonas Assisted-by: ClaudeCode:claude-opus-5-5 --- src/components/Editor/Status.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Editor/Status.vue b/src/components/Editor/Status.vue index a7b94deb748..b020aab962b 100644 --- a/src/components/Editor/Status.vue +++ b/src/components/Editor/Status.vue @@ -134,7 +134,7 @@ export default { methods: { onClickSave() { if (this.dirtyStateIndicator) { - this.saveService.forceSave() + this.saveService.save() } }, t, From 5e22920cf90e78bfbc96d22e4d9ab9eca275a5ea Mon Sep 17 00:00:00 2001 From: Jonas Date: Wed, 4 Nov 2026 09:58:54 +0100 Subject: [PATCH 2/2] fix(deps): bump playwright to 1.64.1 Lower versions don't work on ubuntu-24.02 runners. Signed-off-by: Jonas Assisted-by: ClaudeCode:claude-opus-5-5 --- package-lock.json | 48 +++++++++++++++-------------------------------- package.json | 2 +- 2 files changed, 16 insertions(+), 34 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3f65dbddc7d..3b497c2547f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -92,7 +92,7 @@ "@nextcloud/eslint-config": "^8.4.2", "@nextcloud/prettier-config": "^1.2.0", "@nextcloud/vite-config": "^1.7.2", - "@playwright/test": "^1.60.0", + "@playwright/test": "^1.64.1", "@types/jsdom": "^30.0.0", "@types/markdown-it": "^14.1.2", "@types/node": "^26.2.0", @@ -4323,19 +4323,19 @@ } }, "node_modules/@playwright/test": { - "version": "1.60.0", - "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.60.0.tgz", - "integrity": "sha512-O71yZIbAh/PxDMNGns37GHBIfrVkEVyn+AXyIa5dOTfb4/xNvRWV+Vv/NMbNCtODB/pO7vLlF2OTmMVLhmr7Ag==", + "version": "1.64.1", + "resolved": "https://registry.npmjs.org/@playwright/test/-/test-1.64.1.tgz", + "integrity": "sha512-IaYGml/nSOiZWROfPtuIL7neuu9qDOZ3TNvNljUIrhDMxiGTgPjzj/g9p9RxpS2tSepPDRY+UwAaEeiKtUvIAg==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright": "1.60.0" + "playwright": "1.64.1" }, "bin": { "playwright": "cli.js" }, "engines": { - "node": ">=18" + "node": ">=20" } }, "node_modules/@popperjs/core": { @@ -16401,50 +16401,32 @@ } }, "node_modules/playwright": { - "version": "1.60.0", - "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.60.0.tgz", - "integrity": "sha512-hheHdokM8cdqCb0lcE3s+zT4t4W+vvjpGxsZlDnikarzx8tSzMebh3UiFtgqwFwnTnjYQcsyMF8ei2mCO/tpeA==", + "version": "1.64.1", + "resolved": "https://registry.npmjs.org/playwright/-/playwright-1.64.1.tgz", + "integrity": "sha512-HCrVhHr5QQuwYoswEUGTb7gGp522yflbv/ST8nF4sFWGuLjQCt17Q/EubpGGSNKYn1tsTCPZxqHhHCfVURu7UA==", "dev": true, "license": "Apache-2.0", "dependencies": { - "playwright-core": "1.60.0" + "playwright-core": "1.64.1" }, "bin": { "playwright": "cli.js" }, "engines": { - "node": ">=18" - }, - "optionalDependencies": { - "fsevents": "2.3.2" + "node": ">=20" } }, "node_modules/playwright-core": { - "version": "1.60.0", - "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.60.0.tgz", - "integrity": "sha512-9bW6zvX/m0lEbgTKJ6YppOKx8H3VOPBMOCFh2irXFOT4BbHgrx5hPjwJYLT40Lu+4qtD36qKc/Hn56StUW57IA==", + "version": "1.64.1", + "resolved": "https://registry.npmjs.org/playwright-core/-/playwright-core-1.64.1.tgz", + "integrity": "sha512-BC4s8y6SEVA6Q1rSxZTto8hI1KUI3xXlHGZgvGqP4IqPdI/a6FX9H29IDNz7vKo9l21b6LfYosScPL6M3xxyDQ==", "dev": true, "license": "Apache-2.0", "bin": { "playwright-core": "cli.js" }, "engines": { - "node": ">=18" - } - }, - "node_modules/playwright/node_modules/fsevents": { - "version": "2.3.2", - "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz", - "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==", - "dev": true, - "hasInstallScript": true, - "license": "MIT", - "optional": true, - "os": [ - "darwin" - ], - "engines": { - "node": "^8.16.0 || ^10.6.0 || >=11.0.0" + "node": ">=20" } }, "node_modules/pluralize": { diff --git a/package.json b/package.json index 00e6fb3f86b..4fa0ca55162 100644 --- a/package.json +++ b/package.json @@ -112,7 +112,7 @@ "@nextcloud/eslint-config": "^8.4.2", "@nextcloud/prettier-config": "^1.2.0", "@nextcloud/vite-config": "^1.7.2", - "@playwright/test": "^1.60.0", + "@playwright/test": "^1.64.1", "@types/jsdom": "^30.0.0", "@types/markdown-it": "^14.1.2", "@types/node": "^26.2.0",