From 8b3f38c610961e1b1f2810839c8bf769f9664770 Mon Sep 17 00:00:00 2001 From: alperozturk96 Date: Fri, 23 Oct 2026 12:01:50 +0200 Subject: [PATCH] chore(detekt): relax rules and drop obsolete suppressions Signed-off-by: alperozturk96 --- app/detekt.yml | 18 ++++----- .../migrations/MockSharedPreferences.kt | 1 - .../extensions/StringExtensionTests.kt | 1 - .../com/nextcloud/test/FileDeletionTests.kt | 2 +- .../nextcloud/test/NextcloudViewMatchers.kt | 1 - .../java/com/nextcloud/test/RetryTestRule.kt | 1 - .../com/nextcloud/utils/AutoRenameTests.kt | 1 - .../com/nextcloud/utils/FileExtensionTest.kt | 1 - .../com/nextcloud/utils/FileHelperTest.kt | 1 - .../nextcloud/utils/FileNameValidatorTests.kt | 1 - .../utils/OCCapabilityJsonToListTests.kt | 2 +- .../utils/SharePermissionManagerTest.kt | 1 - .../nextcloud/utils/WebDavParentPathTests.kt | 1 - .../java/com/owncloud/android/UploadIT.kt | 2 +- .../authentication/AuthenticatorActivityIT.kt | 4 -- .../operations/InternalTwoWaySyncIT.kt | 2 +- .../java/com/owncloud/android/ui/LoginIT.kt | 2 +- .../ui/adapter/UnifiedSearchListAdapterIT.kt | 1 - .../android/ui/dialog/DialogFragmentIT.kt | 1 - .../fragment/FileDetailSharingFragmentIT.kt | 1 - .../android/ui/fragment/GalleryFragmentIT.kt | 1 - .../ui/fragment/NotificationsFragmentIT.kt | 1 - .../android/ui/trashbin/TrashbinFragmentIT.kt | 1 - .../android/utils/EncryptionUtilsV2IT.kt | 2 +- .../android/utils/FileUploadHelperTest.kt | 2 - .../client/assistant/AssistantScreen.kt | 2 +- .../client/assistant/AssistantViewModel.kt | 1 - .../client/assistant/chat/ChatContent.kt | 2 +- .../conversation/ConversationScreen.kt | 2 +- .../assistant/translate/TranslationScreen.kt | 2 +- .../translate/TranslationScreenState.kt | 1 - .../translate/TranslationViewModel.kt | 1 - .../java/com/nextcloud/client/core/Task.kt | 2 - .../client/database/NextcloudDatabase.kt | 1 - .../nextcloud/client/database/dao/FileDao.kt | 1 - .../database/entity/CapabilityEntity.kt | 2 +- .../client/database/entity/UploadEntity.kt | 1 + .../java/com/nextcloud/client/di/AppModule.kt | 1 - .../nextcloud/client/di/ComponentsModule.kt | 1 - .../documentscan/DocumentScanViewModel.kt | 1 - .../documentscan/GeneratePdfFromImagesWork.kt | 1 - .../client/errorhandling/ExceptionHandler.kt | 1 - .../com/nextcloud/client/etm/EtmViewModel.kt | 1 - .../com/nextcloud/client/files/Request.kt | 1 - .../client/jobs/AccountRemovalWork.kt | 40 ++++++++----------- .../client/jobs/BackgroundJobFactory.kt | 3 +- .../client/jobs/BackgroundJobManager.kt | 2 - .../client/jobs/BackgroundJobManagerImpl.kt | 1 - .../client/jobs/CalendarImportWork.kt | 1 - .../client/jobs/ContactsBackupWork.kt | 2 - .../client/jobs/ContactsImportWork.kt | 4 +- .../client/jobs/ContentObserverWork.kt | 1 - .../client/jobs/InternalTwoWaySyncWork.kt | 3 +- .../client/jobs/MediaFoldersDetectionWork.kt | 3 +- .../nextcloud/client/jobs/NotificationWork.kt | 7 +--- .../nextcloud/client/jobs/OfflineSyncWork.kt | 2 - .../jobs/autoUpload/AutoUploadHelper.kt | 2 +- .../jobs/autoUpload/AutoUploadWorker.kt | 7 +--- .../jobs/autoUpload/FileSystemRepository.kt | 2 +- .../jobs/autoUpload/SyncFolderHelper.kt | 1 - .../jobs/clipboard/ClipboardClearWorker.kt | 1 - .../download/DownloadNotificationManager.kt | 2 +- .../jobs/download/FileDownloadHelper.kt | 1 - .../jobs/download/FileDownloadWorker.kt | 4 +- .../jobs/download/SendShareDownloader.kt | 1 - .../folderDownload/FolderDownloadWorker.kt | 5 +-- .../jobs/gallery/GalleryImageGenerationJob.kt | 2 +- .../client/jobs/metadata/MetadataWorker.kt | 2 +- .../OfflineOperationsWorker.kt | 4 +- .../jobs/operation/FileOperationHelper.kt | 2 +- .../jobs/transfer/TransferManagerImpl.kt | 1 - .../jobs/upload/AlbumFileUploadWorker.kt | 5 +-- .../upload/FileUploadBroadcastReceiver.kt | 2 - .../client/jobs/upload/FileUploadHelper.kt | 7 +--- .../client/jobs/upload/FileUploadWorker.kt | 6 +-- .../client/jobs/upload/UploadTask.kt | 2 - .../utils/UploadErrorNotificationManager.kt | 1 - .../client/jobs/worker/WorkerFilesPayload.kt | 1 - .../com/nextcloud/client/logger/LogEntry.kt | 1 - .../com/nextcloud/client/logger/LoggerImpl.kt | 1 - .../migrations/MigrationsManagerImpl.kt | 2 - .../client/network/ConnectivityServiceImpl.kt | 1 - .../client/player/media3/PlaybackModel.kt | 2 - .../media3/session/MediaSessionCallback.kt | 1 - .../client/player/util/PlayerUtil.kt | 1 - .../SystemBarBackgroundCallbacks.kt | 1 - .../client/widget/DashboardWidgetService.kt | 1 - .../nextcloud/model/SearchResultEntryType.kt | 1 + .../repository/RemoteClientRepository.kt | 2 +- .../ui/component/UploadWarningCard.kt | 1 - .../alertDialog/SimpleAlertDialog.kt | 1 - .../ui/fileInfo/FileInfoRepository.kt | 1 - .../nextcloud/ui/fileInfo/ImageDetailInfo.kt | 1 - .../ui/fileactions/ClientIntegration.kt | 1 - .../ui/fileactions/FileActionHandler.kt | 1 - .../ui/fileactions/FileActionHost.kt | 1 - .../utils/BatteryOptimizationHelper.kt | 1 - .../com/nextcloud/utils/BitmapExtensions.kt | 3 +- .../utils/ForegroundServiceHelper.kt | 1 - .../java/com/nextcloud/utils/GlideHelper.kt | 4 +- .../java/com/nextcloud/utils/LinkHelper.kt | 1 - .../java/com/nextcloud/utils/OCFileUtils.kt | 1 - .../java/com/nextcloud/utils/ResultParser.kt | 2 +- .../nextcloud/utils/autoRename/AutoRename.kt | 2 +- .../nextcloud/utils/avatar/AvatarGenerator.kt | 2 - .../nextcloud/utils/avatar/AvatarLoader.kt | 1 - .../nextcloud/utils/e2ee/E2ECounterHelper.kt | 1 - .../utils/e2ee/E2EEActionResolver.kt | 1 - .../nextcloud/utils/e2ee/E2EEKeyInspector.kt | 1 - .../utils/e2ee/model/E2EEKeyCheck.kt | 1 + .../utils/extensions/ContextExtensions.kt | 1 - .../FileDataStorageManagerExtensions.kt | 3 -- .../utils/extensions/FileExtensions.kt | 3 -- .../extensions/OCCapabilityExtensions.kt | 1 - .../utils/extensions/OCFileExtensions.kt | 1 - .../utils/extensions/RemoteFileExtensions.kt | 1 - .../RemoteOperationResultExtensions.kt | 1 - .../extensions/SearchResultEntryExtensions.kt | 1 + .../extensions/SyncedFolderExtensions.kt | 4 +- .../utils/extensions/TextViewExtensions.kt | 1 - .../ThumbnailsCacheManagerExtensions.kt | 2 +- .../extensions/UploadResultExtensions.kt | 1 + .../UserAccountManagerExtensions.kt | 2 +- .../utils/extensions/UserExtensions.kt | 1 - .../fileNameValidator/FileNameTextWatcher.kt | 1 - .../fileNameValidator/FileNameValidator.kt | 3 +- .../utils/thumbnail/FileThumbnailGenerator.kt | 2 +- .../utils/thumbnail/ResizedImageGenerator.kt | 1 - .../job/MediaThumbnailGenerationJob.kt | 3 -- .../job/ResizedImageGenerationJob.kt | 1 - .../utils/view/FastScrollPopupBackground.kt | 1 - .../android/authentication/PassCodeManager.kt | 1 - .../datamodel/ArbitraryDataProvider.kt | 1 - .../datamodel/ContentResolverHelper.kt | 1 - .../OCFileListAdapterDataProviderImpl.kt | 1 - .../android/datamodel/SyncedFolderObserver.kt | 1 - .../datamodel/UploadsStorageManager.kt | 2 +- .../android/files/FetchTemplateOperation.kt | 1 - .../android/files/StreamMediaFileOperation.kt | 1 - .../operations/DownloadFileOperation.kt | 1 - .../operations/FetchRemoteFileOperation.kt | 1 - .../operations/FolderRefreshScheduler.kt | 1 - .../android/operations/RemoveFileOperation.kt | 1 - .../RemoveRemoteEncryptedFileOperation.kt | 2 - .../operations/SynchronizeFileOperation.kt | 1 - .../albums/CopyFileToAlbumOperation.kt | 1 - .../albums/ReadAlbumItemsOperation.kt | 1 - .../e2e/E2ECertificateRenewalService.kt | 1 - .../factory/UploadFileOperationFactory.kt | 1 - .../upload/DeleteUploadedFileOperation.kt | 3 +- .../owncloud/android/ui/AvatarGroupLayout.kt | 2 - .../owncloud/android/ui/EmptyRecyclerView.kt | 1 - .../android/ui/NextcloudWebViewClient.kt | 1 - .../activities/StickyHeaderItemDecoration.kt | 1 - .../adapter/ActivityAndVersionListAdapter.kt | 1 - .../activities/adapter/ActivityListAdapter.kt | 2 +- .../activities/ActivitiesServiceApiImpl.kt | 1 - .../ui/activity/ConflictsResolveActivity.kt | 4 +- .../ui/activity/ExtendedSettingsActivity.kt | 1 - .../ui/activity/FileDisplayActivity.kt | 8 ++-- .../ui/activity/FolderPickerActivity.kt | 5 +-- .../ui/activity/InternalTwoWaySyncActivity.kt | 1 - .../ui/activity/ManageAccountsActivity.kt | 2 - .../ui/activity/ManageSpaceActivity.kt | 1 - .../android/ui/activity/PassCodeActivity.kt | 2 +- .../android/ui/adapter/DiskLruImageCache.kt | 1 - .../android/ui/adapter/GalleryAdapter.kt | 1 - .../android/ui/adapter/LinkShareViewHolder.kt | 2 - .../ui/adapter/NotificationListAdapter.kt | 1 - .../ui/adapter/ReceiveExternalFilesAdapter.kt | 1 - .../android/ui/adapter/ShareeListAdapter.kt | 1 - .../android/ui/adapter/SyncedFolderAdapter.kt | 1 - .../UnifiedSearchCurrentDirItemViewHolder.kt | 1 - .../ui/adapter/UnifiedSearchItemViewHolder.kt | 1 - .../ui/adapter/UnifiedSearchListAdapter.kt | 2 +- .../ui/adapter/albums/AlbumsAdapter.kt | 1 - .../CommonOCFileListAdapterInterface.kt | 1 - .../ui/adapter/filelist/OCFileListAdapter.kt | 1 - .../filelist/data/OCFileListAdapterHelper.kt | 3 +- .../filelist/header/OCFileListHeaderBinder.kt | 1 - .../filelist/item/OCFileListDelegate.kt | 5 +-- .../localFileList/LocalFileListAdapter.kt | 1 - .../localFileList/LocalFileListItemBinder.kt | 1 - .../adapter/uploadList/UploadListAdapter.kt | 5 +-- .../CopyAndUploadContentUrisTask.kt | 1 - .../ui/asynctasks/FetchRemoteFileTask.kt | 2 +- .../NotificationExecuteActionTask.kt | 1 - .../asynctasks/RetrieveHoverCardAsyncTask.kt | 2 - ...ooseRichDocumentsTemplateDialogFragment.kt | 1 - .../ui/dialog/ChooseTemplateDialogFragment.kt | 1 - .../ui/dialog/ConfirmationDialogFragment.kt | 1 - .../android/ui/dialog/SendShareDialog.kt | 1 - .../setupEncryption/CertificateValidator.kt | 1 - .../setupEncryption/EncryptionKeyGenerator.kt | 2 - .../SetupEncryptionDialogFragment.kt | 3 +- .../ui/fragment/ExtendedListFragment.kt | 5 +-- .../fragment/FileDetailActivitiesFragment.kt | 1 - .../android/ui/fragment/FileDetailFragment.kt | 1 - .../ui/fragment/FileDetailSharingFragment.kt | 2 +- .../FileDetailsSharingProcessFragment.kt | 4 +- .../android/ui/fragment/FolderEncryption.kt | 2 - .../android/ui/fragment/GalleryFragment.kt | 2 +- .../fragment/OCFileListBottomSheetDialog.kt | 1 - .../ui/fragment/OCFileListSearchTask.kt | 5 +-- .../android/ui/fragment/SharedListFragment.kt | 1 - .../ui/fragment/UnifiedSearchFragment.kt | 1 - .../ui/fragment/albums/AlbumItemsFragment.kt | 1 - .../fragment/autoUpload/AutoUploadFragment.kt | 1 - .../data/AutoUploadDisplayItemFactory.kt | 1 - .../handler/AutoUploadClickHandler.kt | 1 - .../fragment/contactsbackup/BackupFragment.kt | 4 +- .../contactsbackup/BackupListAdapter.kt | 3 +- .../filesRepository/RemoteFilesRepository.kt | 1 - .../ui/fragment/helper/ParentFolderFinder.kt | 1 - .../notifications/NotificationsFragment.kt | 1 - .../fragment/uploadList/UploadListFragment.kt | 1 - .../fragment/util/SharePermissionManager.kt | 3 -- .../android/ui/helpers/UriUploader.kt | 6 +-- .../ui/preview/media/PreviewMediaActivity.kt | 1 - .../ui/preview/media/PreviewMediaFragment.kt | 7 +--- .../preview/media/PreviewMediaPagerAdapter.kt | 1 - .../ui/preview/text/PreviewTextFragment.kt | 2 +- .../preview/text/PreviewTextStringFragment.kt | 1 - .../android/ui/trashbin/TrashbinFragment.kt | 1 - .../unifiedsearch/IUnifiedSearchRepository.kt | 1 - .../unifiedsearch/UnifiedSearchViewModel.kt | 1 - .../com/owncloud/android/utils/BitmapUtils.kt | 2 - .../owncloud/android/utils/ClipboardUtil.kt | 1 - .../android/utils/EncryptionUtilsV2.kt | 17 +++----- .../owncloud/android/utils/FileSortOrder.kt | 1 - .../android/utils/FileStorageUtils.kt | 4 -- .../owncloud/android/utils/PermissionUtil.kt | 1 - .../com/owncloud/android/utils/ProxyUtil.kt | 1 - .../utils/RichDocumentDownloadAsParser.kt | 1 - .../android/utils/SyncedFolderUtils.kt | 1 - .../com/owncloud/android/utils/UriUtils.kt | 1 - .../android/utils/crypto/CryptoHelper.kt | 2 +- .../utils/glide/GlideStringStreamFetcher.kt | 1 - .../android/utils/glide/HttpStreamFetcher.kt | 1 - .../android/utils/svg/SvgBitmapDecoder.kt | 1 - .../utils/svg/SvgOrImageBitmapTranscoder.kt | 1 - .../theme/FilesSpecificViewThemeUtils.kt | 1 - .../client/logger/FileLogHandlerTest.kt | 1 - .../com/nextcloud/client/logger/LoggerTest.kt | 1 - .../client/utils/FileSortOrderBySizeTests.kt | 2 +- .../client/utils/FileStorageUtilsTest.kt | 3 +- .../utils/FolderSizeCalculationTests.kt | 2 +- .../nextcloud/client/utils/NaturalSortTest.kt | 1 - .../datamodel/MoveFileEntitiesUpdateTest.kt | 1 - .../MoveFilesFilesystemAndMediaTest.kt | 1 - .../android/datamodel/MoveFilesGuardTest.kt | 1 - .../datamodel/MoveFilesHierarchyTest.kt | 1 - .../android/datamodel/MoveFilesTestBase.kt | 2 +- .../data/MockOCFileListAdapterDataProvider.kt | 2 +- .../data/OCFileListAdapterHelperTest.kt | 2 +- .../android/ui/db/ParentFolderFinderTest.kt | 2 +- .../utils/AutoUploadFileMatchingTests.kt | 1 - .../android/utils/E2EVersionHelperTest.kt | 1 - 258 files changed, 116 insertions(+), 397 deletions(-) diff --git a/app/detekt.yml b/app/detekt.yml index 91abf2b4b70c..2108652fdc16 100644 --- a/app/detekt.yml +++ b/app/detekt.yml @@ -53,9 +53,9 @@ complexity: active: false threshold: 10 includeStaticDeclarations: false - ComplexMethod: + CyclomaticComplexMethod: active: true - threshold: 10 + threshold: 15 ignoreSingleWhenExpression: false ignoreSimpleWhenEntries: false excludes: ['**/androidTest/**'] @@ -70,7 +70,7 @@ complexity: threshold: 60 excludes: ['**/androidTest/**'] LongParameterList: - active: true + active: false functionThreshold: 7 constructorThreshold: 6 ignoreDefaultParameters: false @@ -87,7 +87,7 @@ complexity: excludeStringsWithLessThan5Characters: true ignoreStringsRegex: '$^' TooManyFunctions: - active: true + active: false thresholdInFiles: 15 thresholdInClasses: 15 thresholdInInterfaces: 15 @@ -158,7 +158,7 @@ exceptions: ThrowingNewInstanceOfSameException: active: false TooGenericExceptionCaught: - active: true + active: false exceptionNames: - ArrayIndexOutOfBoundsException - Error @@ -170,7 +170,7 @@ exceptions: - Throwable allowedExceptionNameRegex: "^(_|(ignore|expected).*)" TooGenericExceptionThrown: - active: true + active: false exceptionNames: - Error - Exception @@ -226,7 +226,7 @@ naming: active: true packagePattern: '^[a-z]+(\.[a-z][A-Za-z0-9]*)*$' TopLevelPropertyNaming: - active: true + active: false constantPattern: '[A-Z][_A-Z0-9]*' propertyPattern: '[A-Za-z][_A-Za-z0-9]*' privatePropertyPattern: '(_)?[A-Za-z][A-Za-z0-9]*' @@ -346,7 +346,7 @@ style: NestedClassesVisibility: active: false NewLineAtEndOfFile: - active: true + active: false NoTabs: active: false OptionalAbstractKeyword: @@ -362,7 +362,7 @@ style: RedundantVisibilityModifierRule: active: false ReturnCount: - active: true + active: false max: 2 excludedFunctions: [equals] excludeLabeled: false diff --git a/app/src/androidTest/java/com/nextcloud/client/migrations/MockSharedPreferences.kt b/app/src/androidTest/java/com/nextcloud/client/migrations/MockSharedPreferences.kt index bd871693b373..e31b282436eb 100644 --- a/app/src/androidTest/java/com/nextcloud/client/migrations/MockSharedPreferences.kt +++ b/app/src/androidTest/java/com/nextcloud/client/migrations/MockSharedPreferences.kt @@ -16,7 +16,6 @@ import java.util.TreeMap * * The implementation is not thread-safe. */ -@Suppress("TooManyFunctions") class MockSharedPreferences : SharedPreferences { class MockEditor(val store: MutableMap) : SharedPreferences.Editor { diff --git a/app/src/androidTest/java/com/nextcloud/extensions/StringExtensionTests.kt b/app/src/androidTest/java/com/nextcloud/extensions/StringExtensionTests.kt index c9985b7309fa..ad9328a7bb45 100644 --- a/app/src/androidTest/java/com/nextcloud/extensions/StringExtensionTests.kt +++ b/app/src/androidTest/java/com/nextcloud/extensions/StringExtensionTests.kt @@ -11,7 +11,6 @@ import junit.framework.TestCase.assertFalse import junit.framework.TestCase.assertTrue import org.junit.Test -@Suppress("TooManyFunctions") class StringExtensionTests { @Test fun testIsNotBlankAndEqualsWhenGivenBothStringsAreNull() { diff --git a/app/src/androidTest/java/com/nextcloud/test/FileDeletionTests.kt b/app/src/androidTest/java/com/nextcloud/test/FileDeletionTests.kt index 9ade2d21c80e..e234902fe634 100644 --- a/app/src/androidTest/java/com/nextcloud/test/FileDeletionTests.kt +++ b/app/src/androidTest/java/com/nextcloud/test/FileDeletionTests.kt @@ -22,7 +22,7 @@ import org.junit.Test import java.io.File import kotlin.random.Random -@Suppress("TooManyFunctions", "MagicNumber") +@Suppress("MagicNumber") class FileDeletionTests : AbstractIT() { private val createdFilePaths = mutableListOf() diff --git a/app/src/androidTest/java/com/nextcloud/test/NextcloudViewMatchers.kt b/app/src/androidTest/java/com/nextcloud/test/NextcloudViewMatchers.kt index 11fa50fb90b0..66069feff6fc 100644 --- a/app/src/androidTest/java/com/nextcloud/test/NextcloudViewMatchers.kt +++ b/app/src/androidTest/java/com/nextcloud/test/NextcloudViewMatchers.kt @@ -18,7 +18,6 @@ fun withSelectedText(expected: String): Matcher = object : TypeSafeMatcher description.appendText("with selected text \"$expected\"") } - @Suppress("ReturnCount") override fun matchesSafely(view: View): Boolean { if (view !is TextView) return false val text = view.text?.toString() ?: "" diff --git a/app/src/androidTest/java/com/nextcloud/test/RetryTestRule.kt b/app/src/androidTest/java/com/nextcloud/test/RetryTestRule.kt index 45506db38800..8e37fbdf8dae 100644 --- a/app/src/androidTest/java/com/nextcloud/test/RetryTestRule.kt +++ b/app/src/androidTest/java/com/nextcloud/test/RetryTestRule.kt @@ -27,7 +27,6 @@ class RetryTestRule(val retryCount: Int = defaultRetryValue) : TestRule { override fun apply(base: Statement, description: Description): Statement = statement(base, description) - @Suppress("TooGenericExceptionCaught") // and this exactly what we want here private fun statement(base: Statement, description: Description): Statement { return object : Statement() { diff --git a/app/src/androidTest/java/com/nextcloud/utils/AutoRenameTests.kt b/app/src/androidTest/java/com/nextcloud/utils/AutoRenameTests.kt index f495c4806633..e7dba3840397 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/AutoRenameTests.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/AutoRenameTests.kt @@ -18,7 +18,6 @@ import com.owncloud.android.lib.resources.status.OCCapability import org.junit.Before import org.junit.Test -@Suppress("TooManyFunctions") @SinceServer(majorVersion = 30) class AutoRenameTests : AbstractOnServerIT() { diff --git a/app/src/androidTest/java/com/nextcloud/utils/FileExtensionTest.kt b/app/src/androidTest/java/com/nextcloud/utils/FileExtensionTest.kt index 2c6a454d0d00..dba7c5af428c 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/FileExtensionTest.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/FileExtensionTest.kt @@ -12,7 +12,6 @@ import junit.framework.TestCase.assertFalse import junit.framework.TestCase.assertTrue import org.junit.Test -@Suppress("TooManyFunctions") class FileExtensionTest { @Test diff --git a/app/src/androidTest/java/com/nextcloud/utils/FileHelperTest.kt b/app/src/androidTest/java/com/nextcloud/utils/FileHelperTest.kt index c04787108024..9ef63b06deec 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/FileHelperTest.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/FileHelperTest.kt @@ -15,7 +15,6 @@ import org.junit.Test import java.io.File import java.nio.file.Files -@Suppress("TooManyFunctions") class FileHelperTest { private lateinit var testDirectory: File diff --git a/app/src/androidTest/java/com/nextcloud/utils/FileNameValidatorTests.kt b/app/src/androidTest/java/com/nextcloud/utils/FileNameValidatorTests.kt index b973e482042e..8350bac7ee8c 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/FileNameValidatorTests.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/FileNameValidatorTests.kt @@ -21,7 +21,6 @@ import org.junit.Assert.assertTrue import org.junit.Before import org.junit.Test -@Suppress("TooManyFunctions") class FileNameValidatorTests : AbstractOnServerIT() { companion object { private const val MAX_FILENAME_SIZE = 250 diff --git a/app/src/androidTest/java/com/nextcloud/utils/OCCapabilityJsonToListTests.kt b/app/src/androidTest/java/com/nextcloud/utils/OCCapabilityJsonToListTests.kt index 28a6660dac88..c8b94a3dbbd3 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/OCCapabilityJsonToListTests.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/OCCapabilityJsonToListTests.kt @@ -17,7 +17,7 @@ import junit.framework.TestCase.assertEquals import junit.framework.TestCase.assertTrue import org.junit.Test -@Suppress("MagicNumber", "TooManyFunctions") +@Suppress("MagicNumber") class OCCapabilityJsonToListTests : AbstractIT() { private var capability: OCCapability = fileDataStorageManager.getCapability(account.name) diff --git a/app/src/androidTest/java/com/nextcloud/utils/SharePermissionManagerTest.kt b/app/src/androidTest/java/com/nextcloud/utils/SharePermissionManagerTest.kt index 3f65ba31269a..d174057f75ae 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/SharePermissionManagerTest.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/SharePermissionManagerTest.kt @@ -18,7 +18,6 @@ import junit.framework.TestCase.assertFalse import junit.framework.TestCase.assertTrue import org.junit.Test -@Suppress("TooManyFunctions") class SharePermissionManagerTest { private fun createShare(sharePermission: Int, isFolder: Boolean = false, attributesJson: String? = null): OCShare = diff --git a/app/src/androidTest/java/com/nextcloud/utils/WebDavParentPathTests.kt b/app/src/androidTest/java/com/nextcloud/utils/WebDavParentPathTests.kt index f08f2322fbe0..d228260d5eab 100644 --- a/app/src/androidTest/java/com/nextcloud/utils/WebDavParentPathTests.kt +++ b/app/src/androidTest/java/com/nextcloud/utils/WebDavParentPathTests.kt @@ -11,7 +11,6 @@ import com.nextcloud.utils.extensions.webDavParentPath import org.junit.Assert.assertEquals import org.junit.Test -@Suppress("TooManyFunctions") class WebDavParentPathTests { @Test diff --git a/app/src/androidTest/java/com/owncloud/android/UploadIT.kt b/app/src/androidTest/java/com/owncloud/android/UploadIT.kt index 67ddf44fbb43..e5cbad039abd 100644 --- a/app/src/androidTest/java/com/owncloud/android/UploadIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/UploadIT.kt @@ -40,7 +40,7 @@ import java.nio.file.attribute.BasicFileAttributes import java.util.concurrent.TimeUnit import kotlin.math.abs -@Suppress("TooManyFunctions", "DEPRECATION") +@Suppress("DEPRECATION") class UploadIT : AbstractOnServerIT() { private val uploadsStorageManager = UploadsStorageManager( UserAccountManagerImpl.fromContext(targetContext), diff --git a/app/src/androidTest/java/com/owncloud/android/authentication/AuthenticatorActivityIT.kt b/app/src/androidTest/java/com/owncloud/android/authentication/AuthenticatorActivityIT.kt index 0ed8b7fe7286..e8c0f189db87 100644 --- a/app/src/androidTest/java/com/owncloud/android/authentication/AuthenticatorActivityIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/authentication/AuthenticatorActivityIT.kt @@ -18,7 +18,6 @@ class AuthenticatorActivityIT { } @Test - @Suppress("TooGenericExceptionCaught") fun tryCatch() { val color = try { Color.parseColor("1") @@ -30,7 +29,6 @@ class AuthenticatorActivityIT { } @Test - @Suppress("TooGenericExceptionCaught") fun tryCatch2() { val color = try { Color.parseColor("") @@ -42,7 +40,6 @@ class AuthenticatorActivityIT { } @Test - @Suppress("TooGenericExceptionCaught") fun tryCatch3() { val color = try { Color.parseColor(null) @@ -54,7 +51,6 @@ class AuthenticatorActivityIT { } @Test - @Suppress("TooGenericExceptionCaught") fun tryCatch4() { val color = try { Color.parseColor("abc") diff --git a/app/src/androidTest/java/com/owncloud/android/operations/InternalTwoWaySyncIT.kt b/app/src/androidTest/java/com/owncloud/android/operations/InternalTwoWaySyncIT.kt index fe334965c8bb..8fd2f17666b8 100644 --- a/app/src/androidTest/java/com/owncloud/android/operations/InternalTwoWaySyncIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/operations/InternalTwoWaySyncIT.kt @@ -18,7 +18,7 @@ import org.junit.Assert.assertTrue import org.junit.Test import java.io.File -@Suppress("TooManyFunctions", "DEPRECATION") +@Suppress("DEPRECATION") class InternalTwoWaySyncIT : AbstractInternalTwoWaySyncIT() { companion object { diff --git a/app/src/androidTest/java/com/owncloud/android/ui/LoginIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/LoginIT.kt index bc50e57361bc..7b89e07a9d75 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/LoginIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/LoginIT.kt @@ -52,7 +52,7 @@ class LoginIT : AbstractIT() { */ @Test @Throws(InterruptedException::class) - @Suppress("MagicNumber", "SwallowedException") + @Suppress("MagicNumber") @SdkSuppress(minSdkVersion = Build.VERSION_CODES.Q) @Flaky("Login no longer uses an in-app WebView, so espresso-web (Espresso.onWebView) cannot drive it. ") fun login() { diff --git a/app/src/androidTest/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapterIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapterIT.kt index 10e19ac4e5e7..41ec5f6b401a 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapterIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapterIT.kt @@ -31,7 +31,6 @@ import javax.inject.Provider import org.junit.Before import org.junit.Test -@Suppress("TooManyFunctions") class UnifiedSearchListAdapterIT : AbstractIT() { private val testClassName = "com.owncloud.android.ui.adapter.UnifiedSearchListAdapterIT" diff --git a/app/src/androidTest/java/com/owncloud/android/ui/dialog/DialogFragmentIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/dialog/DialogFragmentIT.kt index 70e39466ee99..cf066a8a0296 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/dialog/DialogFragmentIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/dialog/DialogFragmentIT.kt @@ -78,7 +78,6 @@ import org.junit.Test import java.net.URI import java.util.function.Supplier -@Suppress("TooManyFunctions") class DialogFragmentIT : AbstractIT() { private val testClassName = "com.owncloud.android.ui.dialog.DialogFragmentIT" private val serverUrl = "https://nextcloud.localhost" diff --git a/app/src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailSharingFragmentIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailSharingFragmentIT.kt index 4d0299715990..40dca83c77b3 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailSharingFragmentIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/fragment/FileDetailSharingFragmentIT.kt @@ -58,7 +58,6 @@ import org.junit.Before import org.junit.Rule import org.junit.Test -@Suppress("TooManyFunctions") class FileDetailSharingFragmentIT : AbstractIT() { private val testClassName = "com.owncloud.android.ui.fragment.FileDetailSharingFragmentIT" diff --git a/app/src/androidTest/java/com/owncloud/android/ui/fragment/GalleryFragmentIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/fragment/GalleryFragmentIT.kt index 3a68ff53e31c..1afd7cef487e 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/fragment/GalleryFragmentIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/fragment/GalleryFragmentIT.kt @@ -151,7 +151,6 @@ class GalleryFragmentIT : AbstractIT() { } /** Recursively walk view tree to find the first RecyclerView. Runs on the same thread that calls it. */ - @Suppress("ReturnCount") private fun findRecyclerViewRecursively(root: View?): RecyclerView? { if (root == null) return null if (root is RecyclerView) return root diff --git a/app/src/androidTest/java/com/owncloud/android/ui/fragment/NotificationsFragmentIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/fragment/NotificationsFragmentIT.kt index 6959dcdc4d85..1c3634ba9cab 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/fragment/NotificationsFragmentIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/fragment/NotificationsFragmentIT.kt @@ -115,7 +115,6 @@ class NotificationsFragmentIT : AbstractIT() { add(buildNotificationManyActions()) } - @Suppress("ReturnCount") private fun findFragment(sut: NavigatorActivity): NotificationsFragment? { val allFragments = sut.supportFragmentManager.fragments for (f in allFragments) { diff --git a/app/src/androidTest/java/com/owncloud/android/ui/trashbin/TrashbinFragmentIT.kt b/app/src/androidTest/java/com/owncloud/android/ui/trashbin/TrashbinFragmentIT.kt index abbf28b5d3c3..41ed3d1a6414 100644 --- a/app/src/androidTest/java/com/owncloud/android/ui/trashbin/TrashbinFragmentIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/ui/trashbin/TrashbinFragmentIT.kt @@ -32,7 +32,6 @@ class TrashbinFragmentIT : AbstractIT() { FILES } - @Suppress("ReturnCount") private fun findFragment(sut: NavigatorActivity): TrashbinFragment? { val allFragments = sut.supportFragmentManager.fragments for (f in allFragments) { diff --git a/app/src/androidTest/java/com/owncloud/android/utils/EncryptionUtilsV2IT.kt b/app/src/androidTest/java/com/owncloud/android/utils/EncryptionUtilsV2IT.kt index 47d27b0558ce..1aa2367ff87b 100644 --- a/app/src/androidTest/java/com/owncloud/android/utils/EncryptionUtilsV2IT.kt +++ b/app/src/androidTest/java/com/owncloud/android/utils/EncryptionUtilsV2IT.kt @@ -32,7 +32,7 @@ import org.junit.Assert.assertFalse import org.junit.Assert.assertNotEquals import org.junit.Test -@Suppress("TooManyFunctions", "LargeClass") +@Suppress("LargeClass") class EncryptionUtilsV2IT : EncryptionIT() { private val encryptionTestUtils = EncryptionTestUtils() private val encryptionUtilsV2 = EncryptionUtilsV2() diff --git a/app/src/androidTest/java/com/owncloud/android/utils/FileUploadHelperTest.kt b/app/src/androidTest/java/com/owncloud/android/utils/FileUploadHelperTest.kt index 80eaf472719e..cacff62a10b2 100644 --- a/app/src/androidTest/java/com/owncloud/android/utils/FileUploadHelperTest.kt +++ b/app/src/androidTest/java/com/owncloud/android/utils/FileUploadHelperTest.kt @@ -30,7 +30,6 @@ import org.junit.Assert.assertNull import org.junit.Before import org.junit.Test -@Suppress("TooManyFunctions") class FileUploadHelperTest { private lateinit var uploadDao: UploadDao @@ -49,7 +48,6 @@ class FileUploadHelperTest { fileUploadHelper.fileStorageManager = mockFileStorageManager } - @Suppress("LongParameterList") private fun buildEntity( id: Int = 1, localPath: String = this.localPath, diff --git a/app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt b/app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt index 2223fe2692e7..3802bb583157 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/AssistantScreen.kt @@ -88,7 +88,7 @@ import kotlinx.coroutines.withContext private const val CHAT_INPUT_DELAY = 100L private const val PULL_TO_REFRESH_DELAY = 1500L -@Suppress("LongMethod") +@Suppress("LongMethod", "CyclomaticComplexMethod") @OptIn(ExperimentalMaterial3Api::class) @Composable fun AssistantScreen( diff --git a/app/src/main/java/com/nextcloud/client/assistant/AssistantViewModel.kt b/app/src/main/java/com/nextcloud/client/assistant/AssistantViewModel.kt index e1d4d90cbef1..ce517dc15305 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/AssistantViewModel.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/AssistantViewModel.kt @@ -28,7 +28,6 @@ import kotlinx.coroutines.flow.update import kotlinx.coroutines.isActive import kotlinx.coroutines.launch -@Suppress("TooManyFunctions") class AssistantViewModel( private val accountName: String, private val remoteRepository: AssistantRemoteRepository, diff --git a/app/src/main/java/com/nextcloud/client/assistant/chat/ChatContent.kt b/app/src/main/java/com/nextcloud/client/assistant/chat/ChatContent.kt index 3fc0b6dbe766..5a779f73d4ce 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/chat/ChatContent.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/chat/ChatContent.kt @@ -5,7 +5,7 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -@file:Suppress("TopLevelPropertyNaming", "MagicNumber") +@file:Suppress("MagicNumber") package com.nextcloud.client.assistant.chat diff --git a/app/src/main/java/com/nextcloud/client/assistant/conversation/ConversationScreen.kt b/app/src/main/java/com/nextcloud/client/assistant/conversation/ConversationScreen.kt index d1235c0a6ef5..8d58a5d32b3e 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/conversation/ConversationScreen.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/conversation/ConversationScreen.kt @@ -5,7 +5,7 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -@file:Suppress("TopLevelPropertyNaming", "MagicNumber") +@file:Suppress("MagicNumber") package com.nextcloud.client.assistant.conversation diff --git a/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreen.kt b/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreen.kt index 63a75e7b36dd..6d77ff09c28f 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreen.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreen.kt @@ -146,7 +146,7 @@ fun TranslationScreen(viewModel: TranslationViewModel, assistantViewModel: Assis } } -@Suppress("LongMethod", "LongParameterList") +@Suppress("LongMethod") @Composable private fun TranslationSection( labelId: Int, diff --git a/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreenState.kt b/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreenState.kt index ae69aebd3f7f..967623a25d6d 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreenState.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationScreenState.kt @@ -11,7 +11,6 @@ import com.owncloud.android.R import com.owncloud.android.lib.resources.assistant.v2.model.TaskTypeData import com.owncloud.android.lib.resources.assistant.v2.model.toTranslationLanguages -@Suppress("LongParameterList") sealed class TranslationScreenState( open val taskTypeData: TaskTypeData, open val source: TranslationSideState, diff --git a/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationViewModel.kt b/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationViewModel.kt index df78ef73a35f..c31fc4a7f75f 100644 --- a/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationViewModel.kt +++ b/app/src/main/java/com/nextcloud/client/assistant/translate/TranslationViewModel.kt @@ -84,7 +84,6 @@ class TranslationViewModel(private val remoteRepository: AssistantRemoteReposito } } - @Suppress("ReturnCount") private suspend fun pollTranslationResult() { val screenStateValue = _screenState.value if (screenStateValue is Uninitialized) { diff --git a/app/src/main/java/com/nextcloud/client/core/Task.kt b/app/src/main/java/com/nextcloud/client/core/Task.kt index 6c04e3aa551f..0000519a059a 100644 --- a/app/src/main/java/com/nextcloud/client/core/Task.kt +++ b/app/src/main/java/com/nextcloud/client/core/Task.kt @@ -12,7 +12,6 @@ import java.util.concurrent.atomic.AtomicBoolean * This is a wrapper for a task function running in background. * It executes task function and handles result or error delivery. */ -@Suppress("LongParameterList") internal class Task( private val postResult: (Runnable) -> Boolean, private val removeFromQueue: (Runnable) -> Boolean, @@ -32,7 +31,6 @@ internal class Task( postResult(Runnable { onProgress?.invoke(p) }) } - @Suppress("TooGenericExceptionCaught") // this is exactly what we want here override fun run() { try { val result = taskBody.invoke({ postProgress(it) }, this::isCancelled) diff --git a/app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt b/app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt index 60e017489fb1..b6676caf0a1b 100644 --- a/app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt +++ b/app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt @@ -109,7 +109,6 @@ import com.owncloud.android.db.ProviderMeta ], exportSchema = true ) -@Suppress("Detekt.UnnecessaryAbstractClass") // needed by Room @TypeConverters(OfflineOperationTypeConverter::class) abstract class NextcloudDatabase : RoomDatabase() { diff --git a/app/src/main/java/com/nextcloud/client/database/dao/FileDao.kt b/app/src/main/java/com/nextcloud/client/database/dao/FileDao.kt index cc1767781f57..7cecfe6fdef3 100644 --- a/app/src/main/java/com/nextcloud/client/database/dao/FileDao.kt +++ b/app/src/main/java/com/nextcloud/client/database/dao/FileDao.kt @@ -14,7 +14,6 @@ import com.nextcloud.client.database.entity.FileEntity import com.owncloud.android.db.ProviderMeta.ProviderTableMeta import com.owncloud.android.utils.MimeType -@Suppress("TooManyFunctions") @Dao interface FileDao { @Update diff --git a/app/src/main/java/com/nextcloud/client/database/entity/CapabilityEntity.kt b/app/src/main/java/com/nextcloud/client/database/entity/CapabilityEntity.kt index 253ddc547a1a..a8b7035168f6 100644 --- a/app/src/main/java/com/nextcloud/client/database/entity/CapabilityEntity.kt +++ b/app/src/main/java/com/nextcloud/client/database/entity/CapabilityEntity.kt @@ -162,7 +162,7 @@ data class CapabilityEntity( val sharingJson: String? ) -@Suppress("LongMethod", "ReturnCount") +@Suppress("LongMethod", "CyclomaticComplexMethod") fun CapabilityEntity?.toOCCapability(): OCCapability { val capability = OCCapability() if (this == null) return capability diff --git a/app/src/main/java/com/nextcloud/client/database/entity/UploadEntity.kt b/app/src/main/java/com/nextcloud/client/database/entity/UploadEntity.kt index bc9636bc797f..a3d6ea7944a6 100644 --- a/app/src/main/java/com/nextcloud/client/database/entity/UploadEntity.kt +++ b/app/src/main/java/com/nextcloud/client/database/entity/UploadEntity.kt @@ -71,6 +71,7 @@ data class UploadEntity( val folderUnlockToken: String? ) +@Suppress("CyclomaticComplexMethod") fun UploadEntity.toOCUpload(capability: OCCapability? = null): OCUpload? { val localPath = localPath var remotePath = remotePath diff --git a/app/src/main/java/com/nextcloud/client/di/AppModule.kt b/app/src/main/java/com/nextcloud/client/di/AppModule.kt index 61d9a9595f84..3436eda0496f 100644 --- a/app/src/main/java/com/nextcloud/client/di/AppModule.kt +++ b/app/src/main/java/com/nextcloud/client/di/AppModule.kt @@ -73,7 +73,6 @@ import javax.inject.Singleton import com.nextcloud.utils.AppConstants.BYTES_PER_MB @Module(includes = [ComponentsModule::class, VariantComponentsModule::class, BuildTypeComponentsModule::class]) -@Suppress("TooManyFunctions") internal class AppModule { @Provides diff --git a/app/src/main/java/com/nextcloud/client/di/ComponentsModule.kt b/app/src/main/java/com/nextcloud/client/di/ComponentsModule.kt index 3ed6816db592..9a173f13e643 100644 --- a/app/src/main/java/com/nextcloud/client/di/ComponentsModule.kt +++ b/app/src/main/java/com/nextcloud/client/di/ComponentsModule.kt @@ -144,7 +144,6 @@ import dagger.android.ContributesAndroidInjector * Register classes that require dependency injection. This class is used by Dagger compiler only. */ @Module -@Suppress("TooManyFunctions") internal interface ComponentsModule { @ContributesAndroidInjector fun trashbinFragment(): TrashbinFragment diff --git a/app/src/main/java/com/nextcloud/client/documentscan/DocumentScanViewModel.kt b/app/src/main/java/com/nextcloud/client/documentscan/DocumentScanViewModel.kt index 72655d3142d1..a6a5d5062f46 100644 --- a/app/src/main/java/com/nextcloud/client/documentscan/DocumentScanViewModel.kt +++ b/app/src/main/java/com/nextcloud/client/documentscan/DocumentScanViewModel.kt @@ -29,7 +29,6 @@ import kotlinx.coroutines.launch import java.io.File import javax.inject.Inject -@Suppress("Detekt.LongParameterList") // satisfied by DI class DocumentScanViewModel @Inject constructor( @IoDispatcher private val ioDispatcher: CoroutineDispatcher = Dispatchers.IO, app: Application, diff --git a/app/src/main/java/com/nextcloud/client/documentscan/GeneratePdfFromImagesWork.kt b/app/src/main/java/com/nextcloud/client/documentscan/GeneratePdfFromImagesWork.kt index f400bd5392b5..7fa343cc19b0 100644 --- a/app/src/main/java/com/nextcloud/client/documentscan/GeneratePdfFromImagesWork.kt +++ b/app/src/main/java/com/nextcloud/client/documentscan/GeneratePdfFromImagesWork.kt @@ -30,7 +30,6 @@ import com.owncloud.android.utils.theme.ViewThemeUtils import java.io.File import java.security.SecureRandom -@Suppress("Detekt.LongParameterList") // constructed only from factory method and tests class GeneratePdfFromImagesWork( private val appContext: Context, private val generatePdfUseCase: GeneratePDFUseCase, diff --git a/app/src/main/java/com/nextcloud/client/errorhandling/ExceptionHandler.kt b/app/src/main/java/com/nextcloud/client/errorhandling/ExceptionHandler.kt index f68f17527519..ecb7d904869a 100644 --- a/app/src/main/java/com/nextcloud/client/errorhandling/ExceptionHandler.kt +++ b/app/src/main/java/com/nextcloud/client/errorhandling/ExceptionHandler.kt @@ -27,7 +27,6 @@ class ExceptionHandler( } override fun uncaughtException(thread: Thread, exception: Throwable) { - @Suppress("TooGenericExceptionCaught") // this is exactly what we want here try { val errorReport = generateErrorReport(formatException(thread, exception)) val intent = Intent(context, ShowErrorActivity::class.java) diff --git a/app/src/main/java/com/nextcloud/client/etm/EtmViewModel.kt b/app/src/main/java/com/nextcloud/client/etm/EtmViewModel.kt index 6007973869ec..6c4a4156b599 100644 --- a/app/src/main/java/com/nextcloud/client/etm/EtmViewModel.kt +++ b/app/src/main/java/com/nextcloud/client/etm/EtmViewModel.kt @@ -32,7 +32,6 @@ import com.owncloud.android.R import com.owncloud.android.lib.common.accounts.AccountUtils import javax.inject.Inject -@Suppress("LongParameterList") // Dependencies Injection @SuppressLint("StaticFieldLeak") class EtmViewModel @Inject constructor( private val context: Context, diff --git a/app/src/main/java/com/nextcloud/client/files/Request.kt b/app/src/main/java/com/nextcloud/client/files/Request.kt index cc72bcecaf4a..c922d3e3009e 100644 --- a/app/src/main/java/com/nextcloud/client/files/Request.kt +++ b/app/src/main/java/com/nextcloud/client/files/Request.kt @@ -78,7 +78,6 @@ class DownloadRequest internal constructor( } } -@Suppress("LongParameterList") class UploadRequest internal constructor( user: User, file: OCFile, diff --git a/app/src/main/java/com/nextcloud/client/jobs/AccountRemovalWork.kt b/app/src/main/java/com/nextcloud/client/jobs/AccountRemovalWork.kt index 196bcb49d1ce..988f60184d21 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/AccountRemovalWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/AccountRemovalWork.kt @@ -48,7 +48,6 @@ import java.util.Optional /** * Removes account and all local files */ -@Suppress("LongParameterList") // legacy code class AccountRemovalWork( private val context: Context, params: WorkerParameters, @@ -67,7 +66,6 @@ class AccountRemovalWork( const val REMOTE_WIPE = "remote_wipe" } - @Suppress("ReturnCount") // legacy code override fun doWork(): Result { val accountName = inputData.getString(ACCOUNT) ?: "" if (TextUtils.isEmpty(accountName)) { @@ -185,29 +183,23 @@ class AccountRemovalWork( } } - private fun createClient(user: User): Optional { - @Suppress("TooGenericExceptionCaught") // needs migration to newer api to get rid of exceptions - return try { - val context = MainApp.getAppContext() - val factory = OwnCloudClientManagerFactory.getDefaultSingleton() - val client = factory.getClientFor(user.toOwnCloudAccount(), context) - Optional.of(client) - } catch (e: Exception) { - Log_OC.e(this, "Could not create client", e) - Optional.empty() - } + private fun createClient(user: User): Optional = try { + val context = MainApp.getAppContext() + val factory = OwnCloudClientManagerFactory.getDefaultSingleton() + val client = factory.getClientFor(user.toOwnCloudAccount(), context) + Optional.of(client) + } catch (e: Exception) { + Log_OC.e(this, "Could not create client", e) + Optional.empty() } - private fun createNextcloudClient(user: User): Optional { - @Suppress("TooGenericExceptionCaught") // needs migration to newer api to get rid of exceptions - return try { - val context = MainApp.getAppContext() - val factory = OwnCloudClientManagerFactory.getDefaultSingleton() - val client = factory.getNextcloudClientFor(user.toOwnCloudAccount(), context) - Optional.of(client) - } catch (e: Exception) { - Log_OC.e(this, "Could not create client", e) - Optional.empty() - } + private fun createNextcloudClient(user: User): Optional = try { + val context = MainApp.getAppContext() + val factory = OwnCloudClientManagerFactory.getDefaultSingleton() + val client = factory.getNextcloudClientFor(user.toOwnCloudAccount(), context) + Optional.of(client) + } catch (e: Exception) { + Log_OC.e(this, "Could not create client", e) + Optional.empty() } } diff --git a/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobFactory.kt b/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobFactory.kt index 166b9fc0334d..b1eb3fec92f1 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobFactory.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobFactory.kt @@ -51,7 +51,6 @@ import javax.inject.Provider * * This class is doing too many things and should be split up into smaller factories. */ -@Suppress("LongParameterList", "TooManyFunctions") // satisfied by DI class BackgroundJobFactory @Inject constructor( private val logger: Logger, private val preferences: AppPreferences, @@ -76,7 +75,7 @@ class BackgroundJobFactory @Inject constructor( ) : WorkerFactory() { @SuppressLint("NewApi") - @Suppress("ComplexMethod") // it's just a trivial dispatch + @Suppress("CyclomaticComplexMethod") // it's just a trivial dispatch override fun createWorker( context: Context, workerClassName: String, diff --git a/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManager.kt b/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManager.kt index da7d997f592c..7f4a0a3184cc 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManager.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManager.kt @@ -18,7 +18,6 @@ import com.owncloud.android.operations.DownloadType * This interface allows to control, schedule and monitor all application * long-running background tasks, such as periodic checks or synchronization. */ -@Suppress("TooManyFunctions") // we expect this implementation to have rich API interface BackgroundJobManager { /** @@ -152,7 +151,6 @@ interface BackgroundJobManager { fun cancelEnqueuedAutoUploads() fun cancelFilesDownloadJob(accountName: String, fileId: Long) - @Suppress("LongParameterList") fun startFileDownloadJob( user: User, file: OCFile, diff --git a/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt b/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt index 3e110c414e42..54f3852d8763 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt @@ -70,7 +70,6 @@ import kotlin.time.Duration.Companion.days * considered private implementation detail and should not be leaked through the interface, to minimize * potential migration cost in the future. */ -@Suppress("TooManyFunctions") // we expect this implementation to have rich API internal class BackgroundJobManagerImpl( private val workManager: WorkManager, private val clock: Clock, diff --git a/app/src/main/java/com/nextcloud/client/jobs/CalendarImportWork.kt b/app/src/main/java/com/nextcloud/client/jobs/CalendarImportWork.kt index bc8066a5d408..892ede4a90a5 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/CalendarImportWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/CalendarImportWork.kt @@ -32,7 +32,6 @@ class CalendarImportWork( const val TAG = "CalendarImportWork" } - @Suppress("TooGenericExceptionCaught") override fun doWork(): Result { val calendars = inputData.keyValueMap as? Map<*, *> if (calendars == null) { diff --git a/app/src/main/java/com/nextcloud/client/jobs/ContactsBackupWork.kt b/app/src/main/java/com/nextcloud/client/jobs/ContactsBackupWork.kt index e6677856b7d0..920cf3879e4f 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/ContactsBackupWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/ContactsBackupWork.kt @@ -45,7 +45,6 @@ import java.io.InputStreamReader import java.util.Calendar import kotlin.time.Duration.Companion.days -@Suppress("LongParameterList") // legacy code class ContactsBackupWork( appContext: Context, params: WorkerParameters, @@ -66,7 +65,6 @@ class ContactsBackupWork( private var operationsServiceConnection: OperationsServiceConnection? = null private var operationsServiceBinder: OperationsServiceBinder? = null - @Suppress("ReturnCount") // pre-existing issue override fun doWork(): Result { val accountName = inputData.getString(KEY_ACCOUNT) ?: "" if (TextUtils.isEmpty(accountName)) { diff --git a/app/src/main/java/com/nextcloud/client/jobs/ContactsImportWork.kt b/app/src/main/java/com/nextcloud/client/jobs/ContactsImportWork.kt index 4a7d1eece9d3..ed06fbe3b5f2 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/ContactsImportWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/ContactsImportWork.kt @@ -46,7 +46,7 @@ class ContactsImportWork( const val SELECTED_CONTACTS_FILE_PATH = "selected_contacts_file_path" } - @Suppress("ComplexMethod", "NestedBlockDepth", "LongMethod", "ReturnCount") // legacy code + @Suppress("CyclomaticComplexMethod", "NestedBlockDepth", "LongMethod") // legacy code override fun doWork(): Result { val vCardFilePath = inputData.getString(VCARD_FILE_PATH) ?: "" val contactsAccountName = inputData.getString(ACCOUNT_NAME) @@ -69,7 +69,6 @@ class ContactsImportWork( val vCards = ArrayList() var cursor: Cursor? = null - @Suppress("TooGenericExceptionCaught") // legacy code try { val operations = ContactOperations(applicationContext, contactsAccountName, contactsAccountType) vCards.addAll(Ezvcard.parse(inputStream).all()) @@ -129,7 +128,6 @@ class ContactsImportWork( return Result.success() } - @Suppress("TooGenericExceptionCaught") fun readCheckedContractsFromFile(file: File): IntArray = try { val fileData = FileUtils.readFileToByteArray(file) fileData.toIntArray() diff --git a/app/src/main/java/com/nextcloud/client/jobs/ContentObserverWork.kt b/app/src/main/java/com/nextcloud/client/jobs/ContentObserverWork.kt index 9229fd297018..8d6f52e0e0a7 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/ContentObserverWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/ContentObserverWork.kt @@ -24,7 +24,6 @@ import kotlinx.coroutines.withContext * It fires media detection worker and auto upload worker and finishes immediately. * */ -@Suppress("TooGenericExceptionCaught", "LongParameterList") class ContentObserverWork( context: Context, private val params: WorkerParameters, diff --git a/app/src/main/java/com/nextcloud/client/jobs/InternalTwoWaySyncWork.kt b/app/src/main/java/com/nextcloud/client/jobs/InternalTwoWaySyncWork.kt index 4016d55010f0..8a60b6c8b02f 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/InternalTwoWaySyncWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/InternalTwoWaySyncWork.kt @@ -22,7 +22,7 @@ import com.owncloud.android.operations.SynchronizeFolderOperation import com.owncloud.android.utils.FileStorageUtils import java.io.File -@Suppress("Detekt.NestedBlockDepth", "ReturnCount", "LongParameterList") +@Suppress("Detekt.NestedBlockDepth") class InternalTwoWaySyncWork( private val context: Context, params: WorkerParameters, @@ -113,7 +113,6 @@ class InternalTwoWaySyncWork( super.onStopped() } - @Suppress("TooGenericExceptionCaught") private fun checkFreeSpace(folder: OCFile): Result? { val storagePath = folder.storagePath ?: MainApp.getStoragePath() val file = File(storagePath) diff --git a/app/src/main/java/com/nextcloud/client/jobs/MediaFoldersDetectionWork.kt b/app/src/main/java/com/nextcloud/client/jobs/MediaFoldersDetectionWork.kt index cad947c6700f..6dab98e734f0 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/MediaFoldersDetectionWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/MediaFoldersDetectionWork.kt @@ -48,7 +48,6 @@ import com.owncloud.android.utils.SyncedFolderUtils import com.owncloud.android.utils.theme.ViewThemeUtils import java.util.Random -@Suppress("LongParameterList") // dependencies injection class MediaFoldersDetectionWork( private val context: Context, params: WorkerParameters, @@ -73,7 +72,7 @@ class MediaFoldersDetectionWork( private val randomIdGenerator = Random(clock.currentTime) - @Suppress("LongMethod", "ComplexMethod", "NestedBlockDepth", "ReturnCount") // legacy code + @Suppress("LongMethod", "CyclomaticComplexMethod", "NestedBlockDepth") // legacy code override fun doWork(): Result { val arbitraryDataProvider: ArbitraryDataProvider = ArbitraryDataProviderImpl(context) val gson = Gson() diff --git a/app/src/main/java/com/nextcloud/client/jobs/NotificationWork.kt b/app/src/main/java/com/nextcloud/client/jobs/NotificationWork.kt index 05bb6877472e..fa6dd9caddf2 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/NotificationWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/NotificationWork.kt @@ -61,7 +61,6 @@ import javax.crypto.BadPaddingException import javax.crypto.Cipher import javax.inject.Inject -@Suppress("LongParameterList") class NotificationWork constructor( private val context: Context, params: WorkerParameters, @@ -82,7 +81,7 @@ class NotificationWork constructor( private const val NUMERIC_NOTIFICATION_ID = "NUMERIC_NOTIFICATION_ID" } - @Suppress("TooGenericExceptionCaught", "NestedBlockDepth", "ComplexMethod", "LongMethod") // legacy code + @Suppress("NestedBlockDepth", "CyclomaticComplexMethod", "LongMethod") // legacy code override fun doWork(): Result { val subject = inputData.getString(KEY_NOTIFICATION_SUBJECT) ?: "" val signature = inputData.getString(KEY_NOTIFICATION_SIGNATURE) ?: "" @@ -252,7 +251,6 @@ class NotificationWork constructor( } } - @Suppress("TooGenericExceptionCaught") // legacy code private fun fetchCompleteNotification(account: User, decryptedPushMessage: DecryptedPushMessage) { val optionalUser = accountManager.getUser(account.accountName) if (!optionalUser.isPresent) { @@ -286,7 +284,7 @@ class NotificationWork constructor( this.accountManager = accountManager } - @Suppress("ComplexMethod") // legacy code + @Suppress("CyclomaticComplexMethod") // legacy code override fun onReceive(context: Context, intent: Intent) { AndroidInjection.inject(this, context) val numericNotificationId = intent.getIntExtra(NUMERIC_NOTIFICATION_ID, 0) @@ -341,7 +339,6 @@ class NotificationWork constructor( } } - @Suppress("ReturnCount") // legacy code private fun executeAction( actionType: String, actionLink: String, diff --git a/app/src/main/java/com/nextcloud/client/jobs/OfflineSyncWork.kt b/app/src/main/java/com/nextcloud/client/jobs/OfflineSyncWork.kt index 500489183895..e72aa0ca9569 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/OfflineSyncWork.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/OfflineSyncWork.kt @@ -27,7 +27,6 @@ import com.owncloud.android.operations.SynchronizeFileOperation import com.owncloud.android.utils.FileStorageUtils import java.io.File -@Suppress("LongParameterList") // Legacy code class OfflineSyncWork( private val context: Context, params: WorkerParameters, @@ -98,7 +97,6 @@ class OfflineSyncWork( } } // update eTag - @Suppress("TooGenericExceptionCaught") // legacy code try { val ocFolder = storageManager.getFileByPath(folderName) ocFolder.etagOnServer = updatedEtag diff --git a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadHelper.kt b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadHelper.kt index 93f8b262add6..c1e8a6c0691e 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadHelper.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadHelper.kt @@ -23,7 +23,7 @@ import java.nio.file.Paths import java.nio.file.SimpleFileVisitor import java.nio.file.attribute.BasicFileAttributes -@Suppress("TooGenericExceptionCaught", "MagicNumber", "ReturnCount") +@Suppress("MagicNumber") class AutoUploadHelper(private val repository: FileSystemRepository) { companion object { private const val TAG = "AutoUploadHelper" diff --git a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt index 1851113ebab2..471a579fda80 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/AutoUploadWorker.kt @@ -57,7 +57,6 @@ import java.io.File import kotlin.coroutines.cancellation.CancellationException import kotlin.time.Duration.Companion.milliseconds -@Suppress("LongParameterList", "TooManyFunctions", "TooGenericExceptionCaught") class AutoUploadWorker( private val context: Context, params: WorkerParameters, @@ -90,7 +89,6 @@ class AutoUploadWorker( private val overridePowerSaving: Boolean get() = inputData.getBoolean(OVERRIDE_POWER_SAVING, false) - @Suppress("ReturnCount") override suspend fun doWork(): Result { return try { trySetForeground() @@ -178,7 +176,6 @@ class AutoUploadWorker( .setSilent(true) .build() - @Suppress("TooGenericExceptionCaught") private fun getStartNotificationTitle(): Pair? = try { val localPath = syncedFolder.localPath val remotePath = syncedFolder.remotePath @@ -195,7 +192,6 @@ class AutoUploadWorker( null } - @Suppress("ReturnCount") private fun isBlocked(syncedFolderID: Long): Boolean { if (powerManagementService.blocksAutoUpload && !overridePowerSaving) { Log_OC.w(TAG, "⚡ Skipping: device is in power saving mode") @@ -268,7 +264,7 @@ class AutoUploadWorker( } } - @Suppress("LongMethod", "DEPRECATION", "TooGenericExceptionCaught") + @Suppress("LongMethod", "DEPRECATION", "CyclomaticComplexMethod") private suspend fun uploadFiles(syncedFolder: SyncedFolder) = withContext(Dispatchers.IO) { val user = getUserOrReturn(syncedFolder) ?: return@withContext val ocAccount = OwnCloudAccount(user.toPlatformAccount(), context) @@ -425,7 +421,6 @@ class AutoUploadWorker( return lastUploadResult in conflictResults && syncedFolder.nameCollisionPolicy != NameCollisionPolicy.ASK_USER } - @Suppress("ReturnCount") private fun getEntityResult( user: User, localPath: String, diff --git a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/FileSystemRepository.kt b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/FileSystemRepository.kt index 375e60546cbc..eb79de7687a1 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/FileSystemRepository.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/FileSystemRepository.kt @@ -26,7 +26,7 @@ import java.util.zip.CRC32 import com.nextcloud.utils.AppConstants.BYTES_PER_KB import com.nextcloud.utils.AppConstants.MILLIS_PER_SECOND -@Suppress("TooGenericExceptionCaught", "NestedBlockDepth", "MagicNumber", "ReturnCount") +@Suppress("NestedBlockDepth", "MagicNumber") class FileSystemRepository( private val dao: FileSystemDao, private val uploadsStorageManager: UploadsStorageManager, diff --git a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/SyncFolderHelper.kt b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/SyncFolderHelper.kt index b8553cb4e661..8f4d99ad4067 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/autoUpload/SyncFolderHelper.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/autoUpload/SyncFolderHelper.kt @@ -85,7 +85,6 @@ class SyncFolderHelper(private val context: Context) { if (MediaFolderType.IMAGE == syncedFolder.type && hasExif(file)) { Log_OC.d(TAG, "calculateLastModificationTime exif found") - @Suppress("TooGenericExceptionCaught") try { val exifInterface = ExifInterface(file.absolutePath) val exifDate = exifInterface.getAttribute(ExifInterface.TAG_DATETIME) diff --git a/app/src/main/java/com/nextcloud/client/jobs/clipboard/ClipboardClearWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/clipboard/ClipboardClearWorker.kt index a32ee3c3a035..7569b00181bf 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/clipboard/ClipboardClearWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/clipboard/ClipboardClearWorker.kt @@ -22,7 +22,6 @@ class ClipboardClearWorker(private val context: Context, params: WorkerParameter const val CLIPBOARD_TEXT = "clipboard_text" } - @Suppress("TooGenericExceptionCaught", "ReturnCount") override fun doWork(): Result { try { val clipboardManager = context.getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager diff --git a/app/src/main/java/com/nextcloud/client/jobs/download/DownloadNotificationManager.kt b/app/src/main/java/com/nextcloud/client/jobs/download/DownloadNotificationManager.kt index d9f24de6b305..1910e67e96e6 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/download/DownloadNotificationManager.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/download/DownloadNotificationManager.kt @@ -18,7 +18,7 @@ import com.owncloud.android.ui.notifications.NotificationUtils import com.owncloud.android.utils.theme.ViewThemeUtils import java.security.SecureRandom -@Suppress("TooManyFunctions", "MagicNumber") +@Suppress("MagicNumber") class DownloadNotificationManager(id: Int, private val context: Context, viewThemeUtils: ViewThemeUtils) : WorkerNotificationManager( id, diff --git a/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadHelper.kt b/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadHelper.kt index f9bbcd71ce5a..492b22d4891d 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadHelper.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadHelper.kt @@ -112,7 +112,6 @@ class FileDownloadHelper { downloadFile(user, file, downloadType = DownloadType.DOWNLOAD) } - @Suppress("LongParameterList") fun downloadFile( user: User, ocFile: OCFile, diff --git a/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadWorker.kt index 48a7f45a3b7a..e1afbb18cb9a 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/download/FileDownloadWorker.kt @@ -42,7 +42,6 @@ import java.util.Optional import java.util.Vector import kotlin.random.Random -@Suppress("LongParameterList", "TooManyFunctions", "TooGenericExceptionCaught") class FileDownloadWorker( viewThemeUtils: ViewThemeUtils, private val accountManager: UserAccountManager, @@ -100,7 +99,6 @@ class FileDownloadWorker( private var downloadError: FileDownloadError? = null - @Suppress("ReturnCount") override suspend fun doWork(): Result { return try { setUser() @@ -245,7 +243,7 @@ class FileDownloadWorker( am.addOnAccountsUpdatedListener(this, null, false) } - @Suppress("TooGenericExceptionCaught", "DEPRECATION") + @Suppress("DEPRECATION") private suspend fun downloadFile(downloadKey: String) { currentDownload = pendingDownloads.get(downloadKey) diff --git a/app/src/main/java/com/nextcloud/client/jobs/download/SendShareDownloader.kt b/app/src/main/java/com/nextcloud/client/jobs/download/SendShareDownloader.kt index e44a85fc89d8..4134b15de983 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/download/SendShareDownloader.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/download/SendShareDownloader.kt @@ -88,7 +88,6 @@ class SendShareDownloader( fileWaitingToSend = savedInstanceState?.getParcelableArgument(KEY_FILE_WAITING_TO_SEND, OCFile::class.java) } - @Suppress("ReturnCount") private fun onDownloadCompleted(intent: Intent) { val waitingToSend = fileWaitingToSend ?: return diff --git a/app/src/main/java/com/nextcloud/client/jobs/folderDownload/FolderDownloadWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/folderDownload/FolderDownloadWorker.kt index 2f3cafd8f0dc..478f2a71a568 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/folderDownload/FolderDownloadWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/folderDownload/FolderDownloadWorker.kt @@ -32,7 +32,7 @@ import java.util.concurrent.ConcurrentHashMap /** * Only used for downloading files in first level of the folder, not subfolders. */ -@Suppress("LongMethod", "TooGenericExceptionCaught", "MagicNumber") +@Suppress("LongMethod", "MagicNumber") class FolderDownloadWorker( private val accountManager: UserAccountManager, private val context: Context, @@ -57,7 +57,7 @@ class FolderDownloadWorker( private val notificationManager = FolderDownloadWorkerNotificationManager(context, true, viewThemeUtils) private lateinit var storageManager: FileDataStorageManager - @Suppress("ReturnCount", "DEPRECATION") + @Suppress("DEPRECATION") override suspend fun doWork(): Result { val folderID = inputData.getLong(FOLDER_ID, -1) if (folderID == -1L) { @@ -166,7 +166,6 @@ class FolderDownloadWorker( } } - @Suppress("ReturnCount") override suspend fun getForegroundInfo(): ForegroundInfo { return try { val folderID = inputData.getLong(FOLDER_ID, -1) diff --git a/app/src/main/java/com/nextcloud/client/jobs/gallery/GalleryImageGenerationJob.kt b/app/src/main/java/com/nextcloud/client/jobs/gallery/GalleryImageGenerationJob.kt index b37ebf1d03c6..e08260f431ca 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/gallery/GalleryImageGenerationJob.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/gallery/GalleryImageGenerationJob.kt @@ -37,7 +37,7 @@ import kotlinx.coroutines.withContext import java.util.Collections import java.util.WeakHashMap -@Suppress("DEPRECATION", "TooGenericExceptionCaught", "ReturnCount") +@Suppress("DEPRECATION") class GalleryImageGenerationJob(private val user: User, private val storageManager: FileDataStorageManager) { companion object { diff --git a/app/src/main/java/com/nextcloud/client/jobs/metadata/MetadataWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/metadata/MetadataWorker.kt index be64cef7c9c5..7e5daabf4e37 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/metadata/MetadataWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/metadata/MetadataWorker.kt @@ -19,7 +19,7 @@ import com.owncloud.android.operations.RefreshFolderOperation import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.withContext -@Suppress("DEPRECATION", "ReturnCount", "TooGenericExceptionCaught") +@Suppress("DEPRECATION") class MetadataWorker(private val context: Context, params: WorkerParameters, private val user: User) : CoroutineWorker(context, params) { diff --git a/app/src/main/java/com/nextcloud/client/jobs/offlineOperations/OfflineOperationsWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/offlineOperations/OfflineOperationsWorker.kt index 3661cf002f00..cc13f4e667db 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/offlineOperations/OfflineOperationsWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/offlineOperations/OfflineOperationsWorker.kt @@ -57,7 +57,6 @@ class OfflineOperationsWorker( private val notificationManager = OfflineOperationsNotificationManager(context, viewThemeUtils) private var repository = OfflineOperationsRepository(fileDataStorageManager) - @Suppress("TooGenericExceptionCaught") override suspend fun doWork(): Result = withContext(Dispatchers.IO) { try { val jobName = inputData.getString(JOB_NAME) @@ -92,7 +91,6 @@ class OfflineOperationsWorker( } // region Handle offline operations - @Suppress("TooGenericExceptionCaught") private suspend fun processOperations(operations: List, client: OwnCloudClient) { val totalOperationSize = operations.size operations.forEachIndexed { index, operation -> @@ -183,7 +181,7 @@ class OfflineOperationsWorker( } // region Operation Execution - @Suppress("ComplexCondition", "LongMethod") + @Suppress("ComplexCondition", "LongMethod", "CyclomaticComplexMethod") private suspend fun executeOperation( operation: OfflineOperationEntity, client: OwnCloudClient diff --git a/app/src/main/java/com/nextcloud/client/jobs/operation/FileOperationHelper.kt b/app/src/main/java/com/nextcloud/client/jobs/operation/FileOperationHelper.kt index 6cbcb7766893..5d5eedc4c763 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/operation/FileOperationHelper.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/operation/FileOperationHelper.kt @@ -28,7 +28,7 @@ class FileOperationHelper( private val TAG = FileOperationHelper::class.java.simpleName } - @Suppress("TooGenericExceptionCaught", "Deprecation") + @Suppress("Deprecation") suspend fun removeFile( file: OCFile, onlyLocalCopy: Boolean, diff --git a/app/src/main/java/com/nextcloud/client/jobs/transfer/TransferManagerImpl.kt b/app/src/main/java/com/nextcloud/client/jobs/transfer/TransferManagerImpl.kt index 77ac0e1679f5..cdb735179b04 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/transfer/TransferManagerImpl.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/transfer/TransferManagerImpl.kt @@ -33,7 +33,6 @@ import com.nextcloud.utils.AppConstants.PROGRESS_PERCENTAGE_MIN * @param downloadTaskFactory Download task factory * @param threads maximum number of concurrent transfer processes */ -@Suppress("LongParameterList") // transfer operations requires those resources class TransferManagerImpl( private val runner: AsyncRunner, private val downloadTaskFactory: DownloadTask.Factory, diff --git a/app/src/main/java/com/nextcloud/client/jobs/upload/AlbumFileUploadWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/upload/AlbumFileUploadWorker.kt index e36a8972c201..79c9cd3be930 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/upload/AlbumFileUploadWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/upload/AlbumFileUploadWorker.kt @@ -54,7 +54,6 @@ import kotlin.random.Random * this worker is a replica of FileUploadWorker * this worker will take care of upload and then copying the uploaded files to selected Album */ -@Suppress("LongParameterList", "TooGenericExceptionCaught") class AlbumFileUploadWorker( val uploadsStorageManager: UploadsStorageManager, val connectivityService: ConnectivityService, @@ -192,7 +191,7 @@ class AlbumFileUploadWorker( .setSilent(true) .build() - @Suppress("ReturnCount", "LongMethod", "DEPRECATION") + @Suppress("LongMethod", "DEPRECATION") private suspend fun uploadFiles(): Result = withContext(Dispatchers.IO) { val accountName = inputData.getString(ACCOUNT) if (accountName == null) { @@ -336,7 +335,7 @@ class AlbumFileUploadWorker( addDataTransferProgressListener(this@AlbumFileUploadWorker) } - @Suppress("TooGenericExceptionCaught", "DEPRECATION") + @Suppress("DEPRECATION") private suspend fun upload( upload: OCUpload, operation: UploadFileOperation, diff --git a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadBroadcastReceiver.kt b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadBroadcastReceiver.kt index 830270fa6839..408ebcf9335f 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadBroadcastReceiver.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadBroadcastReceiver.kt @@ -32,7 +32,6 @@ class FileUploadBroadcastReceiver : BroadcastReceiver() { const val REMOVE = "REMOVE" } - @Suppress("ReturnCount") override fun onReceive(context: Context, intent: Intent) { MainApp.getAppComponent().inject(this) @@ -41,7 +40,6 @@ class FileUploadBroadcastReceiver : BroadcastReceiver() { } } - @Suppress("ReturnCount") private fun pauseAndCancel(context: Context, intent: Intent) { val uploadId = intent.getLongExtra(UPLOAD_ID, -1L) if (uploadId == -1L) { diff --git a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt index b0d3cc27c26c..8d404bdf8f82 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadHelper.kt @@ -60,7 +60,6 @@ import java.io.File import java.util.concurrent.atomic.AtomicBoolean import javax.inject.Inject -@Suppress("TooManyFunctions") class FileUploadHelper { @Inject @@ -265,7 +264,6 @@ class FileUploadHelper { ) } - @Suppress("LongParameterList") fun uploadAndCopyNewFilesForAlbum(data: OCUploadLocalPathData, albumName: String) { val uploads = getUploadsFromLocalPaths(data) backgroundJobManager.startAlbumFilesUploadJob( @@ -314,7 +312,6 @@ class FileUploadHelper { return upload } - @Suppress("ReturnCount") fun getUploadByPaths(accountName: String, localPath: String, remotePath: String): UploadEntity? { val entity = uploadsStorageManager.uploadDao.getUploadByAccountAndPaths( accountName, @@ -420,7 +417,6 @@ class FileUploadHelper { } } - @Suppress("ReturnCount") fun isUploading(remotePath: String?, accountName: String?): Boolean { accountName ?: return false if (!backgroundJobManager.isStartFileUploadJobScheduled(accountName)) { @@ -479,7 +475,6 @@ class FileUploadHelper { return conditions } - @Suppress("ReturnCount") fun isUploadingNow(upload: OCUpload?): Boolean { val currentUploadFileOperation = FileUploadWorker.getCurrentUpload(upload?.uploadId) if (currentUploadFileOperation == null || currentUploadFileOperation.user == null) return false @@ -605,7 +600,7 @@ class FileUploadHelper { } } - @Suppress("MagicNumber", "ReturnCount", "ComplexCondition") + @Suppress("MagicNumber", "ComplexCondition") fun isSameFileOnRemote(user: User?, localPath: String?, remotePath: String?, context: Context?): Boolean { if (user == null || localPath == null || remotePath == null || context == null) { Log_OC.e(TAG, "cannot compare remote and local file") diff --git a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt index e698f3850869..5544949f990e 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt @@ -58,7 +58,6 @@ import java.util.concurrent.ConcurrentHashMap import kotlin.random.Random import kotlin.time.Duration.Companion.milliseconds -@Suppress("LongParameterList", "TooGenericExceptionCaught") class FileUploadWorker( val uploadsStorageManager: UploadsStorageManager, val connectivityService: ConnectivityService, @@ -242,7 +241,7 @@ class FileUploadWorker( } } - @Suppress("ReturnCount", "LongMethod", "DEPRECATION") + @Suppress("LongMethod", "DEPRECATION", "CyclomaticComplexMethod") private suspend fun uploadFiles(): Result = withContext(Dispatchers.IO) { val accountName = inputData.getString(ACCOUNT) if (accountName == null) { @@ -385,7 +384,6 @@ class FileUploadWorker( else -> false } - @Suppress("ReturnCount") suspend fun isBelongToAnySyncedFolder( upload: OCUpload, syncFolderHelper: SyncFolderHelper, @@ -435,7 +433,7 @@ class FileUploadWorker( return result } - @Suppress("TooGenericExceptionCaught", "DEPRECATION") + @Suppress("DEPRECATION") private suspend fun upload( operation: UploadFileOperation, user: User, diff --git a/app/src/main/java/com/nextcloud/client/jobs/upload/UploadTask.kt b/app/src/main/java/com/nextcloud/client/jobs/upload/UploadTask.kt index efe129f8d765..7ab948dc9e0e 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/upload/UploadTask.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/upload/UploadTask.kt @@ -19,7 +19,6 @@ import com.owncloud.android.files.services.NameCollisionPolicy import com.owncloud.android.lib.common.OwnCloudClient import com.owncloud.android.operations.UploadFileOperation -@Suppress("LongParameterList") class UploadTask( private val applicationContext: Context, private val uploadsStorageManager: UploadsStorageManager, @@ -35,7 +34,6 @@ class UploadTask( * This class is a helper factory to to keep static dependencies * injection out of the upload task instance. */ - @Suppress("LongParameterList") class Factory( private val applicationContext: Context, private val uploadsStorageManager: UploadsStorageManager, diff --git a/app/src/main/java/com/nextcloud/client/jobs/utils/UploadErrorNotificationManager.kt b/app/src/main/java/com/nextcloud/client/jobs/utils/UploadErrorNotificationManager.kt index b23dc65962d7..c8f591180157 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/utils/UploadErrorNotificationManager.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/utils/UploadErrorNotificationManager.kt @@ -46,7 +46,6 @@ object UploadErrorNotificationManager { * * @param onSameFileConflict Triggered only if result code is CONFLICT or SYNC_CONFLICT and files are identical. */ - @Suppress("ReturnCount") suspend fun handleResult( context: Context, notificationManager: WorkerNotificationManager, diff --git a/app/src/main/java/com/nextcloud/client/jobs/worker/WorkerFilesPayload.kt b/app/src/main/java/com/nextcloud/client/jobs/worker/WorkerFilesPayload.kt index 1591f9964c3a..799510063138 100644 --- a/app/src/main/java/com/nextcloud/client/jobs/worker/WorkerFilesPayload.kt +++ b/app/src/main/java/com/nextcloud/client/jobs/worker/WorkerFilesPayload.kt @@ -13,7 +13,6 @@ import com.owncloud.android.lib.common.utils.Log_OC import com.owncloud.android.utils.FileStorageUtils import java.io.File -@Suppress("ReturnCount") object WorkerFilesPayload { private const val TAG = "WorkerFilesPayload" private const val FILE_PREFIX = "worker_files_payload_" diff --git a/app/src/main/java/com/nextcloud/client/logger/LogEntry.kt b/app/src/main/java/com/nextcloud/client/logger/LogEntry.kt index f105a5550070..be5a106362cb 100644 --- a/app/src/main/java/com/nextcloud/client/logger/LogEntry.kt +++ b/app/src/main/java/com/nextcloud/client/logger/LogEntry.kt @@ -45,7 +45,6 @@ data class LogEntry(val timestamp: Date, val level: Level, val tag: String, val } } - @Suppress("ReturnCount") @JvmStatic fun parse(s: String): LogEntry? { val result = ENTRY_PARSE_REGEXP.matchEntire(s) ?: return null diff --git a/app/src/main/java/com/nextcloud/client/logger/LoggerImpl.kt b/app/src/main/java/com/nextcloud/client/logger/LoggerImpl.kt index fad910d4576d..b4ab48bd0bf1 100644 --- a/app/src/main/java/com/nextcloud/client/logger/LoggerImpl.kt +++ b/app/src/main/java/com/nextcloud/client/logger/LoggerImpl.kt @@ -16,7 +16,6 @@ import java.util.concurrent.TimeUnit import java.util.concurrent.atomic.AtomicBoolean import java.util.concurrent.atomic.AtomicLong -@Suppress("TooManyFunctions") internal class LoggerImpl( private val clock: Clock, private val handler: FileLogHandler, diff --git a/app/src/main/java/com/nextcloud/client/migrations/MigrationsManagerImpl.kt b/app/src/main/java/com/nextcloud/client/migrations/MigrationsManagerImpl.kt index eb7a7cc2b16c..ee26f44b1922 100644 --- a/app/src/main/java/com/nextcloud/client/migrations/MigrationsManagerImpl.kt +++ b/app/src/main/java/com/nextcloud/client/migrations/MigrationsManagerImpl.kt @@ -30,7 +30,6 @@ internal class MigrationsManagerImpl( } @Throws(MigrationError::class) - @Suppress("ReturnCount") override fun startMigration(): Int { if (migrationsDb.isFailed) { (status as MutableLiveData).value = Status.FAILED @@ -61,7 +60,6 @@ internal class MigrationsManagerImpl( */ private fun asyncApplyMigrations(migrations: Collection) { migrations.forEach { - @Suppress("TooGenericExceptionCaught") // migration code is free to throw anything try { it.run.invoke(it) migrationsDb.addAppliedMigration(it.id) diff --git a/app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.kt b/app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.kt index fb8cc7123d9e..a272a030aa0a 100644 --- a/app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.kt +++ b/app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.kt @@ -27,7 +27,6 @@ import java.net.UnknownHostException import javax.net.ssl.SSLException import kotlin.time.Duration.Companion.seconds -@Suppress("TooGenericExceptionCaught", "ReturnCount") class ConnectivityServiceImpl( context: Context, private val accountManager: UserAccountManager, diff --git a/app/src/main/java/com/nextcloud/client/player/media3/PlaybackModel.kt b/app/src/main/java/com/nextcloud/client/player/media3/PlaybackModel.kt index 93da645e7286..70608ad90385 100644 --- a/app/src/main/java/com/nextcloud/client/player/media3/PlaybackModel.kt +++ b/app/src/main/java/com/nextcloud/client/player/media3/PlaybackModel.kt @@ -51,7 +51,6 @@ import com.nextcloud.utils.AppConstants.ONE_SECOND @Singleton @OptIn(markerClass = [UnstableApi::class]) -@Suppress("TooManyFunctions") class PlaybackModel @Inject constructor( private val context: Context, private val mediaSessionFactory: MediaSessionFactory, @@ -163,7 +162,6 @@ class PlaybackModel @Inject constructor( controllerScope = null } - @Suppress("TooGenericExceptionCaught") private suspend fun ListenableFuture.await(): T = suspendCancellableCoroutine { cont -> addListener( { diff --git a/app/src/main/java/com/nextcloud/client/player/media3/session/MediaSessionCallback.kt b/app/src/main/java/com/nextcloud/client/player/media3/session/MediaSessionCallback.kt index ffd8d296c599..447fab5b75be 100644 --- a/app/src/main/java/com/nextcloud/client/player/media3/session/MediaSessionCallback.kt +++ b/app/src/main/java/com/nextcloud/client/player/media3/session/MediaSessionCallback.kt @@ -65,7 +65,6 @@ class MediaSessionCallback @Inject constructor( } @OptIn(DelicateCoroutinesApi::class) - @Suppress("TooGenericExceptionCaught") override fun onPlaybackResumption( mediaSession: MediaSession, controller: MediaSession.ControllerInfo, diff --git a/app/src/main/java/com/nextcloud/client/player/util/PlayerUtil.kt b/app/src/main/java/com/nextcloud/client/player/util/PlayerUtil.kt index 5638106b7fdf..2e7ba0f6e16e 100644 --- a/app/src/main/java/com/nextcloud/client/player/util/PlayerUtil.kt +++ b/app/src/main/java/com/nextcloud/client/player/util/PlayerUtil.kt @@ -45,7 +45,6 @@ import java.io.File import java.util.Collections import com.nextcloud.utils.AppConstants.MILLIS_PER_SECOND -@Suppress("TooManyFunctions") object PlayerUtil { const val REMOTE_FILE_SCHEME = "remoteFile" diff --git a/app/src/main/java/com/nextcloud/client/systembars/SystemBarBackgroundCallbacks.kt b/app/src/main/java/com/nextcloud/client/systembars/SystemBarBackgroundCallbacks.kt index cc70d9d67dfc..1f2fd258b023 100644 --- a/app/src/main/java/com/nextcloud/client/systembars/SystemBarBackgroundCallbacks.kt +++ b/app/src/main/java/com/nextcloud/client/systembars/SystemBarBackgroundCallbacks.kt @@ -39,7 +39,6 @@ class SystemBarBackgroundCallbacks(private val viewThemeUtilsProvider: Provider< private fun isExcluded(activity: Activity): Boolean = excludedActivities.any { it.isInstance(activity) } @JvmStatic - @Suppress("ReturnCount") fun apply(activity: Activity, viewThemeUtils: ViewThemeUtils) { if (isExcluded(activity)) return diff --git a/app/src/main/java/com/nextcloud/client/widget/DashboardWidgetService.kt b/app/src/main/java/com/nextcloud/client/widget/DashboardWidgetService.kt index dedd888271f1..6ac76dc2dae0 100644 --- a/app/src/main/java/com/nextcloud/client/widget/DashboardWidgetService.kt +++ b/app/src/main/java/com/nextcloud/client/widget/DashboardWidgetService.kt @@ -156,7 +156,6 @@ class StackRemoteViewsFactory( remoteViews.setRemoteImageView(bitmap) } - @Suppress("TooGenericExceptionCaught") private fun RemoteViews.setRemoteImageView(source: Bitmap) { try { val bitmap: Bitmap = if (widgetConfiguration.roundIcon) { diff --git a/app/src/main/java/com/nextcloud/model/SearchResultEntryType.kt b/app/src/main/java/com/nextcloud/model/SearchResultEntryType.kt index 7eb6068fb1d0..982be1f47e09 100644 --- a/app/src/main/java/com/nextcloud/model/SearchResultEntryType.kt +++ b/app/src/main/java/com/nextcloud/model/SearchResultEntryType.kt @@ -32,6 +32,7 @@ enum class SearchResultEntryType { Avatar, Unknown; + @Suppress("CyclomaticComplexMethod") fun iconId(): Int = when (this) { Avatar -> R.drawable.ic_user CalendarEvent -> R.drawable.file_calendar diff --git a/app/src/main/java/com/nextcloud/repository/RemoteClientRepository.kt b/app/src/main/java/com/nextcloud/repository/RemoteClientRepository.kt index 7b4c197e68c6..b4d42f188edb 100644 --- a/app/src/main/java/com/nextcloud/repository/RemoteClientRepository.kt +++ b/app/src/main/java/com/nextcloud/repository/RemoteClientRepository.kt @@ -20,7 +20,7 @@ import kotlinx.coroutines.launch import kotlinx.coroutines.withContext import javax.inject.Inject -@Suppress("TooGenericExceptionCaught", "DEPRECATION") +@Suppress("DEPRECATION") class RemoteClientRepository @Inject constructor( private val context: Context, private val accountManager: UserAccountManager, diff --git a/app/src/main/java/com/nextcloud/ui/component/UploadWarningCard.kt b/app/src/main/java/com/nextcloud/ui/component/UploadWarningCard.kt index a4599f5b760b..ba4b06421637 100644 --- a/app/src/main/java/com/nextcloud/ui/component/UploadWarningCard.kt +++ b/app/src/main/java/com/nextcloud/ui/component/UploadWarningCard.kt @@ -29,7 +29,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("LongParameterList") class UploadWarningCard( private val context: Context, private val powerManagementService: PowerManagementService, diff --git a/app/src/main/java/com/nextcloud/ui/composeComponents/alertDialog/SimpleAlertDialog.kt b/app/src/main/java/com/nextcloud/ui/composeComponents/alertDialog/SimpleAlertDialog.kt index 738c9ddc1bab..987aa3d0059d 100644 --- a/app/src/main/java/com/nextcloud/ui/composeComponents/alertDialog/SimpleAlertDialog.kt +++ b/app/src/main/java/com/nextcloud/ui/composeComponents/alertDialog/SimpleAlertDialog.kt @@ -23,7 +23,6 @@ import androidx.compose.ui.res.stringResource import androidx.compose.ui.unit.dp import com.owncloud.android.R -@Suppress("LongParameterList") @Composable fun SimpleAlertDialog( title: String, diff --git a/app/src/main/java/com/nextcloud/ui/fileInfo/FileInfoRepository.kt b/app/src/main/java/com/nextcloud/ui/fileInfo/FileInfoRepository.kt index cb6475a180f9..484e6dba9825 100644 --- a/app/src/main/java/com/nextcloud/ui/fileInfo/FileInfoRepository.kt +++ b/app/src/main/java/com/nextcloud/ui/fileInfo/FileInfoRepository.kt @@ -85,7 +85,6 @@ class FileInfoRepository @Inject constructor(private val clientFactory: ClientFa else -> LabelOperationResult.Failure } - @Suppress("TooGenericExceptionCaught") private suspend fun execute(user: User, default: T, errorMessage: String, block: (NextcloudClient) -> T): T = withContext(Dispatchers.IO) { val client = client(user) ?: return@withContext default diff --git a/app/src/main/java/com/nextcloud/ui/fileInfo/ImageDetailInfo.kt b/app/src/main/java/com/nextcloud/ui/fileInfo/ImageDetailInfo.kt index 11eced485f55..7e01e0f872a6 100644 --- a/app/src/main/java/com/nextcloud/ui/fileInfo/ImageDetailInfo.kt +++ b/app/src/main/java/com/nextcloud/ui/fileInfo/ImageDetailInfo.kt @@ -224,7 +224,6 @@ class ImageDetailInfo(private val fragment: FileInfoFragment, private val viewTh SimpleDateFormat("y:M:d H:m:s", Locale.ROOT).parse(it)?.time } ?: fallback - @Suppress("ReturnCount") private fun parseExposure(exif: ExifInterface): String? { val shutterSpeed = exif.getAttribute(ExifInterface.TAG_SHUTTER_SPEED_VALUE) val exposureTime = exif.getAttribute(ExifInterface.TAG_EXPOSURE_TIME) diff --git a/app/src/main/java/com/nextcloud/ui/fileactions/ClientIntegration.kt b/app/src/main/java/com/nextcloud/ui/fileactions/ClientIntegration.kt index ef10a692afdd..1857507773b8 100644 --- a/app/src/main/java/com/nextcloud/ui/fileactions/ClientIntegration.kt +++ b/app/src/main/java/com/nextcloud/ui/fileactions/ClientIntegration.kt @@ -107,7 +107,6 @@ class ClientIntegration( return itemBinding.root } - @Suppress("ReturnCount") private fun prepareDrawableForTinting(drawable: Drawable?): Drawable? { if (drawable == null) { return null diff --git a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHandler.kt b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHandler.kt index 5f6a06aac968..115178418cc6 100644 --- a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHandler.kt +++ b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHandler.kt @@ -27,7 +27,6 @@ import com.owncloud.android.utils.FileStorageUtils import com.owncloud.android.utils.theme.ViewThemeUtils import javax.inject.Inject -@Suppress("LongParameterList") class FileActionHandler @Inject constructor( private val backgroundJobManager: BackgroundJobManager, private val accountManager: UserAccountManager, diff --git a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHost.kt b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHost.kt index 385a86cc709c..3540e257cf2e 100644 --- a/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHost.kt +++ b/app/src/main/java/com/nextcloud/ui/fileactions/FileActionHost.kt @@ -16,7 +16,6 @@ import com.owncloud.android.ui.activity.FileDisplayActivity import com.owncloud.android.ui.fragment.FileFragment import com.owncloud.android.ui.helpers.FileOperationsHelper -@Suppress("LongParameterList") class FileActionHost @JvmOverloads constructor( val containerActivity: FileFragment.ContainerActivity, val fragmentManager: FragmentManager, diff --git a/app/src/main/java/com/nextcloud/utils/BatteryOptimizationHelper.kt b/app/src/main/java/com/nextcloud/utils/BatteryOptimizationHelper.kt index eb4add0298c1..ec91d0714bb9 100644 --- a/app/src/main/java/com/nextcloud/utils/BatteryOptimizationHelper.kt +++ b/app/src/main/java/com/nextcloud/utils/BatteryOptimizationHelper.kt @@ -24,7 +24,6 @@ object BatteryOptimizationHelper { return !pm.isIgnoringBatteryOptimizations(context.packageName) } - @Suppress("TooGenericExceptionCaught") @SuppressLint("BatteryLife") fun openBatteryOptimizationSettings(context: Context) { try { diff --git a/app/src/main/java/com/nextcloud/utils/BitmapExtensions.kt b/app/src/main/java/com/nextcloud/utils/BitmapExtensions.kt index 834bdec67455..ddd728349ff1 100644 --- a/app/src/main/java/com/nextcloud/utils/BitmapExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/BitmapExtensions.kt @@ -70,7 +70,7 @@ fun Bitmap.scaleUntil(targetKB: Int): Bitmap { * @see ExifInterface * @see Matrix */ -@Suppress("MagicNumber", "ReturnCount") +@Suppress("MagicNumber") fun Bitmap?.rotateBitmapViaExif(orientation: Int): Bitmap? { if (this == null) { return null @@ -143,7 +143,6 @@ fun Bitmap?.rotateBitmapViaExif(orientation: Int): Bitmap? { * @param reqHeight Desired height in pixels of the output bitmap. * @return The decoded [Bitmap], or `null` if the file does not exist or decoding fails. */ -@Suppress("TooGenericExceptionCaught") fun decodeSampledBitmapFromFile(srcPath: String?, reqWidth: Int, reqHeight: Int): Bitmap? { // check existence of file srcPath?.toFile() ?: return null diff --git a/app/src/main/java/com/nextcloud/utils/ForegroundServiceHelper.kt b/app/src/main/java/com/nextcloud/utils/ForegroundServiceHelper.kt index c46c314845bd..7ec541227959 100644 --- a/app/src/main/java/com/nextcloud/utils/ForegroundServiceHelper.kt +++ b/app/src/main/java/com/nextcloud/utils/ForegroundServiceHelper.kt @@ -20,7 +20,6 @@ object ForegroundServiceHelper { private const val TAG = "ForegroundServiceHelper" private val isAboveOrEqualAndroid10 = Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q - @Suppress("TooGenericExceptionCaught") fun startService( service: Service, id: Int, diff --git a/app/src/main/java/com/nextcloud/utils/GlideHelper.kt b/app/src/main/java/com/nextcloud/utils/GlideHelper.kt index 2b03442c776f..0130095a2ad4 100644 --- a/app/src/main/java/com/nextcloud/utils/GlideHelper.kt +++ b/app/src/main/java/com/nextcloud/utils/GlideHelper.kt @@ -49,11 +49,9 @@ import kotlinx.coroutines.withContext * Provides methods for loading images into `ImageView`, `Target`, `Target` ... * from both URLs and URIs. */ -@Suppress("TooManyFunctions", "TooGenericExceptionCaught") object GlideHelper { private const val TAG = "GlideHelper" - @Suppress("TooGenericExceptionCaught") fun getBitmap(context: Context, url: String?): Bitmap? { val validatedUrl = validateAndGetURL(url) ?: return null @@ -280,7 +278,7 @@ object GlideHelper { .centerCrop() } - @Suppress("UNCHECKED_CAST", "TooGenericExceptionCaught", "ReturnCount") + @Suppress("UNCHECKED_CAST") private fun createRequestBuilder(context: Context, client: NextcloudClient?, url: String?): RequestBuilder? { if (client == null) { Log_OC.e(TAG, "Client is null") diff --git a/app/src/main/java/com/nextcloud/utils/LinkHelper.kt b/app/src/main/java/com/nextcloud/utils/LinkHelper.kt index 75ee63098667..94c6253116ff 100644 --- a/app/src/main/java/com/nextcloud/utils/LinkHelper.kt +++ b/app/src/main/java/com/nextcloud/utils/LinkHelper.kt @@ -50,7 +50,6 @@ object LinkHelper { /** * Validates if a URL string is valid */ - @Suppress("TooGenericExceptionCaught", "ReturnCount") fun validateAndGetURL(url: String?): String? { if (url.isNullOrBlank()) { Log_OC.w(TAG, "Given url is null or blank") diff --git a/app/src/main/java/com/nextcloud/utils/OCFileUtils.kt b/app/src/main/java/com/nextcloud/utils/OCFileUtils.kt index 8e227033fe33..dee5782c5299 100644 --- a/app/src/main/java/com/nextcloud/utils/OCFileUtils.kt +++ b/app/src/main/java/com/nextcloud/utils/OCFileUtils.kt @@ -17,7 +17,6 @@ import com.owncloud.android.datamodel.OCFile import com.owncloud.android.lib.common.utils.Log_OC import com.owncloud.android.utils.MimeTypeUtil -@Suppress("TooGenericExceptionCaught", "ReturnCount") object OCFileUtils { private const val TAG = "OCFileUtils" private const val IMAGE_SIZE_CACHE_ENTRIES = 2048 diff --git a/app/src/main/java/com/nextcloud/utils/ResultParser.kt b/app/src/main/java/com/nextcloud/utils/ResultParser.kt index af8eab677381..fe9de0fe2e7f 100644 --- a/app/src/main/java/com/nextcloud/utils/ResultParser.kt +++ b/app/src/main/java/com/nextcloud/utils/ResultParser.kt @@ -10,7 +10,7 @@ package com.nextcloud.utils import com.owncloud.android.lib.common.operations.RemoteOperationResult object ResultParser { - @Suppress("DEPRECATION", "ReturnCount") + @Suppress("DEPRECATION") @JvmStatic fun RemoteOperationResult<*>.list(type: Class): List { if (!isSuccess) return emptyList() diff --git a/app/src/main/java/com/nextcloud/utils/autoRename/AutoRename.kt b/app/src/main/java/com/nextcloud/utils/autoRename/AutoRename.kt index 11dba9a9190b..c16d223f10f5 100644 --- a/app/src/main/java/com/nextcloud/utils/autoRename/AutoRename.kt +++ b/app/src/main/java/com/nextcloud/utils/autoRename/AutoRename.kt @@ -22,7 +22,7 @@ object AutoRename { private const val TAG = "AutoRename" private const val REPLACEMENT = "_" - @Suppress("NestedBlockDepth") + @Suppress("NestedBlockDepth", "CyclomaticComplexMethod") @JvmOverloads fun rename(filename: String, capability: OCCapability, isFolderPath: Boolean? = null): String { if (!capability.checkWCFRestrictions()) { diff --git a/app/src/main/java/com/nextcloud/utils/avatar/AvatarGenerator.kt b/app/src/main/java/com/nextcloud/utils/avatar/AvatarGenerator.kt index 873b4eaca5a9..bf01784458df 100644 --- a/app/src/main/java/com/nextcloud/utils/avatar/AvatarGenerator.kt +++ b/app/src/main/java/com/nextcloud/utils/avatar/AvatarGenerator.kt @@ -30,7 +30,6 @@ import java.lang.ref.WeakReference import javax.inject.Inject import javax.inject.Singleton -@Suppress("LongParameterList") @Singleton class AvatarGenerator @Inject constructor( private val context: Context, @@ -106,7 +105,6 @@ class AvatarGenerator @Inject constructor( } } - @Suppress("TooGenericExceptionCaught") private fun createInitialAvatar(displayName: String?, radius: Float): Drawable? = try { TextDrawable.createAvatarByUserId(displayName, radius) } catch (e: Exception) { diff --git a/app/src/main/java/com/nextcloud/utils/avatar/AvatarLoader.kt b/app/src/main/java/com/nextcloud/utils/avatar/AvatarLoader.kt index 1a218f79da4b..fc92e3221d66 100644 --- a/app/src/main/java/com/nextcloud/utils/avatar/AvatarLoader.kt +++ b/app/src/main/java/com/nextcloud/utils/avatar/AvatarLoader.kt @@ -27,7 +27,6 @@ import org.apache.commons.httpclient.methods.GetMethod import javax.inject.Inject import kotlin.time.Duration.Companion.hours -@Suppress("TooGenericExceptionCaught") class AvatarLoader @Inject constructor( private val context: Context, private val arbitraryDataProvider: ArbitraryDataProvider, diff --git a/app/src/main/java/com/nextcloud/utils/e2ee/E2ECounterHelper.kt b/app/src/main/java/com/nextcloud/utils/e2ee/E2ECounterHelper.kt index 05114b7f8ea3..cfc62d42744a 100644 --- a/app/src/main/java/com/nextcloud/utils/e2ee/E2ECounterHelper.kt +++ b/app/src/main/java/com/nextcloud/utils/e2ee/E2ECounterHelper.kt @@ -16,7 +16,6 @@ object E2ECounterHelper { private const val NO_METADATA_COUNTER = -1L private const val INCREMENTER = 1L - @Suppress("ReturnCount") fun getCounter(context: Context, parentFile: OCFile, metadata: Any?): Long { if (!E2EVersionHelper.isV2Plus(context)) { return NO_METADATA_COUNTER diff --git a/app/src/main/java/com/nextcloud/utils/e2ee/E2EEActionResolver.kt b/app/src/main/java/com/nextcloud/utils/e2ee/E2EEActionResolver.kt index 21c23cdb6806..7b09a81ad08a 100644 --- a/app/src/main/java/com/nextcloud/utils/e2ee/E2EEActionResolver.kt +++ b/app/src/main/java/com/nextcloud/utils/e2ee/E2EEActionResolver.kt @@ -22,7 +22,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.withContext import javax.inject.Inject -@Suppress("LongParameterList") class E2EEActionResolver @Inject constructor( private val storageManager: FileDataStorageManager, private val arbitraryDataProvider: ArbitraryDataProvider, diff --git a/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt b/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt index 80844ecbbff6..b6f4cd6c9b13 100644 --- a/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt +++ b/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt @@ -31,7 +31,6 @@ import kotlinx.coroutines.withContext import org.apache.commons.httpclient.HttpStatus import javax.inject.Inject -@Suppress("TooGenericExceptionCaught", "ReturnCount") class E2EEKeyInspector @Inject constructor( private val context: Context, private val storageManager: FileDataStorageManager, diff --git a/app/src/main/java/com/nextcloud/utils/e2ee/model/E2EEKeyCheck.kt b/app/src/main/java/com/nextcloud/utils/e2ee/model/E2EEKeyCheck.kt index 38764220c6ef..17e1a328f2db 100644 --- a/app/src/main/java/com/nextcloud/utils/e2ee/model/E2EEKeyCheck.kt +++ b/app/src/main/java/com/nextcloud/utils/e2ee/model/E2EEKeyCheck.kt @@ -55,6 +55,7 @@ enum class E2EEKeyCheck { else -> null } + @Suppress("CyclomaticComplexMethod") fun getMessageId(action: E2EEAction): Int? = when (this) { NO_NETWORK -> when (action) { E2EEAction.NEW_FOLDER -> { diff --git a/app/src/main/java/com/nextcloud/utils/extensions/ContextExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/ContextExtensions.kt index b19132e6f89f..7780b85d8753 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/ContextExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/ContextExtensions.kt @@ -28,7 +28,6 @@ import com.owncloud.android.datamodel.ReceiverFlag private const val TAG = "ContextExtensions" -@Suppress("TooGenericExceptionCaught") fun Context.isWebViewAvailable(): Boolean = try { WebViewCompat.getCurrentWebViewPackage(this) != null } catch (e: Exception) { diff --git a/app/src/main/java/com/nextcloud/utils/extensions/FileDataStorageManagerExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/FileDataStorageManagerExtensions.kt index 09ef5ae25761..4b374782de3f 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/FileDataStorageManagerExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/FileDataStorageManagerExtensions.kt @@ -128,7 +128,6 @@ fun FileDataStorageManager.getNonEncryptedSubfolders(id: Long, accountName: Stri suspend fun FileDataStorageManager.getCapabilitiesByAccountName(accountName: String): OCCapability = capabilityDao.getByAccountName(accountName).toOCCapability() -@Suppress("ReturnCount") fun FileDataStorageManager.moveFiles(ocFile: OCFile?, targetPath: String, targetParentPath: String) { Log_OC.d( FileDataStorageManager.TAG, @@ -201,7 +200,6 @@ fun FileDataStorageManager.moveFiles(ocFile: OCFile?, targetPath: String, target */ private const val MAX_CONFLICT_RESOLUTION_ATTEMPTS = 10 -@Suppress("ReturnCount") fun getRemotePathForConflictResolution(client: OwnCloudClient, remotePath: String, fileName: String): String? { var name = fileName repeat(MAX_CONFLICT_RESOLUTION_ATTEMPTS) { @@ -258,7 +256,6 @@ fun generateFileNameForConflictResolution(fileName: String): String { return "$nameFirstPart$nameLastPart" } -@Suppress("ReturnCount") private fun moveLocalFiles(accountName: String, ocFile: OCFile, defaultSavePath: String, targetPath: String): Boolean { val localFile = File(FileStorageUtils.getDefaultSavePathFor(accountName, ocFile)) if (!localFile.exists()) { diff --git a/app/src/main/java/com/nextcloud/utils/extensions/FileExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/FileExtensions.kt index 8c6fddfdcb22..ba28525f7ae7 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/FileExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/FileExtensions.kt @@ -5,8 +5,6 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -@file:Suppress("TooManyFunctions") - package com.nextcloud.utils.extensions import android.graphics.Bitmap @@ -69,7 +67,6 @@ fun Path.toLocalPath(): String = toAbsolutePath().toString() * @receiver String path to a file. * @return [File] instance if the file exists, or `null` if the path is null, empty, or non-existent. */ -@Suppress("ReturnCount") fun String?.toFile(): File? { if (isNullOrEmpty()) { Log_OC.w(TAG, "given path is null or empty: $this") diff --git a/app/src/main/java/com/nextcloud/utils/extensions/OCCapabilityExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/OCCapabilityExtensions.kt index 2e7aa86bc4c8..5ce37065f740 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/OCCapabilityExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/OCCapabilityExtensions.kt @@ -52,7 +52,6 @@ fun OCCapability.shouldRemoveNonPrintableUnicodeCharactersAndConvertToUTF8(): Bo forbiddenFilenameExtensions().isNotEmpty() || forbiddenFilenameBaseNames().isNotEmpty() -@Suppress("ReturnCount", "TooGenericExceptionCaught") fun jsonToList(json: String?): List { if (json.isNullOrBlank()) return emptyList() diff --git a/app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt index a73459ec781b..5ffe8829d85e 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt @@ -39,7 +39,6 @@ fun OCFile?.isPNG(): Boolean { return "image/png".equals(mimeType, ignoreCase = true) } -@Suppress("ReturnCount") fun OCFile?.getDepth(): OCFileDepth? { if (this == null) { return null diff --git a/app/src/main/java/com/nextcloud/utils/extensions/RemoteFileExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/RemoteFileExtensions.kt index 108840b5138e..874e02d133d6 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/RemoteFileExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/RemoteFileExtensions.kt @@ -53,7 +53,6 @@ fun RemoteFile.toAlbumItem(): OCFile = FileStorageUtils.fillOCFile(this).apply { remoteId = this@toAlbumItem.localId.toString() } -@Suppress("ReturnCount") @VisibleForTesting fun RemoteFile.areImageDimensionsSame(path: String): Boolean { if (!MimeTypeUtil.isImage(mimeType)) { diff --git a/app/src/main/java/com/nextcloud/utils/extensions/RemoteOperationResultExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/RemoteOperationResultExtensions.kt index ea7410b45149..cb5f3781a6ff 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/RemoteOperationResultExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/RemoteOperationResultExtensions.kt @@ -14,7 +14,6 @@ import com.owncloud.android.lib.common.operations.RemoteOperationResult import com.owncloud.android.lib.common.operations.RemoteOperationResult.ResultCode import com.owncloud.android.utils.ErrorMessageAdapter -@Suppress("ReturnCount") fun Pair?, RemoteOperation<*>?>?.getErrorMessage(): String { val result = this?.first ?: return MainApp.string(R.string.unexpected_error_occurred) val operation = this.second ?: return MainApp.string(R.string.unexpected_error_occurred) diff --git a/app/src/main/java/com/nextcloud/utils/extensions/SearchResultEntryExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/SearchResultEntryExtensions.kt index 1ef7b7adadb0..1fb597b1c40c 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/SearchResultEntryExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/SearchResultEntryExtensions.kt @@ -17,6 +17,7 @@ private const val PREVIEW_PATH = "/core/preview" private const val PREVIEW_WIDTH_PARAMETER = "x" private const val PREVIEW_HEIGHT_PARAMETER = "y" +@Suppress("CyclomaticComplexMethod") fun SearchResultEntry.getType(): SearchResultEntryType { val value = icon.lowercase() diff --git a/app/src/main/java/com/nextcloud/utils/extensions/SyncedFolderExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/SyncedFolderExtensions.kt index 5041388ee99c..cfb62403b32e 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/SyncedFolderExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/SyncedFolderExtensions.kt @@ -22,7 +22,6 @@ private const val TAG = "SyncedFolderExtensions" /** * Determines whether a file should be skipped during auto-upload based on folder settings. */ -@Suppress("ReturnCount") fun SyncedFolder.shouldSkipFile( file: File, lastModified: Long, @@ -67,7 +66,6 @@ fun List.filterEnabledOrWithoutEnabledParent(): List.hasEnabledParent(localPath: String?): Boolean { localPath ?: return false @@ -78,7 +76,7 @@ fun List.hasEnabledParent(localPath: String?): Boolean { hasEnabledParent(parent.absolutePath) } -@Suppress("MagicNumber", "ReturnCount") +@Suppress("MagicNumber") fun SyncedFolder.calculateScanInterval( connectivityService: ConnectivityService, powerManagementService: PowerManagementService diff --git a/app/src/main/java/com/nextcloud/utils/extensions/TextViewExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/TextViewExtensions.kt index 11e622f420e8..aa457c721e4d 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/TextViewExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/TextViewExtensions.kt @@ -11,7 +11,6 @@ import android.text.method.LinkMovementMethod import android.widget.TextView import androidx.core.text.HtmlCompat -@Suppress("NewLineAtEndOfFile") fun TextView.setHtmlContent(value: String) { movementMethod = LinkMovementMethod.getInstance() text = HtmlCompat.fromHtml(value, HtmlCompat.FROM_HTML_MODE_LEGACY) diff --git a/app/src/main/java/com/nextcloud/utils/extensions/ThumbnailsCacheManagerExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/ThumbnailsCacheManagerExtensions.kt index 962c586c5173..9ea52d55d11e 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/ThumbnailsCacheManagerExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/ThumbnailsCacheManagerExtensions.kt @@ -31,7 +31,7 @@ import com.owncloud.android.lib.common.utils.Log_OC * @see ExifInterface * @see MediaStore.Images.Media.ORIENTATION */ -@Suppress("TooGenericExceptionCaught", "NestedBlockDepth", "MagicNumber") +@Suppress("NestedBlockDepth", "MagicNumber") fun getExifOrientation(path: String): Int { val context = MainApp.getAppContext() if (context == null || path.isBlank()) { diff --git a/app/src/main/java/com/nextcloud/utils/extensions/UploadResultExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/UploadResultExtensions.kt index bedf7b922973..ab18d4add992 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/UploadResultExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/UploadResultExtensions.kt @@ -31,6 +31,7 @@ fun UploadResult.isNonRetryable(): Boolean = when (this) { else -> false } +@Suppress("CyclomaticComplexMethod") fun UploadResult.getFailedStatusText(context: Context): String = when (this) { UploadResult.CREDENTIAL_ERROR -> context.getString(R.string.uploads_view_upload_status_failed_credentials_error) diff --git a/app/src/main/java/com/nextcloud/utils/extensions/UserAccountManagerExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/UserAccountManagerExtensions.kt index 51cffc0a7de2..1d28f42480ef 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/UserAccountManagerExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/UserAccountManagerExtensions.kt @@ -18,7 +18,7 @@ private const val TAG = "UserAccountManagerExtensions" fun UserAccountManager.createOwncloudClient(): OwnCloudClient? = createOwncloudClient(currentAccount.name) -@Suppress("TooGenericExceptionCaught", "ReturnCount", "DEPRECATION") +@Suppress("DEPRECATION") fun UserAccountManager.createOwncloudClient(accountName: String): OwnCloudClient? { val context = context ?: MainApp.getAppContext() if (context == null) { diff --git a/app/src/main/java/com/nextcloud/utils/extensions/UserExtensions.kt b/app/src/main/java/com/nextcloud/utils/extensions/UserExtensions.kt index 327b004bfa43..f5351ed086a7 100644 --- a/app/src/main/java/com/nextcloud/utils/extensions/UserExtensions.kt +++ b/app/src/main/java/com/nextcloud/utils/extensions/UserExtensions.kt @@ -15,7 +15,6 @@ import com.owncloud.android.lib.common.utils.Log_OC private const val TAG = "UserExtensions" -@Suppress("TooGenericExceptionCaught") fun User.toServerCredentials(): ServerCredentials? = try { OwnCloudClientManagerFactory .getDefaultSingleton() diff --git a/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameTextWatcher.kt b/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameTextWatcher.kt index 31096edb0b97..d7487402ae9a 100644 --- a/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameTextWatcher.kt +++ b/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameTextWatcher.kt @@ -17,7 +17,6 @@ import com.nextcloud.utils.fileNameValidator.FileNameValidator.isFileHidden import com.owncloud.android.R import com.owncloud.android.lib.resources.status.OCCapability -@Suppress("LongParameterList") class FileNameTextWatcher( private val previousFileName: String?, private val context: Context, diff --git a/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameValidator.kt b/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameValidator.kt index 36444224c6b2..526deb0ea014 100644 --- a/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameValidator.kt +++ b/app/src/main/java/com/nextcloud/utils/fileNameValidator/FileNameValidator.kt @@ -35,7 +35,7 @@ object FileNameValidator { * @param existingFileNames Set of existing file names to avoid duplicates. * @return An error message if the filename is invalid, null otherwise. */ - @Suppress("ReturnCount", "NestedBlockDepth") + @Suppress("NestedBlockDepth", "CyclomaticComplexMethod") @JvmOverloads fun checkFileName( filename: String, @@ -138,7 +138,6 @@ object FileNameValidator { folderPath.split("[/\\\\]".toRegex()) .none { it.isNotEmpty() && checkFileName(it, capability, context) != null } - @Suppress("ReturnCount") private fun checkInvalidCharacters(name: String, capability: OCCapability, context: Context): String? { capability.forbiddenFilenameCharactersJson?.let { val forbiddenFilenameCharacters = capability.forbiddenFilenameCharacters() diff --git a/app/src/main/java/com/nextcloud/utils/thumbnail/FileThumbnailGenerator.kt b/app/src/main/java/com/nextcloud/utils/thumbnail/FileThumbnailGenerator.kt index dc20143eee29..0ddf315047a4 100644 --- a/app/src/main/java/com/nextcloud/utils/thumbnail/FileThumbnailGenerator.kt +++ b/app/src/main/java/com/nextcloud/utils/thumbnail/FileThumbnailGenerator.kt @@ -173,7 +173,7 @@ class FileThumbnailGenerator @Inject constructor( ) } - @Suppress("TooGenericExceptionCaught", "LongParameterList", "DEPRECATION") + @Suppress("DEPRECATION") private fun startTask( file: OCFile, view: ImageView, diff --git a/app/src/main/java/com/nextcloud/utils/thumbnail/ResizedImageGenerator.kt b/app/src/main/java/com/nextcloud/utils/thumbnail/ResizedImageGenerator.kt index 8e6a8c2bf340..654d30842559 100644 --- a/app/src/main/java/com/nextcloud/utils/thumbnail/ResizedImageGenerator.kt +++ b/app/src/main/java/com/nextcloud/utils/thumbnail/ResizedImageGenerator.kt @@ -104,7 +104,6 @@ object ResizedImageGenerator { downloadPreview(file, client, client.getVideoPreviewEndpoint(file.localId, size)) } - @Suppress("TooGenericExceptionCaught") private fun downloadPreview(file: OCFile, client: OwnCloudClient, uri: String): Bitmap? { Log_OC.d(TAG, "downloading preview: ${file.remotePath}, uri: $uri") diff --git a/app/src/main/java/com/nextcloud/utils/thumbnail/job/MediaThumbnailGenerationJob.kt b/app/src/main/java/com/nextcloud/utils/thumbnail/job/MediaThumbnailGenerationJob.kt index e4b0e841f4c9..541c4de5d5e8 100644 --- a/app/src/main/java/com/nextcloud/utils/thumbnail/job/MediaThumbnailGenerationJob.kt +++ b/app/src/main/java/com/nextcloud/utils/thumbnail/job/MediaThumbnailGenerationJob.kt @@ -48,7 +48,6 @@ class MediaThumbnailGenerationJob( private fun File.cacheKey(): String = hashCode().toString() - @Suppress("TooGenericExceptionCaught") private fun generateThumbnail(file: File, key: String): Bitmap? = try { when { MimeTypeUtil.isImage(file) -> ThumbnailsCacheManager.getBitmapFromDiskCache(key) @@ -70,7 +69,6 @@ class MediaThumbnailGenerationJob( return ThumbnailsCacheManager.addThumbnailToCache(key, bitmap, file.path, px, px) } - @Suppress("TooGenericExceptionCaught") private fun generateVideoThumbnail(file: File, key: String): Bitmap? { if (!file.exists()) { Log_OC.w(TAG, "Cannot extract thumbnail: file does not exist") @@ -101,7 +99,6 @@ class MediaThumbnailGenerationJob( } } - @Suppress("TooGenericExceptionCaught") private fun MediaMetadataRetriever.releaseSafely() { try { release() diff --git a/app/src/main/java/com/nextcloud/utils/thumbnail/job/ResizedImageGenerationJob.kt b/app/src/main/java/com/nextcloud/utils/thumbnail/job/ResizedImageGenerationJob.kt index 1041b38ade6c..a9f9de0323db 100644 --- a/app/src/main/java/com/nextcloud/utils/thumbnail/job/ResizedImageGenerationJob.kt +++ b/app/src/main/java/com/nextcloud/utils/thumbnail/job/ResizedImageGenerationJob.kt @@ -72,7 +72,6 @@ class ResizedImageGenerationJob( return withContext(ioDispatcher) { getOrCreateWithVideoOverlay(file, client) } } - @Suppress("TooGenericExceptionCaught") private fun getOrCreateWithVideoOverlay(file: OCFile, client: OwnCloudClient): Bitmap? = try { val resizedImage = ResizedImageGenerator.getOrCreate(file, client, storageManager) if (resizedImage != null && MimeTypeUtil.isVideo(file)) { diff --git a/app/src/main/java/com/nextcloud/utils/view/FastScrollPopupBackground.kt b/app/src/main/java/com/nextcloud/utils/view/FastScrollPopupBackground.kt index 8d716f6ca779..0e3d57348fa9 100644 --- a/app/src/main/java/com/nextcloud/utils/view/FastScrollPopupBackground.kt +++ b/app/src/main/java/com/nextcloud/utils/view/FastScrollPopupBackground.kt @@ -121,7 +121,6 @@ class FastScrollPopupBackground(context: Context, @ColorInt color: Int) : Drawab } companion object { - @Suppress("LongParameterList") private fun pathArcTo( path: Path, centerX: Float, diff --git a/app/src/main/java/com/owncloud/android/authentication/PassCodeManager.kt b/app/src/main/java/com/owncloud/android/authentication/PassCodeManager.kt index 655691a67d4f..a8dd431d2b4f 100644 --- a/app/src/main/java/com/owncloud/android/authentication/PassCodeManager.kt +++ b/app/src/main/java/com/owncloud/android/authentication/PassCodeManager.kt @@ -24,7 +24,6 @@ import com.owncloud.android.ui.activity.SettingsActivity import com.owncloud.android.utils.DeviceCredentialUtils import kotlin.math.abs -@Suppress("TooManyFunctions") class PassCodeManager(private val preferences: AppPreferences, private val clock: Clock) { companion object { private val exemptOfPasscodeActivities = setOf( diff --git a/app/src/main/java/com/owncloud/android/datamodel/ArbitraryDataProvider.kt b/app/src/main/java/com/owncloud/android/datamodel/ArbitraryDataProvider.kt index c7b40aa78830..f9d570356c73 100644 --- a/app/src/main/java/com/owncloud/android/datamodel/ArbitraryDataProvider.kt +++ b/app/src/main/java/com/owncloud/android/datamodel/ArbitraryDataProvider.kt @@ -9,7 +9,6 @@ package com.owncloud.android.datamodel import com.nextcloud.client.account.User -@Suppress("Detekt.TooManyFunctions") // legacy interface, will get rid of `accountName` methods in the future interface ArbitraryDataProvider { fun deleteKeyForAccount(account: String, key: String) diff --git a/app/src/main/java/com/owncloud/android/datamodel/ContentResolverHelper.kt b/app/src/main/java/com/owncloud/android/datamodel/ContentResolverHelper.kt index 3a8866733c48..397a8be01202 100644 --- a/app/src/main/java/com/owncloud/android/datamodel/ContentResolverHelper.kt +++ b/app/src/main/java/com/owncloud/android/datamodel/ContentResolverHelper.kt @@ -25,7 +25,6 @@ object ContentResolverHelper { */ @JvmStatic @JvmOverloads - @Suppress("LongParameterList") fun queryResolver( contentResolver: ContentResolver, uri: Uri, diff --git a/app/src/main/java/com/owncloud/android/datamodel/OCFileListAdapterDataProviderImpl.kt b/app/src/main/java/com/owncloud/android/datamodel/OCFileListAdapterDataProviderImpl.kt index 8ad715e6eb7b..43a1670912f6 100644 --- a/app/src/main/java/com/owncloud/android/datamodel/OCFileListAdapterDataProviderImpl.kt +++ b/app/src/main/java/com/owncloud/android/datamodel/OCFileListAdapterDataProviderImpl.kt @@ -10,7 +10,6 @@ package com.owncloud.android.datamodel import com.nextcloud.client.database.entity.FileEntity import com.owncloud.android.ui.adapter.filelist.data.OCFileListAdapterDataProvider -@Suppress("ReturnCount") class OCFileListAdapterDataProviderImpl(private val storageManager: FileDataStorageManager) : OCFileListAdapterDataProvider { override fun convertToOCFiles(id: Long): List = diff --git a/app/src/main/java/com/owncloud/android/datamodel/SyncedFolderObserver.kt b/app/src/main/java/com/owncloud/android/datamodel/SyncedFolderObserver.kt index fbb4779fec0f..6888e73b0d41 100644 --- a/app/src/main/java/com/owncloud/android/datamodel/SyncedFolderObserver.kt +++ b/app/src/main/java/com/owncloud/android/datamodel/SyncedFolderObserver.kt @@ -42,7 +42,6 @@ object SyncedFolderObserver { } } - @Suppress("ReturnCount") fun isAutoUploadFolder(file: ServerFileInterface, user: User): Boolean { val accountFolders = syncedFoldersMap[user.accountName] ?: return false val normalizedRemotePath = file.remotePath.trimEnd('/') diff --git a/app/src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.kt b/app/src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.kt index 47e6d8adefbb..f7c00065dca1 100644 --- a/app/src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.kt +++ b/app/src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.kt @@ -46,7 +46,7 @@ import java.util.Calendar import java.util.Locale import java.util.Observable -@Suppress("TooManyFunctions", "TooGenericExceptionCaught", "MagicNumber", "ReturnCount") +@Suppress("MagicNumber") class UploadsStorageManager( private val currentAccountProvider: CurrentAccountProvider, private val contentResolver: ContentResolver diff --git a/app/src/main/java/com/owncloud/android/files/FetchTemplateOperation.kt b/app/src/main/java/com/owncloud/android/files/FetchTemplateOperation.kt index 9fb6a29c9e70..337f5671414c 100644 --- a/app/src/main/java/com/owncloud/android/files/FetchTemplateOperation.kt +++ b/app/src/main/java/com/owncloud/android/files/FetchTemplateOperation.kt @@ -21,7 +21,6 @@ import com.nextcloud.utils.AppConstants.DEFAULT_READ_TIMEOUT_MS class FetchTemplateOperation(private val type: ChooseRichDocumentsTemplateDialogFragment.Type) : RemoteOperation() { - @Suppress("TooGenericExceptionCaught") override fun run(client: OwnCloudClient): RemoteOperationResult { var getMethod: GetMethod? = null diff --git a/app/src/main/java/com/owncloud/android/files/StreamMediaFileOperation.kt b/app/src/main/java/com/owncloud/android/files/StreamMediaFileOperation.kt index 0ebc51c9c4df..3dbf45eec2ab 100644 --- a/app/src/main/java/com/owncloud/android/files/StreamMediaFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/files/StreamMediaFileOperation.kt @@ -16,7 +16,6 @@ import org.apache.commons.httpclient.HttpStatus import org.apache.commons.httpclient.methods.Utf8PostMethod import org.json.JSONObject -@Suppress("TooGenericExceptionCaught") class StreamMediaFileOperation(private val fileID: Long) : RemoteOperation>() { @Deprecated("Deprecated in Java") diff --git a/app/src/main/java/com/owncloud/android/operations/DownloadFileOperation.kt b/app/src/main/java/com/owncloud/android/operations/DownloadFileOperation.kt index 83fa067c5102..fc025259510c 100644 --- a/app/src/main/java/com/owncloud/android/operations/DownloadFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/DownloadFileOperation.kt @@ -38,7 +38,6 @@ import java.util.concurrent.ConcurrentHashMap import java.util.concurrent.atomic.AtomicBoolean import javax.crypto.Cipher -@Suppress("LongParameterList", "ReturnCount") class DownloadFileOperation( val user: User, val file: OCFile, diff --git a/app/src/main/java/com/owncloud/android/operations/FetchRemoteFileOperation.kt b/app/src/main/java/com/owncloud/android/operations/FetchRemoteFileOperation.kt index 9e55d00a6078..3ea023eda05f 100644 --- a/app/src/main/java/com/owncloud/android/operations/FetchRemoteFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/FetchRemoteFileOperation.kt @@ -39,7 +39,6 @@ class FetchRemoteFileOperation( ) : SyncOperation(storageManager) { @Deprecated("Deprecated in Java") - @Suppress("ReturnCount") override fun run(client: OwnCloudClient?): RemoteOperationResult<*>? { val searchRemoteOperation = SearchRemoteOperation( ocFile.localId.toString(), diff --git a/app/src/main/java/com/owncloud/android/operations/FolderRefreshScheduler.kt b/app/src/main/java/com/owncloud/android/operations/FolderRefreshScheduler.kt index c6106a98dbb5..5d3a52027c3c 100644 --- a/app/src/main/java/com/owncloud/android/operations/FolderRefreshScheduler.kt +++ b/app/src/main/java/com/owncloud/android/operations/FolderRefreshScheduler.kt @@ -49,7 +49,6 @@ class FolderRefreshScheduler(private val activity: FileDisplayActivity) { Log_OC.d(TAG, "eTag polling stopped") } - @Suppress("ReturnCount", "TooGenericExceptionCaught") private suspend fun checkAndRefreshIfETagChanged() { if (activity.isFinishing || activity.isSearchOpen()) { Log_OC.w(TAG, "activity is finished or search is opened") diff --git a/app/src/main/java/com/owncloud/android/operations/RemoveFileOperation.kt b/app/src/main/java/com/owncloud/android/operations/RemoveFileOperation.kt index f9426f060825..b28e9c94f120 100644 --- a/app/src/main/java/com/owncloud/android/operations/RemoveFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/RemoveFileOperation.kt @@ -31,7 +31,6 @@ import com.owncloud.android.utils.MimeTypeUtil * @param context Android context. * @param storageManager Storage manager handling local file operations. */ -@Suppress("LongParameterList") class RemoveFileOperation( val file: OCFile, val onlyLocalCopy: Boolean, diff --git a/app/src/main/java/com/owncloud/android/operations/RemoveRemoteEncryptedFileOperation.kt b/app/src/main/java/com/owncloud/android/operations/RemoveRemoteEncryptedFileOperation.kt index c728df20f168..e97363f50850 100644 --- a/app/src/main/java/com/owncloud/android/operations/RemoveRemoteEncryptedFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/RemoveRemoteEncryptedFileOperation.kt @@ -30,7 +30,6 @@ import org.apache.commons.httpclient.NameValuePair import org.apache.jackrabbit.webdav.client.methods.DeleteMethod import com.nextcloud.utils.AppConstants.DEFAULT_CONNECTION_TIMEOUT_MS -@Suppress("LongParameterList") class RemoveRemoteEncryptedFileOperation internal constructor( private val remotePath: String, private val user: User, @@ -41,7 +40,6 @@ class RemoveRemoteEncryptedFileOperation internal constructor( ) : RemoteOperation() { @Deprecated("Deprecated in Java") - @Suppress("TooGenericExceptionCaught") override fun run(client: OwnCloudClient): RemoteOperationResult { var result: RemoteOperationResult var delete: DeleteMethod? = null diff --git a/app/src/main/java/com/owncloud/android/operations/SynchronizeFileOperation.kt b/app/src/main/java/com/owncloud/android/operations/SynchronizeFileOperation.kt index 345c56dd882b..f784b884f010 100644 --- a/app/src/main/java/com/owncloud/android/operations/SynchronizeFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/SynchronizeFileOperation.kt @@ -32,7 +32,6 @@ import com.owncloud.android.ui.events.DialogEventType import com.owncloud.android.utils.FileStorageUtils import org.greenrobot.eventbus.EventBus -@Suppress("LongParameterList") class SynchronizeFileOperation : SyncOperation { var localFile: OCFile? = null diff --git a/app/src/main/java/com/owncloud/android/operations/albums/CopyFileToAlbumOperation.kt b/app/src/main/java/com/owncloud/android/operations/albums/CopyFileToAlbumOperation.kt index b5a8b51f52b0..4ea198259a83 100644 --- a/app/src/main/java/com/owncloud/android/operations/albums/CopyFileToAlbumOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/albums/CopyFileToAlbumOperation.kt @@ -22,7 +22,6 @@ class CopyFileToAlbumOperation(private val srcPath: String, albumPath: String, s private val targetParentPath = albumPath.removeSuffix(OCFile.PATH_SEPARATOR) + OCFile.PATH_SEPARATOR @Deprecated("Deprecated in Java") - @Suppress("ReturnCount") override fun run(client: OwnCloudClient): RemoteOperationResult { if (targetParentPath.startsWith(srcPath)) { return RemoteOperationResult(ResultCode.INVALID_COPY_INTO_DESCENDANT) diff --git a/app/src/main/java/com/owncloud/android/operations/albums/ReadAlbumItemsOperation.kt b/app/src/main/java/com/owncloud/android/operations/albums/ReadAlbumItemsOperation.kt index 71b3d4702760..69b028e2655c 100644 --- a/app/src/main/java/com/owncloud/android/operations/albums/ReadAlbumItemsOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/albums/ReadAlbumItemsOperation.kt @@ -26,7 +26,6 @@ constructor( ) : RemoteOperation>() { @Deprecated("Deprecated in Java") - @Suppress("TooGenericExceptionCaught") override fun run(client: OwnCloudClient): RemoteOperationResult> = try { val result = ReadAlbumItemsRemoteOperation(remotePath, sessionTimeOut).execute(client) diff --git a/app/src/main/java/com/owncloud/android/operations/e2e/E2ECertificateRenewalService.kt b/app/src/main/java/com/owncloud/android/operations/e2e/E2ECertificateRenewalService.kt index ec23d71fec6f..3929a1e54ee4 100644 --- a/app/src/main/java/com/owncloud/android/operations/e2e/E2ECertificateRenewalService.kt +++ b/app/src/main/java/com/owncloud/android/operations/e2e/E2ECertificateRenewalService.kt @@ -75,7 +75,6 @@ class E2ECertificateRenewalService( }.start() } - @Suppress("ReturnCount") private fun renew(context: Context, user: User): E2ECertificateRenewalResult { val keyPair = reconstructKeyPair(user) ?: return E2ECertificateRenewalResult.Failure(R.string.renew_e2e_certificate_private_key_missing) diff --git a/app/src/main/java/com/owncloud/android/operations/factory/UploadFileOperationFactory.kt b/app/src/main/java/com/owncloud/android/operations/factory/UploadFileOperationFactory.kt index dc6403cbab94..537c66bf5257 100644 --- a/app/src/main/java/com/owncloud/android/operations/factory/UploadFileOperationFactory.kt +++ b/app/src/main/java/com/owncloud/android/operations/factory/UploadFileOperationFactory.kt @@ -20,7 +20,6 @@ import com.owncloud.android.lib.common.network.OnDatatransferProgressListener import com.owncloud.android.operations.UploadFileOperation import javax.inject.Inject -@Suppress("LongParameterList") class UploadFileOperationFactory @Inject constructor( private val uploadsStorageManager: UploadsStorageManager, private val connectivityService: ConnectivityService, diff --git a/app/src/main/java/com/owncloud/android/operations/upload/DeleteUploadedFileOperation.kt b/app/src/main/java/com/owncloud/android/operations/upload/DeleteUploadedFileOperation.kt index 1ebc1de8f6ce..b81137979d24 100644 --- a/app/src/main/java/com/owncloud/android/operations/upload/DeleteUploadedFileOperation.kt +++ b/app/src/main/java/com/owncloud/android/operations/upload/DeleteUploadedFileOperation.kt @@ -32,7 +32,7 @@ class DeleteUploadedFileOperation( } private val syncFolderHelper = SyncFolderHelper(context) - @Suppress("NestedBlockDepth", "ReturnCount") + @Suppress("NestedBlockDepth") suspend fun run(): RemoteOperationResult { Log_OC.d(TAG, "Analyzing folder ${syncedFolder.remotePath} from user ${syncedFolder.account}") @@ -92,7 +92,6 @@ class DeleteUploadedFileOperation( return result } - @Suppress("ReturnCount") private suspend fun fileCanBeDeleted(localFile: File, folder: OCFile): Boolean { val remotePath = syncFolderHelper.getAutoUploadRemotePath(syncedFolder, localFile) val ocFile = diff --git a/app/src/main/java/com/owncloud/android/ui/AvatarGroupLayout.kt b/app/src/main/java/com/owncloud/android/ui/AvatarGroupLayout.kt index 891d9502a3b0..41f523208b36 100644 --- a/app/src/main/java/com/owncloud/android/ui/AvatarGroupLayout.kt +++ b/app/src/main/java/com/owncloud/android/ui/AvatarGroupLayout.kt @@ -113,7 +113,6 @@ class AvatarGroupLayout @JvmOverloads constructor( return avatar } - @Suppress("LongParameterList") private fun bindSharee( avatar: ImageView, sharee: ShareeUser, @@ -161,7 +160,6 @@ class AvatarGroupLayout @JvmOverloads constructor( } } - @Suppress("TooGenericExceptionCaught") private fun createFederatedPlaceholder(userId: String, viewThemeUtils: ViewThemeUtils): Drawable = try { TextDrawable.createAvatarByUserId(userId, avatarRadius) } catch (e: Exception) { diff --git a/app/src/main/java/com/owncloud/android/ui/EmptyRecyclerView.kt b/app/src/main/java/com/owncloud/android/ui/EmptyRecyclerView.kt index 3ed4fd9ecbd4..08464ab40ce5 100644 --- a/app/src/main/java/com/owncloud/android/ui/EmptyRecyclerView.kt +++ b/app/src/main/java/com/owncloud/android/ui/EmptyRecyclerView.kt @@ -37,7 +37,6 @@ class EmptyRecyclerView @JvmOverloads constructor(context: Context, attrs: Attri emptyView = view } - @Suppress("ReturnCount") private fun configureEmptyView() { val view = emptyView ?: run { Log_OC.e(TAG, "cannot configure empty view, view is null") diff --git a/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt b/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt index 24703ea4961c..3a7badb3f529 100644 --- a/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt +++ b/app/src/main/java/com/owncloud/android/ui/NextcloudWebViewClient.kt @@ -31,7 +31,6 @@ open class NextcloudWebViewClient(val supportFragmentManager: FragmentManager) : private val tag: String? = NextcloudWebViewClient::class.simpleName - @Suppress("TooGenericExceptionCaught") @SuppressLint("WebViewClientOnReceivedSslError") override fun onReceivedSslError(view: WebView?, handler: SslErrorHandler, error: SslError?) { val cert = error?.let { getX509CertificateFromError(it) } diff --git a/app/src/main/java/com/owncloud/android/ui/activities/StickyHeaderItemDecoration.kt b/app/src/main/java/com/owncloud/android/ui/activities/StickyHeaderItemDecoration.kt index 17616607889d..f035a8cf6f86 100644 --- a/app/src/main/java/com/owncloud/android/ui/activities/StickyHeaderItemDecoration.kt +++ b/app/src/main/java/com/owncloud/android/ui/activities/StickyHeaderItemDecoration.kt @@ -13,7 +13,6 @@ import android.view.ViewGroup import androidx.recyclerview.widget.RecyclerView import androidx.core.graphics.withTranslation -@Suppress("ReturnCount") class StickyHeaderItemDecoration(private val adapter: StickyHeaderAdapter) : RecyclerView.ItemDecoration() { override fun onDrawOver(canvas: Canvas, parent: RecyclerView, state: RecyclerView.State) { diff --git a/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityAndVersionListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityAndVersionListAdapter.kt index e8910ab5da6b..49075a24a716 100644 --- a/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityAndVersionListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityAndVersionListAdapter.kt @@ -24,7 +24,6 @@ import com.owncloud.android.ui.interfaces.VersionListInterface import com.owncloud.android.utils.theme.ViewThemeUtils import java.util.Date -@Suppress("LongParameterList") class ActivityAndVersionListAdapter( context: FragmentActivity, currentAccountProvider: CurrentAccountProvider, diff --git a/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityListAdapter.kt index de8b7a5cbd34..db1238775bb7 100644 --- a/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/activities/adapter/ActivityListAdapter.kt @@ -51,7 +51,7 @@ import kotlin.math.floor import kotlin.math.log import kotlin.math.pow -@Suppress("MagicNumber", "TooManyFunctions", "LongParameterList") +@Suppress("MagicNumber") open class ActivityListAdapter( protected val context: FragmentActivity, private val currentAccountProvider: CurrentAccountProvider, diff --git a/app/src/main/java/com/owncloud/android/ui/activities/data/activities/ActivitiesServiceApiImpl.kt b/app/src/main/java/com/owncloud/android/ui/activities/data/activities/ActivitiesServiceApiImpl.kt index cfec43c3420f..daaa7be9c0e8 100644 --- a/app/src/main/java/com/owncloud/android/ui/activities/data/activities/ActivitiesServiceApiImpl.kt +++ b/app/src/main/java/com/owncloud/android/ui/activities/data/activities/ActivitiesServiceApiImpl.kt @@ -26,7 +26,6 @@ import org.apache.commons.httpclient.HttpStatus /** * Implementation of the Activities Service API that communicates with the NextCloud remote server */ -@Suppress("TooGenericExceptionThrown") class ActivitiesServiceApiImpl(private val accountManager: UserAccountManager) : ActivitiesServiceApi { override fun getAllActivities( diff --git a/app/src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.kt index e8f4349dbcbd..ec1ad6d800a2 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/ConflictsResolveActivity.kt @@ -47,7 +47,6 @@ import kotlinx.coroutines.launch import kotlinx.coroutines.withContext import javax.inject.Inject -@Suppress("TooManyFunctions", "ReturnCount") class ConflictsResolveActivity : FileActivity(), OnConflictDecisionMadeListener { @@ -243,7 +242,6 @@ class ConflictsResolveActivity : } } - @Suppress("ReturnCount") override fun onStart() { super.onStart() @@ -286,7 +284,7 @@ class ConflictsResolveActivity : ).show(ft, "conflictDialog") } - @Suppress("TooGenericExceptionCaught", "DEPRECATION") + @Suppress("DEPRECATION") private fun fetchRemoteFileAndShowDialog() { val remotePath = fileDataStorageManager.retrieveRemotePathConsideringEncryption(newFile) ?: return val operation = ReadFileRemoteOperation(remotePath) diff --git a/app/src/main/java/com/owncloud/android/ui/activity/ExtendedSettingsActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/ExtendedSettingsActivity.kt index 47e60dbea9ee..e4e053cc1735 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/ExtendedSettingsActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/ExtendedSettingsActivity.kt @@ -15,7 +15,6 @@ import com.owncloud.android.ui.model.ExtendedSettingsActivityDialog class ExtendedSettingsActivity : AppCompatActivity() { - @Suppress("ReturnCount") override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) diff --git a/app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt index 0af3787c253b..7c962148087d 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt @@ -192,10 +192,8 @@ import javax.inject.Inject "ComplexCondition", "SpreadOperator", "ForbiddenComment", - "ReturnCount", "LargeClass", - "NestedBlockDepth", - "TooManyFunctions" + "NestedBlockDepth" ) class FileDisplayActivity : FileActivity(), @@ -1051,6 +1049,7 @@ class FileDisplayActivity : /** * Called, when the user selected something for uploading */ + @Suppress("CyclomaticComplexMethod") override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) { if (data != null && ( @@ -1451,6 +1450,7 @@ class FileDisplayActivity : } } + @Suppress("CyclomaticComplexMethod") override fun onResume() { Log_OC.v(TAG, "onResume() start") @@ -1790,6 +1790,7 @@ class FileDisplayActivity : private inner class FileUploadCompletedReceiver : BroadcastReceiver() { private val tag = "UploadFinishReceiver" + @Suppress("CyclomaticComplexMethod") override fun onReceive(context: Context?, intent: Intent) { Log_OC.d(tag, "upload finish received broadcast") @@ -1923,6 +1924,7 @@ class FileDisplayActivity : } } + @Suppress("CyclomaticComplexMethod") private fun updateUIForFileDownload(intent: Intent) { val sameAccount = isSameAccount(intent) val downloadedRemotePath = intent.getStringExtra(FileDownloadEventBroadcaster.EXTRA_REMOTE_PATH) diff --git a/app/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt index a196c3f9c8ee..20e5e4a5ed77 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/FolderPickerActivity.kt @@ -56,7 +56,6 @@ import kotlinx.coroutines.launch import java.io.File import javax.inject.Inject -@Suppress("Detekt.TooManyFunctions") open class FolderPickerActivity : FileActivity(), FileFragment.ContainerActivity, @@ -376,7 +375,6 @@ open class FolderPickerActivity : updateNavigationElementsInActionBar() } - @Suppress("ReturnCount") private fun toggleChooseEnabled() { if (this is FilePickerActivity) { return @@ -549,9 +547,8 @@ open class FolderPickerActivity : * [BroadcastReceiver] to enable syncing feedback in UI */ @Suppress( - "Detekt.ComplexMethod", + "Detekt.CyclomaticComplexMethod", "Detekt.NestedBlockDepth", - "Detekt.TooGenericExceptionCaught", "Detekt.LongMethod" ) // legacy code override fun onReceive(context: Context, intent: Intent) { diff --git a/app/src/main/java/com/owncloud/android/ui/activity/InternalTwoWaySyncActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/InternalTwoWaySyncActivity.kt index 0031211a7027..eb831c871e13 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/InternalTwoWaySyncActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/InternalTwoWaySyncActivity.kt @@ -111,7 +111,6 @@ class InternalTwoWaySyncActivity : } } - @Suppress("TooGenericExceptionCaught") private fun disableTwoWaySyncAndWorkers() { lifecycleScope.launch(Dispatchers.IO) { try { diff --git a/app/src/main/java/com/owncloud/android/ui/activity/ManageAccountsActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/ManageAccountsActivity.kt index 1ab2f2df891c..8e77bdd26a6b 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/ManageAccountsActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/ManageAccountsActivity.kt @@ -132,7 +132,6 @@ class ManageAccountsActivity : recyclerView?.setLayoutManager(LinearLayoutManager(this)) } - @Suppress("ReturnCount") @Deprecated("Use ActivityResultLauncher") override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) { super.onActivityResult(requestCode, resultCode, data) @@ -248,7 +247,6 @@ class ManageAccountsActivity : startActivity(intent) } - @Suppress("TooGenericExceptionCaught") @SuppressLint("NotifyDataSetChanged") override fun startAccountCreation() { stopMediaPlayerAndHidePip() diff --git a/app/src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.kt index 2c75fcdc29d1..c2c1f7951286 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.kt @@ -150,7 +150,6 @@ class ManageSpaceActivity : return clearResult } - @Suppress("ReturnCount") private fun deleteDir(dir: File?): Boolean { if (dir != null && dir.isDirectory) { dir.list()?.forEach { child -> diff --git a/app/src/main/java/com/owncloud/android/ui/activity/PassCodeActivity.kt b/app/src/main/java/com/owncloud/android/ui/activity/PassCodeActivity.kt index 63a7c1254b1a..8f18d5af87a6 100644 --- a/app/src/main/java/com/owncloud/android/ui/activity/PassCodeActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/activity/PassCodeActivity.kt @@ -39,7 +39,7 @@ import javax.inject.Inject import androidx.activity.OnBackPressedCallback import com.nextcloud.utils.AppConstants.ONE_SECOND -@Suppress("TooManyFunctions", "MagicNumber") +@Suppress("MagicNumber") class PassCodeActivity : AppCompatActivity(), Injectable { diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/DiskLruImageCache.kt b/app/src/main/java/com/owncloud/android/ui/adapter/DiskLruImageCache.kt index 04e7c34026bd..ba75cad59ff4 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/DiskLruImageCache.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/DiskLruImageCache.kt @@ -44,7 +44,6 @@ constructor( } } - @Suppress("TooGenericExceptionCaught") fun getScaledBitmap(key: String, width: Int, height: Int): Bitmap? = try { decodeScaled(key.toValidKey(), width, height) } catch (e: Exception) { diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/GalleryAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/GalleryAdapter.kt index e03e571d9ac5..3b3406503203 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/GalleryAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/GalleryAdapter.kt @@ -44,7 +44,6 @@ import com.owncloud.android.utils.FileSortOrder import com.owncloud.android.utils.theme.ViewThemeUtils import me.zhanghai.android.fastscroll.PopupTextProvider -@Suppress("LongParameterList", "TooManyFunctions") class GalleryAdapter( val context: Context, user: User, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt b/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt index dd6a506c1036..83c8ef144f36 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/LinkShareViewHolder.kt @@ -57,7 +57,6 @@ internal class LinkShareViewHolder(itemView: View) : RecyclerView.ViewHolder(ite configureCopyLink(binding, context, listener, publicShare) } - @Suppress("ReturnCount") private fun setName( binding: FileDetailsShareLinkShareItemBinding?, context: Context?, @@ -98,7 +97,6 @@ internal class LinkShareViewHolder(itemView: View) : RecyclerView.ViewHolder(ite } } - @Suppress("ReturnCount") private fun setSubline(binding: FileDetailsShareLinkShareItemBinding?, context: Context?, publicShare: OCShare) { if (binding == null || context == null) { return diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/NotificationListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/NotificationListAdapter.kt index 1876f592693c..d496ff032d01 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/NotificationListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/NotificationListAdapter.kt @@ -43,7 +43,6 @@ import com.owncloud.android.ui.fragment.notifications.NotificationsAdapterItemCl import com.owncloud.android.ui.fragment.notifications.NotificationsFragment import com.owncloud.android.utils.theme.ViewThemeUtils -@Suppress("TooManyFunctions") class NotificationListAdapter( private val fragment: NotificationsFragment, private val viewThemeUtils: ViewThemeUtils, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/ReceiveExternalFilesAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/ReceiveExternalFilesAdapter.kt index bfce159b883f..a469c28e3eff 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/ReceiveExternalFilesAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/ReceiveExternalFilesAdapter.kt @@ -29,7 +29,6 @@ import com.owncloud.android.datamodel.ThumbnailsCacheManager.ThumbnailGeneration import com.owncloud.android.utils.MimeTypeUtil import com.owncloud.android.utils.theme.ViewThemeUtils -@Suppress("LongParameterList") class ReceiveExternalFilesAdapter( private val files: List, private val context: Context, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/ShareeListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/ShareeListAdapter.kt index d96d7430b7f9..174b135dd841 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/ShareeListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/ShareeListAdapter.kt @@ -37,7 +37,6 @@ import kotlin.math.min /** * Adapter to show a user/group/email/remote in Sharing list in file details view. */ -@Suppress("LongParameterList") class ShareeListAdapter( private val fileActivity: FileActivity, @JvmField var shares: ArrayList, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.kt index 63e953b3425d..921492245537 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/SyncedFolderAdapter.kt @@ -51,7 +51,6 @@ import java.util.concurrent.TimeUnit /** * Adapter to display all auto-synced folders and/or instant upload media folders. */ -@Suppress("LongParameterList", "TooManyFunctions") class SyncedFolderAdapter( private val lifecycleScope: LifecycleCoroutineScope, private val context: Context, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchCurrentDirItemViewHolder.kt b/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchCurrentDirItemViewHolder.kt index 94c7f1dbf08c..a72b84ea8b3d 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchCurrentDirItemViewHolder.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchCurrentDirItemViewHolder.kt @@ -19,7 +19,6 @@ import com.owncloud.android.datamodel.OCFile import com.owncloud.android.ui.interfaces.UnifiedSearchCurrentDirItemAction import com.owncloud.android.utils.FileStorageUtils -@Suppress("LongParameterList") class UnifiedSearchCurrentDirItemViewHolder( val binding: UnifiedSearchCurrentDirectoryItemBinding, val context: Context, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchItemViewHolder.kt b/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchItemViewHolder.kt index a33cf6c1637b..02f7ec81c3cb 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchItemViewHolder.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchItemViewHolder.kt @@ -37,7 +37,6 @@ import com.owncloud.android.ui.unifiedsearch.UnifiedSearchEntry import com.owncloud.android.utils.MimeTypeUtil import com.owncloud.android.utils.theme.ViewThemeUtils -@Suppress("LongParameterList") class UnifiedSearchItemViewHolder( private val supportsOpeningCalendarContactsLocally: Boolean, val binding: UnifiedSearchItemBinding, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapter.kt index 072c3ff7ac67..290f92dbf99e 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/UnifiedSearchListAdapter.kt @@ -38,7 +38,7 @@ import com.owncloud.android.utils.theme.ViewThemeUtils /** * This Adapter populates a SectionedRecyclerView with search results by unified search */ -@Suppress("LongParameterList", "LongMethod") +@Suppress("LongMethod") class UnifiedSearchListAdapter( private val supportsOpeningCalendarContactsLocally: Boolean, private val storageManager: FileDataStorageManager, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumsAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumsAdapter.kt index 6298655a2910..4eba80fadf01 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumsAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/albums/AlbumsAdapter.kt @@ -24,7 +24,6 @@ import com.owncloud.android.datamodel.FileDataStorageManager import com.owncloud.android.datamodel.OCFile import com.owncloud.android.lib.resources.albums.PhotoAlbumEntry -@Suppress("LongParameterList") class AlbumsAdapter( private val context: Context, private val storageManager: FileDataStorageManager?, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/CommonOCFileListAdapterInterface.kt b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/CommonOCFileListAdapterInterface.kt index a8d3152c1984..8e04cb8054fa 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/CommonOCFileListAdapterInterface.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/CommonOCFileListAdapterInterface.kt @@ -12,7 +12,6 @@ import com.owncloud.android.datamodel.FileDataStorageManager import com.owncloud.android.datamodel.OCFile import com.owncloud.android.utils.FileSortOrder -@Suppress("TooManyFunctions") interface CommonOCFileListAdapterInterface { fun isMultiSelect(): Boolean fun cancelAllPendingTasks() diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/OCFileListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/OCFileListAdapter.kt index 2937739aa7af..4a1db86037aa 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/OCFileListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/OCFileListAdapter.kt @@ -83,7 +83,6 @@ import java.util.Date import java.util.Locale import java.util.UUID -@Suppress("LongParameterList", "TooManyFunctions") class OCFileListAdapter( private val activity: Activity, private var user: User, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelper.kt b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelper.kt index 5a3d335bbe01..4057c8847844 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelper.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelper.kt @@ -26,7 +26,6 @@ class OCFileListAdapterHelper { private val scope = CoroutineScope(Dispatchers.IO + SupervisorJob()) private var job: Job? = null - @Suppress("LongParameterList") fun prepareFileList( directory: OCFile, dataProvider: OCFileListAdapterDataProvider, @@ -54,6 +53,7 @@ class OCFileListAdapterHelper { } } + @Suppress("CyclomaticComplexMethod") suspend fun prepareFileList( directory: OCFile, dataProvider: OCFileListAdapterDataProvider, @@ -184,7 +184,6 @@ class OCFileListAdapterHelper { fun indexOfSameRemoteFile(files: List, target: OCFile): Int = files.indexOfFirst { isSameRemoteFile(it, target) } - @Suppress("ReturnCount") fun isSameRemoteFile(file: OCFile, target: OCFile): Boolean { if (file.fileId == target.fileId) { return true diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/header/OCFileListHeaderBinder.kt b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/header/OCFileListHeaderBinder.kt index ae760ab829f0..51d0e1174b3c 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/header/OCFileListHeaderBinder.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/header/OCFileListHeaderBinder.kt @@ -23,7 +23,6 @@ import com.owncloud.android.ui.interfaces.OCFileListFragmentInterface import com.owncloud.android.ui.preview.text.PreviewTextFragment import com.owncloud.android.utils.theme.ViewThemeUtils -@Suppress("LongParameterList") internal class OCFileListHeaderBinder( private val activity: Activity, private val viewThemeUtils: ViewThemeUtils, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/item/OCFileListDelegate.kt b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/item/OCFileListDelegate.kt index a655fb7197a7..5d603aba1461 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/filelist/item/OCFileListDelegate.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/filelist/item/OCFileListDelegate.kt @@ -56,7 +56,6 @@ import kotlinx.coroutines.cancelChildren import kotlinx.coroutines.job import kotlinx.coroutines.launch -@Suppress("LongParameterList", "TooManyFunctions") class OCFileListDelegate( private val fileUploadHelper: FileUploadHelper, private val context: Context, @@ -204,7 +203,7 @@ class OCFileListDelegate( } } - @Suppress("MagicNumber") + @Suppress("MagicNumber", "CyclomaticComplexMethod") fun bindViewHolder( viewHolder: ListViewHolder, file: OCFile, @@ -416,7 +415,6 @@ class OCFileListDelegate( } } - @Suppress("ReturnCount") private fun getShareIconIdAndContentDescriptionId(holder: ListViewHolder, file: OCFile): Pair? { if (!MDMConfig.sharingSupport(context)) { return null @@ -441,7 +439,6 @@ class OCFileListDelegate( showShareAvatar = bool } - @Suppress("TooGenericExceptionCaught") fun cleanup() { ioScope.coroutineContext.cancelChildren() diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListAdapter.kt index 8c011ab53f38..36ff68bdf5a9 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListAdapter.kt @@ -35,7 +35,6 @@ import kotlinx.coroutines.withContext import java.io.File import java.util.Locale -@Suppress("LongParameterList", "TooManyFunctions") class LocalFileListAdapter( localFolderPickerMode: Boolean, private val fragmentInterface: LocalFileListFragmentInterface, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListItemBinder.kt b/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListItemBinder.kt index aa33ac91b8aa..170bc64e059e 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListItemBinder.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/localFileList/LocalFileListItemBinder.kt @@ -17,7 +17,6 @@ import com.owncloud.android.ui.interfaces.LocalFileListFragmentInterface import com.owncloud.android.utils.theme.ViewThemeUtils import java.io.File -@Suppress("LongParameterList") internal class LocalFileListItemBinder( private val activity: Activity, private val viewThemeUtils: ViewThemeUtils, diff --git a/app/src/main/java/com/owncloud/android/ui/adapter/uploadList/UploadListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/adapter/uploadList/UploadListAdapter.kt index 71ea3dfa7906..6729649ebc70 100644 --- a/app/src/main/java/com/owncloud/android/ui/adapter/uploadList/UploadListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/adapter/uploadList/UploadListAdapter.kt @@ -58,12 +58,9 @@ import java.util.function.Consumer @Suppress( "LongMethod", - "TooManyFunctions", "LargeClass", - "LongParameterList", "NestedBlockDepth", - "MaxLineLength", - "ReturnCount" + "MaxLineLength" ) class UploadListAdapter( private val activity: DrawerActivity, diff --git a/app/src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.kt b/app/src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.kt index 03db1eb5a3fe..1c9f58c5939a 100644 --- a/app/src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.kt +++ b/app/src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.kt @@ -27,7 +27,6 @@ import java.io.FileNotFoundException import java.io.FileOutputStream import java.lang.ref.WeakReference -@Suppress("TooGenericExceptionCaught") class CopyAndUploadContentUrisTask( listener: OnCopyTmpFilesTaskListener?, context: Context, diff --git a/app/src/main/java/com/owncloud/android/ui/asynctasks/FetchRemoteFileTask.kt b/app/src/main/java/com/owncloud/android/ui/asynctasks/FetchRemoteFileTask.kt index 3f0d33b6bd4e..da102aee42f8 100644 --- a/app/src/main/java/com/owncloud/android/ui/asynctasks/FetchRemoteFileTask.kt +++ b/app/src/main/java/com/owncloud/android/ui/asynctasks/FetchRemoteFileTask.kt @@ -25,7 +25,7 @@ import kotlinx.coroutines.launch import kotlinx.coroutines.withContext import java.lang.ref.WeakReference -@Suppress("DEPRECATION", "TooGenericExceptionCaught", "TooGenericExceptionThrown", "LongParameterList") +@Suppress("DEPRECATION") class FetchRemoteFileTask( private val user: User, private val fileId: String, diff --git a/app/src/main/java/com/owncloud/android/ui/asynctasks/NotificationExecuteActionTask.kt b/app/src/main/java/com/owncloud/android/ui/asynctasks/NotificationExecuteActionTask.kt index b8c3e9f3bc1f..8fdc2a4a55f3 100644 --- a/app/src/main/java/com/owncloud/android/ui/asynctasks/NotificationExecuteActionTask.kt +++ b/app/src/main/java/com/owncloud/android/ui/asynctasks/NotificationExecuteActionTask.kt @@ -28,7 +28,6 @@ import okhttp3.RequestBody import org.apache.commons.httpclient.HttpStatus import java.io.IOException -@Suppress("ReturnCount") class NotificationExecuteActionTask( private val client: NextcloudClient, private val holder: NotificationListAdapter.NotificationViewHolder, diff --git a/app/src/main/java/com/owncloud/android/ui/asynctasks/RetrieveHoverCardAsyncTask.kt b/app/src/main/java/com/owncloud/android/ui/asynctasks/RetrieveHoverCardAsyncTask.kt index dd96f20a3ce9..d8af91629d26 100644 --- a/app/src/main/java/com/owncloud/android/ui/asynctasks/RetrieveHoverCardAsyncTask.kt +++ b/app/src/main/java/com/owncloud/android/ui/asynctasks/RetrieveHoverCardAsyncTask.kt @@ -21,7 +21,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("LongParameterList") class RetrieveHoverCardAsyncTask( private val user: User, private val userId: String, @@ -34,7 +33,6 @@ class RetrieveHoverCardAsyncTask( private const val TAG = "RetrieveHoverCardAsyncTask" } - @Suppress("TooGenericExceptionCaught") fun execute() { activity.lifecycleScope.launch { val result = withContext(Dispatchers.IO) { diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.kt b/app/src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.kt index d68ee558cd38..51d8428cbfd0 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.kt @@ -54,7 +54,6 @@ import kotlinx.coroutines.launch import kotlinx.coroutines.withContext import javax.inject.Inject -@Suppress("TooManyFunctions") class ChooseRichDocumentsTemplateDialogFragment : DialogFragment(), View.OnClickListener, diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.kt b/app/src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.kt index 0feae1dc60e5..fd16cf54d323 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.kt @@ -179,7 +179,6 @@ class ChooseTemplateDialogFragment : return builder.create() } - @Suppress("TooGenericExceptionCaught") private fun fetchTemplate() { try { val user = currentAccount.user diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/ConfirmationDialogFragment.kt b/app/src/main/java/com/owncloud/android/ui/dialog/ConfirmationDialogFragment.kt index f823cdc23830..dc13aec23772 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/ConfirmationDialogFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/ConfirmationDialogFragment.kt @@ -131,7 +131,6 @@ open class ConfirmationDialogFragment : * @param negativeButtonTextId Resource id for the text of the negative button. -1 for no negative button. * @return Dialog ready to show. */ - @Suppress("LongParameterList") @JvmStatic @JvmOverloads fun newInstance( diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/SendShareDialog.kt b/app/src/main/java/com/owncloud/android/ui/dialog/SendShareDialog.kt index 1ea754c42ae1..f0e7cb45db41 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/SendShareDialog.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/SendShareDialog.kt @@ -216,7 +216,6 @@ class SendShareDialog : this.fileOperationsHelper = fileOperationsHelper } - @Suppress("ReturnCount") override fun onSendButtonClick(sendButtonData: SendButtonData) { val packageName = sendButtonData.packageName val activityName = sendButtonData.activityName diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/CertificateValidator.kt b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/CertificateValidator.kt index 60acc2cd10ef..5c76f170610d 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/CertificateValidator.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/CertificateValidator.kt @@ -27,7 +27,6 @@ class CertificateValidator @Inject constructor() { * @param serverPublicKeyString Public key with header * @param certificate Certificate in PEM format */ - @Suppress("TooGenericExceptionCaught") fun validate(serverPublicKeyString: String, certificate: String): Boolean { val contentOfServerKey = CryptoStringUtils.rawPublicKey(serverPublicKeyString) diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt index 1d6598463d10..f968332a8607 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/EncryptionKeyGenerator.kt @@ -49,7 +49,6 @@ class EncryptionKeyGenerator(val context: Context, val user: User) { .generateKeyPair() } - @Suppress("TooGenericExceptionCaught", "TooGenericExceptionThrown", "ReturnCount") suspend fun generatePrivateKey(keyWords: ArrayList): PrivateKeyResult = withContext(Dispatchers.IO) { val arbitraryDataProvider = ArbitraryDataProviderImpl(context) @@ -120,7 +119,6 @@ class EncryptionKeyGenerator(val context: Context, val user: User) { return@withContext PrivateKeyResult.Failed } - @Suppress("LongParameterList") fun uploadEncryptedFolderMetadata( folder: OCFile, client: OwnCloudClient, diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt index 452e9899d581..4f155be48b16 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt @@ -141,7 +141,7 @@ class SetupEncryptionDialogFragment : } } - @Suppress("TooGenericExceptionCaught", "TooGenericExceptionThrown", "ReturnCount", "LongMethod") + @Suppress("LongMethod") private fun decryptPrivateKey(dialog: DialogInterface) { Log_OC.d(TAG, "Decrypt private key") binding.encryptionStatus.setText(R.string.end_to_end_encryption_decrypting) @@ -353,7 +353,6 @@ class SetupEncryptionDialogFragment : } } - @Suppress("ReturnCount") private suspend fun generateNewKeys() { binding.encryptionStatus.setText(R.string.end_to_end_encryption_generating_keys) val context = context ?: return diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.kt index c9734a3e1a6a..5132ef93c67c 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.kt @@ -79,7 +79,7 @@ import kotlin.math.max import kotlin.math.min import kotlin.math.roundToInt -@Suppress("MagicNumber", "TooManyFunctions") +@Suppress("MagicNumber") open class ExtendedListFragment : Fragment(), AdapterView.OnItemClickListener, @@ -234,7 +234,6 @@ open class ExtendedListFragment : return false } - @Suppress("ReturnCount") override fun onQueryTextSubmit(query: String): Boolean { val adapter = recyclerView?.adapter if (adapter is OCFileListAdapter) { @@ -615,7 +614,7 @@ open class ExtendedListFragment : } } - @Suppress("LongMethod") + @Suppress("LongMethod", "CyclomaticComplexMethod") fun setEmptyListMessage(state: Parcelable?) { when (state) { SearchType.NO_SEARCH -> { diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.kt index 1ff1e5ff0b7a..249094dfda7a 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.kt @@ -63,7 +63,6 @@ import org.apache.commons.httpclient.HttpStatus import org.greenrobot.eventbus.EventBus import javax.inject.Inject -@Suppress("TooManyFunctions", "ReturnCount") class FileDetailActivitiesFragment : Fragment(), ActivityListInterface, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.kt index a8ef82de4e1d..7ed558385c64 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.kt @@ -85,7 +85,6 @@ import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.ThreadMode import javax.inject.Inject -@Suppress("TooManyFunctions") class FileDetailFragment : FileFragment(), View.OnClickListener, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.kt index 465948398000..bf3349db4467 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailSharingFragment.kt @@ -81,7 +81,7 @@ import kotlinx.coroutines.launch import kotlinx.coroutines.withContext import javax.inject.Inject -@Suppress("TooManyFunctions", "LargeClass", "TooGenericExceptionCaught", "ReturnCount") +@Suppress("LargeClass") class FileDetailSharingFragment : Fragment(), ShareeListAdapterListener, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt index 0a57cbd62a4e..649519a250ce 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailsSharingProcessFragment.kt @@ -55,7 +55,7 @@ import javax.inject.Inject * configuration at one time. * 2. This will handle both Advanced Permissions and Send New Email functionality for existing shares to modify them. */ -@Suppress("TooManyFunctions", "LargeClass") +@Suppress("LargeClass") class FileDetailsSharingProcessFragment : Fragment(), Injectable, @@ -753,7 +753,6 @@ class FileDetailsSharingProcessFragment : /** * method to validate the step 1 screen information */ - @Suppress("ReturnCount") private fun validateShareProcessFirst() { if (permission == OCShare.NO_PERMISSION) { SnackbarUtil.show(this, R.string.no_share_permission_selected) @@ -795,7 +794,6 @@ class FileDetailsSharingProcessFragment : } } - @Suppress("ReturnCount") private fun createShareOrUpdateNoteShare() { if (!isAnySharePermissionChecked()) { SnackbarUtil.show(this, R.string.share_option_required) diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FolderEncryption.kt b/app/src/main/java/com/owncloud/android/ui/fragment/FolderEncryption.kt index 232c1452f2aa..30fc3d797da0 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/FolderEncryption.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/FolderEncryption.kt @@ -22,7 +22,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.withContext import org.apache.commons.httpclient.HttpStatus -@Suppress("TooGenericExceptionCaught") class FolderEncryption(private val fragment: OCFileListFragment) { companion object { @@ -81,7 +80,6 @@ class FolderEncryption(private val fragment: OCFileListFragment) { } } - @Suppress("LongParameterList") suspend fun onToggleSuccess( remoteId: String, shouldBeEncrypted: Boolean, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt index b7f9be66a458..9ac86cb6555a 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt @@ -64,7 +64,7 @@ import kotlinx.coroutines.launch import kotlinx.coroutines.withContext import com.nextcloud.utils.AppConstants.MILLIS_PER_SECOND -@Suppress("ForbiddenComment", "ReturnCount", "MagicNumber", "MaxLineLength", "TooManyFunctions") +@Suppress("ForbiddenComment", "MagicNumber", "MaxLineLength") class GalleryFragment : OCFileListFragment(), GalleryFragmentBottomSheetActions { diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt b/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt index 9466a9fd71a2..22d4f255a9fb 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.kt @@ -50,7 +50,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("LongParameterList") class OCFileListBottomSheetDialog( private val fileActivity: FileActivity, private val actions: OCFileListBottomSheetActions, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt b/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt index 3696d9246dc5..0d98f5c01705 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/OCFileListSearchTask.kt @@ -43,7 +43,6 @@ import kotlinx.coroutines.withContext import kotlinx.coroutines.withTimeoutOrNull import java.lang.ref.WeakReference -@Suppress("LongParameterList", "ReturnCount", "TooGenericExceptionCaught") @SuppressLint("NotifyDataSetChanged") class OCFileListSearchTask( fragment: OCFileListFragment, @@ -61,7 +60,7 @@ class OCFileListSearchTask( private val fragmentReference: WeakReference = WeakReference(fragment) private var job: Job? = null - @Suppress("TooGenericExceptionCaught", "DEPRECATION", "ReturnCount") + @Suppress("DEPRECATION") fun execute() { Log_OC.d(TAG, "search task running, query: ${event.searchType}") val fragment = fragmentReference.get() ?: return @@ -195,7 +194,7 @@ class OCFileListSearchTask( return sortOrder.sortCloudFiles(list.toMutableList(), foldersBeforeFiles, favoritesFirst) } - @Suppress("DEPRECATION") + @Suppress("DEPRECATION", "CyclomaticComplexMethod") private suspend fun parseAndSaveVirtuals(data: List, fragment: OCFileListFragment): List = withContext(Dispatchers.IO) { val activity = fragment.activity ?: return@withContext emptyList() diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/SharedListFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/SharedListFragment.kt index d7659229dc8c..1c0f8c5063ce 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/SharedListFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/SharedListFragment.kt @@ -35,7 +35,6 @@ import javax.inject.Inject /** * A Fragment that lists folders shared by the user */ -@Suppress("TooManyFunctions") class SharedListFragment : OCFileListFragment(), Injectable { diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/UnifiedSearchFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/UnifiedSearchFragment.kt index d0ce0a55068d..e7f6eb021cb1 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/UnifiedSearchFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/UnifiedSearchFragment.kt @@ -76,7 +76,6 @@ import kotlin.time.Duration.Companion.milliseconds * Starts query to all capable unified search providers and displays them Opens result in our app, redirect to other * apps, if installed, or opens browser */ -@Suppress("TooManyFunctions") class UnifiedSearchFragment : Fragment(), Injectable, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumItemsFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumItemsFragment.kt index c9d254dec126..1e8a7cfbebe0 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumItemsFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/albums/AlbumItemsFragment.kt @@ -107,7 +107,6 @@ import java.util.Optional import javax.inject.Inject import kotlin.time.Duration.Companion.milliseconds -@Suppress("TooManyFunctions") class AlbumItemsFragment : Fragment(), OCFileListFragmentInterface, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/AutoUploadFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/AutoUploadFragment.kt index 495109a6a8f0..a83065469604 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/AutoUploadFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/AutoUploadFragment.kt @@ -53,7 +53,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("TooManyFunctions") class AutoUploadFragment : Fragment(), OnSyncedFolderPreferenceListener { diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/data/AutoUploadDisplayItemFactory.kt b/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/data/AutoUploadDisplayItemFactory.kt index 647a15dcdbfa..26efc5256347 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/data/AutoUploadDisplayItemFactory.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/data/AutoUploadDisplayItemFactory.kt @@ -128,7 +128,6 @@ class AutoUploadDisplayItemFactory( } } - @Suppress("LongParameterList") private fun createFromAutoUploadFolder( syncedFolder: SyncedFolder, filePaths: List?, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/handler/AutoUploadClickHandler.kt b/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/handler/AutoUploadClickHandler.kt index c29776feb642..d6f32116f547 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/handler/AutoUploadClickHandler.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/autoUpload/handler/AutoUploadClickHandler.kt @@ -28,7 +28,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("LongParameterList", "TooManyFunctions") class AutoUploadClickHandler( private val fragment: Fragment, private val itemFactory: AutoUploadDisplayItemFactory, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupFragment.kt index ad6cb3ce09de..442e2b0c3e1f 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupFragment.kt @@ -57,7 +57,6 @@ import java.util.Calendar import java.util.GregorianCalendar import javax.inject.Inject -@Suppress("TooManyFunctions") class BackupFragment : FileFragment(), OnDateSetListener, @@ -336,7 +335,6 @@ class BackupFragment : } } - @Suppress("TooGenericExceptionCaught") private suspend fun fetchBackupFiles(folder: OCFile, storageManager: FileDataStorageManager): List = withContext(Dispatchers.IO) { try { @@ -409,7 +407,7 @@ class BackupFragment : } } - @Suppress("ComplexMethod", "MagicNumber", "ReturnCount") + @Suppress("CyclomaticComplexMethod", "MagicNumber") override fun onDateSet(view: DatePicker, year: Int, month: Int, dayOfMonth: Int) { val contactsPreferenceActivity = activity as? ContactsPreferenceActivity ?: run { activity?.let { SnackbarUtil.show(it, R.string.error_choosing_date) } diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListAdapter.kt b/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListAdapter.kt index 431c6fd83abc..706584b88747 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/contactsbackup/BackupListAdapter.kt @@ -43,7 +43,6 @@ import ezvcard.VCard import ezvcard.property.Photo import thirdparties.sufficientlysecure.AndroidCalendar -@Suppress("LongParameterList", "TooManyFunctions") class BackupListAdapter( val accountManager: UserAccountManager, val clientFactory: ClientFactory, @@ -325,7 +324,7 @@ class BackupListAdapter( backupListFragment.showRestoreButton(hasSelection && hasAvailableCalendar) } - @Suppress("NestedBlockDepth", "TooGenericExceptionCaught") + @Suppress("NestedBlockDepth") private fun getAccountsForImport(): List { val accounts = mutableListOf(ContactsAccount(context.getString(R.string.backup_list_adapter_local_contacts), null, null)) diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/filesRepository/RemoteFilesRepository.kt b/app/src/main/java/com/owncloud/android/ui/fragment/filesRepository/RemoteFilesRepository.kt index 02416dd39e70..76f9535134fb 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/filesRepository/RemoteFilesRepository.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/filesRepository/RemoteFilesRepository.kt @@ -21,7 +21,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("TooGenericExceptionCaught") class RemoteFilesRepository(private val clientRepository: ClientRepository, lifecycleOwner: LifecycleOwner) : FilesRepository { private val tag = "FilesRepository" diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/helper/ParentFolderFinder.kt b/app/src/main/java/com/owncloud/android/ui/fragment/helper/ParentFolderFinder.kt index 30bd4c4c49e3..8c0dcfa37e4f 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/helper/ParentFolderFinder.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/helper/ParentFolderFinder.kt @@ -11,7 +11,6 @@ import com.owncloud.android.datamodel.FileDataStorageManager import com.owncloud.android.datamodel.OCFile import com.owncloud.android.lib.common.utils.Log_OC -@Suppress("ReturnCount") class ParentFolderFinder { companion object { private const val TAG = "ParentFolderFinder" diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/notifications/NotificationsFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/notifications/NotificationsFragment.kt index 6fe2fad73f51..a2cf15ac35e3 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/notifications/NotificationsFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/notifications/NotificationsFragment.kt @@ -58,7 +58,6 @@ import kotlinx.coroutines.withContext import java.util.Optional import javax.inject.Inject -@Suppress("TooManyFunctions", "ReturnCount") class NotificationsFragment : Fragment(), NotificationsContract.View, diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/uploadList/UploadListFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/uploadList/UploadListFragment.kt index e64e27eaaff0..fc8d1ebf4827 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/uploadList/UploadListFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/uploadList/UploadListFragment.kt @@ -52,7 +52,6 @@ import com.owncloud.android.utils.theme.ViewThemeUtils import javax.inject.Inject import com.nextcloud.utils.AppConstants.ONE_SECOND -@Suppress("TooManyFunctions") class UploadListFragment : Fragment(), UploadListItemOnClick { diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/util/SharePermissionManager.kt b/app/src/main/java/com/owncloud/android/ui/fragment/util/SharePermissionManager.kt index 313cbd073d45..9b157f461aa6 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/util/SharePermissionManager.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/util/SharePermissionManager.kt @@ -39,7 +39,6 @@ object SharePermissionManager { fun hasPermission(permission: Int, permissionFlag: Int): Boolean = permission != OCShare.NO_PERMISSION && (permission and permissionFlag) == permissionFlag - @Suppress("ReturnCount") private fun isPermissionValid(permission: Int): Boolean { // Must have at least READ or CREATE permission. if (!hasPermission(permission, OCShare.READ_PERMISSION_FLAG) && @@ -83,7 +82,6 @@ object SharePermissionManager { ) } - @Suppress("ReturnCount") fun isFileRequest(share: OCShare?): Boolean { if (share == null) { return false @@ -126,7 +124,6 @@ object SharePermissionManager { QuickPermissionType.NONE } - @Suppress("ReturnCount") fun isCustomPermission(share: OCShare?): Boolean { if (share == null) { return false diff --git a/app/src/main/java/com/owncloud/android/ui/helpers/UriUploader.kt b/app/src/main/java/com/owncloud/android/ui/helpers/UriUploader.kt index d6b5b63015ed..a93be862a821 100644 --- a/app/src/main/java/com/owncloud/android/ui/helpers/UriUploader.kt +++ b/app/src/main/java/com/owncloud/android/ui/helpers/UriUploader.kt @@ -38,11 +38,7 @@ import com.owncloud.android.utils.UriUtils.getDisplayNameForUri * persistence permission is not granted. Due to this, contents of the file are temporary copied by the OC app, and then * passed [FileUploadHelper]. */ -@Suppress( - "Detekt.LongParameterList", - "Detekt.SpreadOperator", - "Detekt.TooGenericExceptionCaught" -) +@Suppress("Detekt.SpreadOperator") class UriUploader @JvmOverloads constructor( private val activity: FileActivity, private val urisToUpload: List, diff --git a/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaActivity.kt b/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaActivity.kt index 1e9d406d084e..c695da8a0bef 100644 --- a/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaActivity.kt +++ b/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaActivity.kt @@ -77,7 +77,6 @@ import kotlin.math.min /** * Holds a swiping gallery where image and video files contained in a Nextcloud directory are shown. */ -@Suppress("TooManyFunctions") class PreviewMediaActivity : FileActivity(), FileFragment.ContainerActivity, diff --git a/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaFragment.kt b/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaFragment.kt index 7acbfab9cedf..a5ada2b3d032 100644 --- a/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaFragment.kt @@ -99,7 +99,6 @@ import kotlin.math.min * * DO NOT CALL IT: an [OCFile] and [User] must be provided for a successful construction */ -@Suppress("TooManyFunctions") class PreviewMediaFragment : FileFragment(), Injectable { @@ -185,7 +184,6 @@ class PreviewMediaFragment : * {@inheritDoc} */ @Deprecated("Deprecated in Java") - @Suppress("ReturnCount") override fun onActivityCreated(savedInstanceState: Bundle?) { super.onActivityCreated(savedInstanceState) if (savedInstanceState == null) { @@ -364,7 +362,6 @@ class PreviewMediaFragment : ) } - @Suppress("ReturnCount") private fun onOverflowClick(isManualClick: Boolean = false) { val file = file ?: return val storageManager = containerActivity.storageManager ?: return @@ -422,6 +419,7 @@ class PreviewMediaFragment : /** * {@inheritDoc} */ + @Suppress("CyclomaticComplexMethod") private fun onFileActionChosen(itemId: Int) { if (itemId == R.id.action_send_share_file) { if (file.isSharedWithMe && !file.canReshare()) { @@ -502,7 +500,7 @@ class PreviewMediaFragment : private var mErrorMessageId = 0 private val paramsLength = 1 - @Suppress("TooGenericExceptionCaught", "MagicNumber", "ReturnCount", "LongMethod", "NestedBlockDepth") + @Suppress("MagicNumber", "LongMethod", "NestedBlockDepth", "CyclomaticComplexMethod") @Deprecated("Deprecated in Java") override fun doInBackground(vararg params: OCFile?): LoadImage? { Process.setThreadPriority(Process.THREAD_PRIORITY_BACKGROUND + Process.THREAD_PRIORITY_MORE_FAVORABLE) @@ -654,7 +652,6 @@ class PreviewMediaFragment : } } - @Suppress("ReturnCount") private fun generateCheckerboardLayeredDrawable(result: LoadImage, bitmap: Bitmap?): LayerDrawable { val resources = resources val layers = arrayOfNulls(2) diff --git a/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaPagerAdapter.kt b/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaPagerAdapter.kt index 68d5db358d76..f0521e568dec 100644 --- a/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaPagerAdapter.kt +++ b/app/src/main/java/com/owncloud/android/ui/preview/media/PreviewMediaPagerAdapter.kt @@ -55,7 +55,6 @@ class PreviewMediaPagerAdapter( notifyItemRemoved(position) } - @Suppress("TooGenericExceptionCaught") fun getFileAt(position: Int): OCFile? = try { mediaFiles[position] } catch (_: IndexOutOfBoundsException) { diff --git a/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextFragment.kt b/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextFragment.kt index 690d38066648..4e3efd5d28fe 100644 --- a/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextFragment.kt @@ -220,7 +220,7 @@ abstract class PreviewTextFragment : return markwon.toMarkdown(markdown) } - @Suppress("LongParameterList", "ComplexCondition") + @Suppress("ComplexCondition") @JvmStatic fun setText( textView: TextView, diff --git a/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextStringFragment.kt b/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextStringFragment.kt index ead48cb8db5f..a320eecf59a5 100644 --- a/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextStringFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/preview/text/PreviewTextStringFragment.kt @@ -31,7 +31,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("TooGenericExceptionThrown") class PreviewTextStringFragment : PreviewTextFragment() { private var isEditorWebviewLaunched = false diff --git a/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinFragment.kt b/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinFragment.kt index f05adbcdc373..926f2139d38f 100644 --- a/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/trashbin/TrashbinFragment.kt @@ -437,7 +437,6 @@ class TrashbinFragment : } } - @Suppress("ReturnCount") private fun onFileActionChosen(@IdRes itemId: Int, checkedFiles: Set): Boolean { if (checkedFiles.isEmpty()) { return false diff --git a/app/src/main/java/com/owncloud/android/ui/unifiedsearch/IUnifiedSearchRepository.kt b/app/src/main/java/com/owncloud/android/ui/unifiedsearch/IUnifiedSearchRepository.kt index 5d7e56334124..1ca3ced43ecd 100644 --- a/app/src/main/java/com/owncloud/android/ui/unifiedsearch/IUnifiedSearchRepository.kt +++ b/app/src/main/java/com/owncloud/android/ui/unifiedsearch/IUnifiedSearchRepository.kt @@ -12,7 +12,6 @@ import com.owncloud.android.lib.common.SearchResult data class UnifiedSearchResult(val provider: ProviderID, val success: Boolean, val result: SearchResult) -@Suppress("LongParameterList") interface IUnifiedSearchRepository { fun queryAll( query: String, diff --git a/app/src/main/java/com/owncloud/android/ui/unifiedsearch/UnifiedSearchViewModel.kt b/app/src/main/java/com/owncloud/android/ui/unifiedsearch/UnifiedSearchViewModel.kt index 8082dc3cc054..768ba985c3dc 100644 --- a/app/src/main/java/com/owncloud/android/ui/unifiedsearch/UnifiedSearchViewModel.kt +++ b/app/src/main/java/com/owncloud/android/ui/unifiedsearch/UnifiedSearchViewModel.kt @@ -33,7 +33,6 @@ import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch import kotlinx.coroutines.withContext -@Suppress("LongParameterList") class UnifiedSearchViewModel(application: Application) : AndroidViewModel(application), IUnifiedSearchViewModel { diff --git a/app/src/main/java/com/owncloud/android/utils/BitmapUtils.kt b/app/src/main/java/com/owncloud/android/utils/BitmapUtils.kt index b2fe6043ba9f..5e04925d52f4 100644 --- a/app/src/main/java/com/owncloud/android/utils/BitmapUtils.kt +++ b/app/src/main/java/com/owncloud/android/utils/BitmapUtils.kt @@ -49,7 +49,6 @@ import kotlin.math.min import kotlin.math.roundToInt import com.nextcloud.utils.decodeSampledBitmapFromFile as decodeSampledBitmap -@Suppress("TooManyFunctions") object BitmapUtils { private const val TAG = "BitmapUtil" private const val MD5_ALGORITHM = "MD5" @@ -162,7 +161,6 @@ object BitmapUtils { } } - @Suppress("TooGenericExceptionCaught") private fun readExifOrientation(storagePath: String): Int = try { ExifInterface(storagePath).getAttributeInt(ExifInterface.TAG_ORIENTATION, ExifInterface.ORIENTATION_NORMAL) } catch (e: Exception) { diff --git a/app/src/main/java/com/owncloud/android/utils/ClipboardUtil.kt b/app/src/main/java/com/owncloud/android/utils/ClipboardUtil.kt index 2d727024c7f9..324566ac8d47 100644 --- a/app/src/main/java/com/owncloud/android/utils/ClipboardUtil.kt +++ b/app/src/main/java/com/owncloud/android/utils/ClipboardUtil.kt @@ -31,7 +31,6 @@ object ClipboardUtil { @JvmStatic @JvmOverloads - @Suppress("TooGenericExceptionCaught") fun copyToClipboard(activity: Activity, text: String?, showToast: Boolean = true) { if (!MDMConfig.clipBoardSupport(activity)) { return diff --git a/app/src/main/java/com/owncloud/android/utils/EncryptionUtilsV2.kt b/app/src/main/java/com/owncloud/android/utils/EncryptionUtilsV2.kt index b92d5cba134f..f463f4358274 100644 --- a/app/src/main/java/com/owncloud/android/utils/EncryptionUtilsV2.kt +++ b/app/src/main/java/com/owncloud/android/utils/EncryptionUtilsV2.kt @@ -65,7 +65,7 @@ import java.security.cert.X509Certificate import java.util.zip.GZIPInputStream import java.util.zip.GZIPOutputStream -@Suppress("TooManyFunctions", "LargeClass") +@Suppress("LargeClass") class EncryptionUtilsV2 { @VisibleForTesting fun encryptMetadata(metadata: DecryptedMetadata, metadataKey: ByteArray): EncryptedMetadata { @@ -95,7 +95,6 @@ class EncryptionUtilsV2 { return decryptedMetadata } - @Suppress("LongParameterList") fun encryptFolderMetadataFile( metadataFile: DecryptedFolderMetadataFile, userId: String, @@ -143,7 +142,7 @@ class EncryptionUtilsV2 { } @Throws(IllegalStateException::class, UploadException::class, Throwable::class) - @Suppress("LongParameterList", "LongMethod", "ThrowsCount") + @Suppress("LongMethod", "ThrowsCount") fun decryptFolderMetadataFile( metadataFile: EncryptedFolderMetadataFile, userId: String, @@ -300,7 +299,7 @@ class EncryptionUtilsV2 { } @Throws(IllegalStateException::class) - @Suppress("ThrowsCount", "LongParameterList") + @Suppress("ThrowsCount") fun retrieveTopMostMetadata( folder: OCFile, storageManager: FileDataStorageManager, @@ -350,7 +349,7 @@ class EncryptionUtilsV2 { } @Throws(IllegalStateException::class) - @Suppress("ThrowsCount", "LongParameterList") + @Suppress("ThrowsCount") fun retrieveTopMostMetadataKey( folder: OCFile, storageManager: FileDataStorageManager, @@ -467,7 +466,6 @@ class EncryptionUtilsV2 { return metadataFile } - @Suppress("LongParameterList") fun addFileToMetadata( encryptedFileName: String, ocFile: OCFile, @@ -573,7 +571,7 @@ class EncryptionUtilsV2 { } @Throws(IllegalStateException::class) - @Suppress("TooGenericExceptionCaught", "LongMethod") + @Suppress("LongMethod") fun parseAnyMetadata( metadataResponse: MetadataResponse, user: User, @@ -658,7 +656,6 @@ class EncryptionUtilsV2 { } @Throws(UploadException::class) - @Suppress("LongParameterList") fun migrateV1ToV2andUpload( v1: DecryptedFolderMetadataFileV1, userId: String, @@ -762,7 +759,6 @@ class EncryptionUtilsV2 { ) @Throws(UploadException::class) - @Suppress("LongParameterList") fun serializeAndUploadMetadata( folder: OCFile, metadata: DecryptedFolderMetadataFile, @@ -787,7 +783,6 @@ class EncryptionUtilsV2 { } @Throws(UploadException::class) - @Suppress("LongParameterList") fun serializeAndUploadMetadata( remoteId: String, metadata: DecryptedFolderMetadataFile, @@ -847,7 +842,6 @@ class EncryptionUtilsV2 { } } - @Suppress("ReturnCount") fun verifyMetadata( encryptedFolderMetadataFile: EncryptedFolderMetadataFile, decryptedFolderMetadataFile: DecryptedFolderMetadataFile, @@ -905,7 +899,6 @@ class EncryptionUtilsV2 { } } - @Suppress("TooGenericExceptionCaught", "ReturnCount") private fun verifySignedDataViaBouncyCastle(data: CMSSignedData, certs: List): Boolean { val signers = data.signerInfos.signers if (signers.isEmpty()) { diff --git a/app/src/main/java/com/owncloud/android/utils/FileSortOrder.kt b/app/src/main/java/com/owncloud/android/utils/FileSortOrder.kt index b2b8c3dc6610..8dc88bc91c30 100644 --- a/app/src/main/java/com/owncloud/android/utils/FileSortOrder.kt +++ b/app/src/main/java/com/owncloud/android/utils/FileSortOrder.kt @@ -111,7 +111,6 @@ open class FileSortOrder(@JvmField var name: String, var isAscending: Boolean) { } } - @Suppress("ReturnCount") open fun sortCloudFiles( files: MutableList, foldersBeforeFiles: Boolean, diff --git a/app/src/main/java/com/owncloud/android/utils/FileStorageUtils.kt b/app/src/main/java/com/owncloud/android/utils/FileStorageUtils.kt index ecc40735b9fc..f131ca87103b 100644 --- a/app/src/main/java/com/owncloud/android/utils/FileStorageUtils.kt +++ b/app/src/main/java/com/owncloud/android/utils/FileStorageUtils.kt @@ -46,7 +46,6 @@ import java.util.Locale import java.util.TimeZone import com.nextcloud.utils.AppConstants.ONE_SECOND -@Suppress("TooManyFunctions") object FileStorageUtils { private val TAG: String = FileStorageUtils::class.java.simpleName private const val AUTO_UPLOAD_TAG = "AutoUpload" @@ -186,7 +185,6 @@ object FileStorageUtils { } } - @Suppress("LongParameterList") @JvmStatic fun getInstantUploadFilePath( file: File, @@ -336,7 +334,6 @@ object FileStorageUtils { } ?: false } - @Suppress("TooGenericExceptionCaught") @JvmStatic fun deleteRecursively(file: File, storageManager: FileDataStorageManager) { if (file.isDirectory) { @@ -501,7 +498,6 @@ object FileStorageUtils { private fun canListFiles(f: File): Boolean = f.canRead() && f.isDirectory - @Suppress("TooGenericExceptionThrown") @JvmStatic fun checkIfEnoughSpace(file: OCFile): Boolean { val availableSpaceOnDevice = FileOperationsHelper.getAvailableSpaceOnDevice() diff --git a/app/src/main/java/com/owncloud/android/utils/PermissionUtil.kt b/app/src/main/java/com/owncloud/android/utils/PermissionUtil.kt index c67e7046b7cf..dd062ee63b67 100644 --- a/app/src/main/java/com/owncloud/android/utils/PermissionUtil.kt +++ b/app/src/main/java/com/owncloud/android/utils/PermissionUtil.kt @@ -28,7 +28,6 @@ import com.nextcloud.client.preferences.AppPreferencesImpl import com.owncloud.android.lib.common.utils.Log_OC import com.owncloud.android.ui.dialog.StoragePermissionDialogFragment -@Suppress("TooManyFunctions") object PermissionUtil { private const val TAG = "PermissionUtil" diff --git a/app/src/main/java/com/owncloud/android/utils/ProxyUtil.kt b/app/src/main/java/com/owncloud/android/utils/ProxyUtil.kt index 84b32b9ae6d6..22970ef8a430 100644 --- a/app/src/main/java/com/owncloud/android/utils/ProxyUtil.kt +++ b/app/src/main/java/com/owncloud/android/utils/ProxyUtil.kt @@ -23,7 +23,6 @@ class ProxyUtil(private val context: WeakReference) { } @SuppressLint("RequiresFeature") - @Suppress("ReturnCount") fun applyProxy(onApplied: Runnable) { val context = context.get() ?: return val proxyHost = OwnCloudClientManagerFactory.getProxyHost() diff --git a/app/src/main/java/com/owncloud/android/utils/RichDocumentDownloadAsParser.kt b/app/src/main/java/com/owncloud/android/utils/RichDocumentDownloadAsParser.kt index 9dbf1d4a30f5..72b9ad39f983 100644 --- a/app/src/main/java/com/owncloud/android/utils/RichDocumentDownloadAsParser.kt +++ b/app/src/main/java/com/owncloud/android/utils/RichDocumentDownloadAsParser.kt @@ -26,7 +26,6 @@ object RichDocumentDownloadAsParser { private const val TYPE = "Type" private const val FILENAME = "filename" - @Suppress("TooGenericExceptionCaught") fun parse(jsonString: String?): DownloadAs? { if (jsonString.isNullOrBlank()) return null diff --git a/app/src/main/java/com/owncloud/android/utils/SyncedFolderUtils.kt b/app/src/main/java/com/owncloud/android/utils/SyncedFolderUtils.kt index 98c7c6ce4c41..9d2592d15ed9 100644 --- a/app/src/main/java/com/owncloud/android/utils/SyncedFolderUtils.kt +++ b/app/src/main/java/com/owncloud/android/utils/SyncedFolderUtils.kt @@ -179,7 +179,6 @@ object SyncedFolderUtils { return false } - @Suppress("ReturnCount") fun validateForAutoUpload(path: String?): File? { val file = path?.toFile() if (file == null) { diff --git a/app/src/main/java/com/owncloud/android/utils/UriUtils.kt b/app/src/main/java/com/owncloud/android/utils/UriUtils.kt index fde89b8dcef0..3e47f1178224 100644 --- a/app/src/main/java/com/owncloud/android/utils/UriUtils.kt +++ b/app/src/main/java/com/owncloud/android/utils/UriUtils.kt @@ -42,7 +42,6 @@ object UriUtils { return displayName?.replace("/".toRegex(), "-") } - @Suppress("TooGenericExceptionCaught") private fun getDisplayNameFromContentResolver(uri: Uri, context: Context): String? { val mimeType = context.contentResolver.getType(uri) ?: return null val displayNameColumn: String = getDisplayNameColumnForMimeType(mimeType) diff --git a/app/src/main/java/com/owncloud/android/utils/crypto/CryptoHelper.kt b/app/src/main/java/com/owncloud/android/utils/crypto/CryptoHelper.kt index 8228a29a1fa2..034df5bcd0d0 100644 --- a/app/src/main/java/com/owncloud/android/utils/crypto/CryptoHelper.kt +++ b/app/src/main/java/com/owncloud/android/utils/crypto/CryptoHelper.kt @@ -40,7 +40,7 @@ object CryptoHelper { private val charset = StandardCharsets.UTF_8 // region Decrypt - @Suppress("TooGenericExceptionCaught", "LongMethod", "ThrowsCount") + @Suppress("LongMethod", "ThrowsCount") fun decryptPrivateKey(privateKey: String, keyPhrase: String): String { if (privateKey.isEmpty()) { throw CryptoError.EmptyPrivateKey() diff --git a/app/src/main/java/com/owncloud/android/utils/glide/GlideStringStreamFetcher.kt b/app/src/main/java/com/owncloud/android/utils/glide/GlideStringStreamFetcher.kt index e34afb909563..4ca118d3b9a1 100644 --- a/app/src/main/java/com/owncloud/android/utils/glide/GlideStringStreamFetcher.kt +++ b/app/src/main/java/com/owncloud/android/utils/glide/GlideStringStreamFetcher.kt @@ -27,7 +27,6 @@ class GlideStringStreamFetcher(private val url: String?) : DataFetcher) { try { val ownCloudAccount = UserAccountManagerImpl.fromContext(MainApp.getAppContext()).currentOwnCloudAccount diff --git a/app/src/main/java/com/owncloud/android/utils/glide/HttpStreamFetcher.kt b/app/src/main/java/com/owncloud/android/utils/glide/HttpStreamFetcher.kt index f519b4a3c701..01d14c25ac44 100644 --- a/app/src/main/java/com/owncloud/android/utils/glide/HttpStreamFetcher.kt +++ b/app/src/main/java/com/owncloud/android/utils/glide/HttpStreamFetcher.kt @@ -20,7 +20,6 @@ import org.apache.commons.httpclient.methods.GetMethod import java.io.IOException import java.io.InputStream -@Suppress("TooGenericExceptionCaught") class HttpStreamFetcher internal constructor(private val url: String) : DataFetcher { private var stream: InputStream? = null diff --git a/app/src/main/java/com/owncloud/android/utils/svg/SvgBitmapDecoder.kt b/app/src/main/java/com/owncloud/android/utils/svg/SvgBitmapDecoder.kt index 57b8e1b2d238..8d233d9e2fea 100644 --- a/app/src/main/java/com/owncloud/android/utils/svg/SvgBitmapDecoder.kt +++ b/app/src/main/java/com/owncloud/android/utils/svg/SvgBitmapDecoder.kt @@ -51,7 +51,6 @@ class SvgBitmapDecoder(private val bitmapPool: BitmapPool) : ResourceDecoder { val isOriginalSize = width == Target.SIZE_ORIGINAL || height == Target.SIZE_ORIGINAL diff --git a/app/src/main/java/com/owncloud/android/utils/svg/SvgOrImageBitmapTranscoder.kt b/app/src/main/java/com/owncloud/android/utils/svg/SvgOrImageBitmapTranscoder.kt index 6199420c986e..50f7b17fdd64 100644 --- a/app/src/main/java/com/owncloud/android/utils/svg/SvgOrImageBitmapTranscoder.kt +++ b/app/src/main/java/com/owncloud/android/utils/svg/SvgOrImageBitmapTranscoder.kt @@ -21,7 +21,6 @@ import com.owncloud.android.lib.common.utils.Log_OC /** * Convert the [SVG]'s internal representation to a Bitmap. */ -@Suppress("ReturnCount") class SvgOrImageBitmapTranscoder(private val width: Int, private val height: Int) : ResourceTranscoder { override fun transcode(toTranscode: Resource, options: Options): Resource? { diff --git a/app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt b/app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt index aa344b5be4c1..5b2c6701e078 100644 --- a/app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt +++ b/app/src/main/java/com/owncloud/android/utils/theme/FilesSpecificViewThemeUtils.kt @@ -47,7 +47,6 @@ import me.zhanghai.android.fastscroll.FastScrollerBuilder import me.zhanghai.android.fastscroll.PopupStyles import javax.inject.Inject -@Suppress("TooManyFunctions") class FilesSpecificViewThemeUtils @Inject constructor( schemes: MaterialSchemes, private val colorUtil: ColorUtil, diff --git a/app/src/test/java/com/nextcloud/client/logger/FileLogHandlerTest.kt b/app/src/test/java/com/nextcloud/client/logger/FileLogHandlerTest.kt index eae1c4bb4c16..0009842847e7 100644 --- a/app/src/test/java/com/nextcloud/client/logger/FileLogHandlerTest.kt +++ b/app/src/test/java/com/nextcloud/client/logger/FileLogHandlerTest.kt @@ -15,7 +15,6 @@ import java.io.File import java.nio.charset.Charset import java.nio.file.Files -@Suppress("TooManyFunctions") class FileLogHandlerTest { private companion object { diff --git a/app/src/test/java/com/nextcloud/client/logger/LoggerTest.kt b/app/src/test/java/com/nextcloud/client/logger/LoggerTest.kt index 4d4cf41481e1..42114e551ebb 100644 --- a/app/src/test/java/com/nextcloud/client/logger/LoggerTest.kt +++ b/app/src/test/java/com/nextcloud/client/logger/LoggerTest.kt @@ -303,7 +303,6 @@ class LoggerTest { } @Test - @Suppress("TooGenericExceptionCaught") fun `thread interruption is handled while posting log message`() { Thread { val callerThread = Thread.currentThread() diff --git a/app/src/test/java/com/nextcloud/client/utils/FileSortOrderBySizeTests.kt b/app/src/test/java/com/nextcloud/client/utils/FileSortOrderBySizeTests.kt index 9e3d24039ed2..33b896c7d139 100644 --- a/app/src/test/java/com/nextcloud/client/utils/FileSortOrderBySizeTests.kt +++ b/app/src/test/java/com/nextcloud/client/utils/FileSortOrderBySizeTests.kt @@ -16,7 +16,7 @@ import org.junit.Before import org.junit.After import java.io.File -@Suppress("TooManyFunctions", "MagicNumber") +@Suppress("MagicNumber") class FileSortOrderBySizeTests { private lateinit var tempDir: File diff --git a/app/src/test/java/com/nextcloud/client/utils/FileStorageUtilsTest.kt b/app/src/test/java/com/nextcloud/client/utils/FileStorageUtilsTest.kt index c5f2f60221c5..22c03a63be33 100644 --- a/app/src/test/java/com/nextcloud/client/utils/FileStorageUtilsTest.kt +++ b/app/src/test/java/com/nextcloud/client/utils/FileStorageUtilsTest.kt @@ -30,7 +30,7 @@ import java.io.File import java.util.Locale import java.util.TimeZone -@Suppress("TooManyFunctions", "LargeClass") +@Suppress("LargeClass") class FileStorageUtilsTest { @get:Rule @@ -742,7 +742,6 @@ class FileStorageUtilsTest { assertEquals("/storage/x", FileStorageUtils.pathToUserFriendlyDisplay("/storage/x", null, mock())) } - @Suppress("LongParameterList") private fun instantUploadPath( remotePath: String = "/Camera", syncedFolderLocalPath: String? = "/sdcard/DCIM", diff --git a/app/src/test/java/com/nextcloud/client/utils/FolderSizeCalculationTests.kt b/app/src/test/java/com/nextcloud/client/utils/FolderSizeCalculationTests.kt index 788dcfab7a13..5741e4a29c3a 100644 --- a/app/src/test/java/com/nextcloud/client/utils/FolderSizeCalculationTests.kt +++ b/app/src/test/java/com/nextcloud/client/utils/FolderSizeCalculationTests.kt @@ -14,7 +14,7 @@ import org.junit.Before import org.junit.Test import java.io.File -@Suppress("TooManyFunctions", "MagicNumber") +@Suppress("MagicNumber") class FolderSizeCalculationTests { private lateinit var testDir: File diff --git a/app/src/test/java/com/nextcloud/client/utils/NaturalSortTest.kt b/app/src/test/java/com/nextcloud/client/utils/NaturalSortTest.kt index d3e90ccb73ed..3b7e0b9270dd 100644 --- a/app/src/test/java/com/nextcloud/client/utils/NaturalSortTest.kt +++ b/app/src/test/java/com/nextcloud/client/utils/NaturalSortTest.kt @@ -21,7 +21,6 @@ import kotlin.random.Random * Adapted from https://github.com/nextcloud/server/blob/master/tests/lib/NaturalSortTest.php * */ -@Suppress("TooManyFunctions") class NaturalSortTest { private lateinit var defaultLocale: Locale diff --git a/app/src/test/java/com/owncloud/android/datamodel/MoveFileEntitiesUpdateTest.kt b/app/src/test/java/com/owncloud/android/datamodel/MoveFileEntitiesUpdateTest.kt index c1f07fdacce0..a2cd6107715b 100644 --- a/app/src/test/java/com/owncloud/android/datamodel/MoveFileEntitiesUpdateTest.kt +++ b/app/src/test/java/com/owncloud/android/datamodel/MoveFileEntitiesUpdateTest.kt @@ -14,7 +14,6 @@ import org.junit.Assert.assertEquals import org.junit.Assert.assertNull import org.junit.Test -@Suppress("TooManyFunctions") class MoveFileEntitiesUpdateTest : MoveFilesTestBase() { private val capturedEntities = slot>() diff --git a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesFilesystemAndMediaTest.kt b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesFilesystemAndMediaTest.kt index 320a67abbc0a..d9d059dd3729 100644 --- a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesFilesystemAndMediaTest.kt +++ b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesFilesystemAndMediaTest.kt @@ -20,7 +20,6 @@ import org.junit.Test import java.io.File import java.nio.file.Files -@Suppress("TooManyFunctions") class MoveFilesFilesystemAndMediaTest : MoveFilesTestBase() { private lateinit var tempDir: File diff --git a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesGuardTest.kt b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesGuardTest.kt index ac30847f7e88..ccd114cb7c06 100644 --- a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesGuardTest.kt +++ b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesGuardTest.kt @@ -11,7 +11,6 @@ import io.mockk.every import io.mockk.verify import org.junit.Test -@Suppress("TooManyFunctions") class MoveFilesGuardTest : MoveFilesTestBase() { @Test diff --git a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesHierarchyTest.kt b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesHierarchyTest.kt index 412922789c6e..d8a71f3090f6 100644 --- a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesHierarchyTest.kt +++ b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesHierarchyTest.kt @@ -19,7 +19,6 @@ import org.junit.Test import java.io.File import java.nio.file.Files -@Suppress("TooManyFunctions") class MoveFilesHierarchyTest : MoveFilesTestBase() { private lateinit var tempDir: File diff --git a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesTestBase.kt b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesTestBase.kt index 4f70a9a6e8f1..018d5a91c94b 100644 --- a/app/src/test/java/com/owncloud/android/datamodel/MoveFilesTestBase.kt +++ b/app/src/test/java/com/owncloud/android/datamodel/MoveFilesTestBase.kt @@ -29,7 +29,7 @@ import io.mockk.unmockkAll import org.junit.After import org.junit.Before -@Suppress("LongParameterList", "TooManyFunctions", "DEPRECATION") +@Suppress("DEPRECATION") abstract class MoveFilesTestBase { companion object { diff --git a/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/MockOCFileListAdapterDataProvider.kt b/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/MockOCFileListAdapterDataProvider.kt index 19b3ed2aa5d8..5b3e47b5bce6 100644 --- a/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/MockOCFileListAdapterDataProvider.kt +++ b/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/MockOCFileListAdapterDataProvider.kt @@ -11,7 +11,7 @@ import com.nextcloud.client.database.entity.FileEntity import com.owncloud.android.datamodel.OCFile import com.owncloud.android.utils.MimeType -@Suppress("LongParameterList", "MagicNumber") +@Suppress("MagicNumber") class MockOCFileListAdapterDataProvider : OCFileListAdapterDataProvider { private var offlineOCFile: OCFile? = null diff --git a/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelperTest.kt b/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelperTest.kt index 379d716a5a14..3e35e7d08281 100644 --- a/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelperTest.kt +++ b/app/src/test/java/com/owncloud/android/ui/adapter/filelist/data/OCFileListAdapterHelperTest.kt @@ -22,7 +22,7 @@ import org.junit.Assert.assertEquals import org.junit.Before import org.junit.Test -@Suppress("LongMethod", "LongParameterList") +@Suppress("LongMethod") class OCFileListAdapterHelperTest { private val context = mockk(relaxed = true) diff --git a/app/src/test/java/com/owncloud/android/ui/db/ParentFolderFinderTest.kt b/app/src/test/java/com/owncloud/android/ui/db/ParentFolderFinderTest.kt index 1128c7a6b751..c078ef4821bd 100644 --- a/app/src/test/java/com/owncloud/android/ui/db/ParentFolderFinderTest.kt +++ b/app/src/test/java/com/owncloud/android/ui/db/ParentFolderFinderTest.kt @@ -18,7 +18,7 @@ import junit.framework.TestCase.assertNull import org.junit.Before import org.junit.Test -@Suppress("TooManyFunctions", "MagicNumber") +@Suppress("MagicNumber") class ParentFolderFinderTest { private lateinit var storageManager: FileDataStorageManager diff --git a/app/src/test/java/com/owncloud/android/utils/AutoUploadFileMatchingTests.kt b/app/src/test/java/com/owncloud/android/utils/AutoUploadFileMatchingTests.kt index e392dccaf9a7..db102b1ac131 100644 --- a/app/src/test/java/com/owncloud/android/utils/AutoUploadFileMatchingTests.kt +++ b/app/src/test/java/com/owncloud/android/utils/AutoUploadFileMatchingTests.kt @@ -20,7 +20,6 @@ import org.junit.Before import org.junit.Test import java.io.File -@Suppress("TooManyFunctions") class AutoUploadFileMatchingTests { companion object { diff --git a/app/src/test/java/com/owncloud/android/utils/E2EVersionHelperTest.kt b/app/src/test/java/com/owncloud/android/utils/E2EVersionHelperTest.kt index a1de660cf7ac..f61abf0c41ec 100644 --- a/app/src/test/java/com/owncloud/android/utils/E2EVersionHelperTest.kt +++ b/app/src/test/java/com/owncloud/android/utils/E2EVersionHelperTest.kt @@ -21,7 +21,6 @@ import org.junit.After import org.junit.Before import org.junit.Test -@Suppress("TooManyFunctions") class E2EVersionHelperTest { @Before