From 3dbcf4f1caf5e15e804a9dc897d0c59be84336fa Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Fri, 31 Jul 2026 11:31:25 +0200 Subject: [PATCH] refactor: use built-in `Error.isError` --- packages/app/scripts/testing/test-matrix.mts | 2 +- packages/app/test/windows/copyAndReplace.test.mts | 4 ++-- packages/app/tsconfig.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/app/scripts/testing/test-matrix.mts b/packages/app/scripts/testing/test-matrix.mts index 5741294f6..c9ac58990 100644 --- a/packages/app/scripts/testing/test-matrix.mts +++ b/packages/app/scripts/testing/test-matrix.mts @@ -404,7 +404,7 @@ if (platforms.length === 0) { process.exitCode = e; } else { process.exitCode = 1; - showBanner(`❌ ${(e instanceof Error && e.stack) || e}`); + showBanner(`❌ ${(Error.isError(e) && e.stack) || e}`); } }); } diff --git a/packages/app/test/windows/copyAndReplace.test.mts b/packages/app/test/windows/copyAndReplace.test.mts index 3b5aa1eb6..9253b52b3 100644 --- a/packages/app/test/windows/copyAndReplace.test.mts +++ b/packages/app/test/windows/copyAndReplace.test.mts @@ -48,14 +48,14 @@ describe("copyAndReplace()", () => { it("throws on error", async () => { await rejects(copyAndReplace("ReactTestApp.png", "", {}), (err) => { - if (!(err instanceof Error)) { + if (!Error.isError(err)) { fail("Expected an Error"); } match(err.message, /ENOENT/); return true; }); await rejects(copyAndReplace("ReactTestApp.sln", "", {}), (err) => { - if (!(err instanceof Error)) { + if (!Error.isError(err)) { fail("Expected an Error"); } match(err.message, /ENOENT/); diff --git a/packages/app/tsconfig.json b/packages/app/tsconfig.json index a91bf59d9..b0f657eba 100644 --- a/packages/app/tsconfig.json +++ b/packages/app/tsconfig.json @@ -4,7 +4,7 @@ "target": "esnext", "allowImportingTsExtensions": true, "noEmit": true, - "lib": ["ES2022", "DOM"] + "lib": ["esnext", "dom"] }, "include": [ "**/*.mjs",